[
https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545739#comment-17545739
]
David Smiley commented on SOLR-14699:
-------------------------------------
Joel: Thanks for trying it out!
Supporting both formats would be annoying; most especially in SolrLogPostTool;
maybe we can just do this change for Solr 10? Or only do the SolrLogPostTool
side of it in 10?
Jan: JsonTemplateLayout is generic; it doesn't know that some messages might in
fact be JSON themselves (as this issue proposes). Nazerke and I have a custom
variant of that for "at work" where it's aware of the format of certain
messages and so we get more interesting JSON for these log records. It'd be
interesting if JsonTemplateLayout could support that.
> Solr request logs should escape names, values
> (SolrQueryResponse.getToLogAsString)
> ----------------------------------------------------------------------------------
>
> Key: SOLR-14699
> URL: https://issues.apache.org/jira/browse/SOLR-14699
> Project: Solr
> Issue Type: Improvement
> Components: logging
> Reporter: David Smiley
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {{SolrQueryResponse.getToLogAsString}} encodes the NamedList into a String
> with simple space-separated pairs with name=value. However, it does no
> escaping/encoding, and as-such a value might itself contain spaces and
> equals. This is a problem if these logs are being parsed, and we'd like to
> ensure we do so correctly. Note that SolrLogPostTool (aka "postlogs") parses
> these logs.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
