epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888074015
########## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ########## @@ -51,7 +57,7 @@ https://docs.datadoghq.com/tracing/setup/java/[datadog-java-agent] uses Javaagen The `modules/jagertracer-configurator` provides a default implementation for setting up Jaeger Tracer. Add the solr-jaegertracer JAR file and the other JARs provided with this module to your Solr installation, ideally to each node. -GSON is a dependency that is only used by Jaeger's "remote" sampler, +https://github.com/google/gson[GSON] is a dependency that is only used by Jaeger's "remote" sampler, Review Comment: So, reading through https://www.jaegertracing.io/docs/1.34/sampling/ that is why you would need GSON.... We could clarify the docs a bit (or reference https://www.jaegertracing.io/docs/1.34/sampling/) and then fix the build.gradle to not include gson. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
