laminelam commented on PR #857: URL: https://github.com/apache/solr/pull/857#issuecomment-1144887062
> I think we need to have a bigger discussion around backwards compatibility and how we achieve that. > > I would prefer to keep everything nice and neat, instead of spreading classes across packages. Also this will impact whether we have to keep the old `VMParamsAllAnd.....Provider` classes around, which hopefully we will not have to. We are only changing this ``` -DzkACLProvider=org.apache.solr.common.cloud.VMParamsAllAndReadonlyDigestZkACLProvider -DzkCredentialsProvider=org.apache.solr.common.cloud.VMParamsSingleSetCredentialsDigestZkCredentialsProvider ``` to this ``` -DzkACLProvider=org.apache.solr.common.cloud.acl.DigestZkACLProvider -DzkCredentialsProvider=org.apache.solr.common.cloud.acl.DigestZkCredentialsProvider -DzkCredentialsInjector=org.apache.solr.common.cloud.acl.VMParamsZkCredentialsInjector ``` The existing configs (solr.ini.* and zkcli.*) using the old VM params will still work as the existing classes (_VMParamsAllAndReadonlyDigestZkACLProvider_ and _VMParamsSingleSetCredentialsDigestZkCredentialsProvider_) are not removed (only deprecated). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org