Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r152972034
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
---
@@ -306,51 +306,88 @@ public
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r152972315
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
---
@@ -729,6 +804,12 @@ public Void
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/5066
[FLINK-8148][yarn/s3] fix test instability in YarnFileStageTestS3ITCase
## What is the purpose of the change
`YarnFileStageTestS3ITCase.testRecursiveUploadForYarn` verifies that the
test
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4581
(arg - I guess I should really fix my default file template some time...)
-> the latest commit fixes the missing license text in the new test file
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4594
Yes @zhijiangW, I kept the original logic.
I guess, the reasoning behind using off-heap netty buffers only was to
reduce the overhead before transmitting messages over the wire: 1) we reduce GC
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4552#discussion_r152985049
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
---
@@ -224,17 +224,9 @@ public void registerTask(Task task
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r153253247
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -572,20 +560,53 @@ void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153263139
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -274,4 +313,49 @@ private void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153266186
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -539,4 +542,60 @@ static CloseRequest
readFrom
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153261175
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -152,6 +170,26 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153269318
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -283,10 +283,13 @@ public String
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153258008
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -88,6 +98,15 @@ void cancelRequestFor
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4581
sorry about that - tested locally now and it should go through...we'll see
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4581
test failures are unrelated this time (failing kafka download for the
end-to-end tests)
---
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r153441043
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -306,12 +306,10 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153445970
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -283,10 +283,13 @@ public String
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153456963
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -145,19 +171,29 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153447906
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -584,4 +587,60 @@ static CloseRequest
readFrom
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153456919
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -122,21 +136,33 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153448085
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyMessageSerializationTest.java
---
@@ -158,6 +158,15 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153446896
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -102,13 +102,21 @@ void cancelRequestFor
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153457551
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,8 +244,79 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153455324
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,8 +244,79 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153455238
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,8 +244,79 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153460586
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -584,4 +587,60 @@ static CloseRequest
readFrom
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153454649
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,8 +244,79 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153457926
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,8 +244,79 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153456278
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -230,7 +230,7 @@ void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r153563915
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionView.java
---
@@ -39,13 +39,15 @@
private
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r153564111
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CancelPartitionRequestTest.java
---
@@ -174,19 +175,21 @@ public
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r153564062
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -133,7 +135,7 @@ int releaseMemory
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r153564859
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionView.java
---
@@ -22,32 +22,52 @@
import
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r153564080
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpilledSubpartitionView.java
---
@@ -114,7 +116,7 @@ public void
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4374
but honestly, the previous approach just looks wrong: adding it and in case
of a conflict reverting that `put` operation.
What if (and I'm walking in the dark here) something already operat
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4559
Regarding b): I just checked with #4552 and it looks as if the `backlog` is
increased from the `ResultWriter` / task thread, and then both read and
decreased from netty's IO thread. Therefore,
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4552
Ok, I think, I'll manage the review without the split.
Since this is the last of the credit-based PRs though, can you rebase on
top of the latest changes (preferably after addressin
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/5066
oh, sorry for that
---
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5104#discussion_r154024973
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java
---
@@ -107,6 +110,7 @@ public
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154026730
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -584,4 +587,60 @@ static CloseRequest
readFrom
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154027406
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -283,10 +283,13 @@ public String
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154067761
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
---
@@ -34,12 +31,10 @@
* The {@link
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154080335
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/DummyEnvironment.java
---
@@ -190,4 +191,8 @@ public InputGate
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154337233
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -223,11 +229,13 @@ void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154338491
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -244,54 +237,89 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154336638
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClient.java
---
@@ -167,6 +167,13 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154322427
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -244,54 +237,89 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154319502
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -108,17 +117,75 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154322032
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -244,54 +237,89 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154316689
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -170,29 +172,20 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154318828
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -378,6 +381,11 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154338695
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -244,54 +237,89 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154315390
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -144,20 +147,19 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154321327
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -244,54 +237,89 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154318950
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -280,94 +280,120 @@ public String
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154321125
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -244,54 +237,89 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154338813
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -244,54 +237,89 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154320189
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -244,54 +237,89 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154321304
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -244,54 +237,89 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r154343587
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionView.java
---
@@ -22,32 +22,57 @@
import
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r154343656
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionView.java
---
@@ -22,32 +22,57 @@
import
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r154344942
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CancelPartitionRequestTest.java
---
@@ -174,19 +175,21 @@ public
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r154344924
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpilledSubpartitionView.java
---
@@ -114,7 +116,7 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r154344889
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -133,7 +135,7 @@ int releaseMemory
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r154343510
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionView.java
---
@@ -39,13 +39,15 @@
private
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6115
alright - tried that change which also has the advantage of not using up
memory for the `templateKey` - these are the results from the same Benchmark
(same hardware, new software though, so I also re
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6291
@yanghua sure, why not ... although there's no performance problem in
string concatenation for exceptions - we'll abort anyway
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/5381
@zhijiangW is this PR still useful? if so, was there any progress?
---
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5900#discussion_r201965094
--- Diff: docs/quickstart/java_api_quickstart.md ---
@@ -101,23 +111,210 @@ allows to [import Maven
projects](http://books.sonatype.com/m2eclipse-book/refer
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6272#discussion_r201969455
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
---
@@ -277,37 +277,17 @@ public void recycle
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6272#discussion_r201970654
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -360,32 +360,44 @@ public boolean
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6272#discussion_r201971896
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -360,32 +360,44 @@ public boolean
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6271
merging...
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6291
merging...
---
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5900#discussion_r202066470
--- Diff: docs/quickstart/java_api_quickstart.md ---
@@ -101,23 +111,210 @@ allows to [import Maven
projects](http://books.sonatype.com/m2eclipse-book/refer
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/6327
[FLINK-9839][e2e] add a streaming allround test with SSL enabled
## What is the purpose of the change
Currently, there's no simple streaming job test like the
`test_batch_allround.sh
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/6328
[FLINK-9816][network] add option to configure SSL engine provider for TM
communication
## What is the purpose of the change
Netty has the ability to run with different `SSLEngine
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6327
Thanks, I'll have a second look at this PR once I can actually test it :)
(maybe enabling SSL for the `test_streaming_kafka010.sh` test or so)
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6326
Can you also update `ops/security-ssl.md` with the updated configuration?
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6327
Rebased and enabled SSL only for already existing e2e tests - since the old
configuration values for enabling SSL communication for all components
`security.ssl.enabled` was retained though, #6326 did
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6327#discussion_r202650635
--- Diff: flink-end-to-end-tests/test-scripts/common.sh ---
@@ -183,9 +221,15 @@ function start_cluster {
"$FLINK_DIR"/bin/start-
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6327#discussion_r202650892
--- Diff: flink-end-to-end-tests/test-scripts/common.sh ---
@@ -148,6 +151,41 @@ function create_ha_config() {
EOL
}
+function set_conf_ssl
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6327
Thanks for the review @zentol.
Yes, this PR will fail until #6340 is merged.
Regarding the warning: I did not want to bother with different formats
here, but you're right: a follow-
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6340#discussion_r202653111
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandlerTest.java
---
@@ -57,24 +60,39 @@
/**
* Tests for
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6294#discussion_r202719580
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
---
@@ -65,7 +65,11 @@
key
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6294#discussion_r202722162
--- Diff: docs/ops/deployment/yarn_setup.md ---
@@ -132,7 +132,7 @@ Stop the YARN session by stopping the unix process
(using CTRL+C) or by entering
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6294#discussion_r202720821
--- Diff: docs/ops/deployment/yarn_setup.md ---
@@ -132,7 +132,7 @@ Stop the YARN session by stopping the unix process
(using CTRL+C) or by entering
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6294#discussion_r202720265
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
---
@@ -65,7 +65,11 @@
key
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/6355
[FLINK-9878][network][ssl] add more low-level ssl options
## What is the purpose of the change
This is mostly to tackle bugs like https://github.com/netty/netty/issues/832
(JDK issue
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6355
about the travis error: I tried regenerating the configuration page from
the sources but it does not change at all and the "documentation outdated"
remains :(
---
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/6363
[FLINK-9860][REST] fix buffer leak in FileUploadHandler
## What is the purpose of the change
The current implementation of `FileUploadHandler` has two cases where the
given message was not
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6363#discussion_r203398509
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java
---
@@ -50,6 +55,24 @@
private static final
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r203405530
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java ---
@@ -160,4 +160,41 @@
key("security.ssl.v
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6363#discussion_r203432013
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r203617345
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java ---
@@ -160,4 +160,41 @@
key("security.ssl.v
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r203652882
--- Diff: docs/ops/security-ssl.md ---
@@ -33,6 +33,9 @@ SSL can be enabled for all network communication between
Flink components. SSL k
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6272
rebased to solve the merge conflict (auto-solved by git though)
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6115
Thanks for the review, merging...
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6272
Thanks for the review, merging...
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4035
change looks good but fails the new checkstyle rules:
```
[INFO] There are 4 errors reported by Checkstyle 6.19 with
/tools/maven/strict-checkstyle.xml ruleset.
[ERROR]
src/test/java
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4174
[FLINK-6916][blob] more code style and test improvements
This is the third PR towards a FLIP-19 reworking the BLOB store. This PR
builds upon #4158 and includes the following:
* remove code
501 - 600 of 1008 matches
Mail list logo
