Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6340#discussion_r202653111
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandlerTest.java
 ---
    @@ -57,24 +60,39 @@
     /**
      * Tests for the {@link JobSubmitHandler}.
      */
    +@RunWith(Parameterized.class)
     public class JobSubmitHandlerTest extends TestLogger {
     
    +   @Parameterized.Parameters(name = "SSL enabled: {0}")
    +   public static Iterable<Boolean> data() {
    +           return Arrays.asList(true, false);
    +   }
    +
        @ClassRule
        public static final TemporaryFolder TEMPORARY_FOLDER = new 
TemporaryFolder();
    -   private static BlobServer blobServer;
     
    -   @BeforeClass
    -   public static void setup() throws IOException {
    -           Configuration config = new Configuration();
    +   private final Configuration sslConfig;
    --- End diff --
    
    Strictly speaking, this is not the SSL config (only), but just the 
configuration with potentially more content - maybe rename?


---

Reply via email to