Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r153263139
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
 ---
    @@ -274,4 +313,49 @@ private void decodeBufferOrEvent(RemoteInputChannel 
inputChannel, NettyMessage.B
                        bufferOrEvent.releaseBuffer();
                }
        }
    +
    +   private void writeAndFlushNextMessageIfPossible(Channel channel) {
    --- End diff --
    
    Please add some javadoc with a hint how all `inputChannelsWithCredit` will 
be handled, i.e. one is written immediately, following ones after successful 
writes.


---

Reply via email to