Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r154318828
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ---
    @@ -378,6 +381,11 @@ public void notifyBufferDestroyed() {
                // Nothing to do actually.
        }
     
    +   @VisibleForTesting
    +   public void increaseCredit(int credit) {
    --- End diff --
    
    I think we can live without this method that should never be called outside 
the tests (since it modifies state): creating a `BufferResponse` with an 
appropriate backlog should yield the same result in the tests


---

Reply via email to