GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/2370
[FLINK-4373] [cluster management] Introduce SlotID, AllocationID, Resâ¦
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2370#discussion_r74863897
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/AllocationID.java
---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2370#discussion_r74864046
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2370
Hi @tillrohrmann , thanks for the reviewing, all your comments have been
addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user KurtYoung closed the pull request at:
https://github.com/apache/flink/pull/2370
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2370
@tillrohrmann Yeah, of course. Closing it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/2388
[FLINK-4347][cluster management] Implement SlotManager core
Implement some SlotManager's logic mainly in 4 parts:
* handle slot request initiated by JobMaster
* sync slot status trigg
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2388
hi @tillrohrmann , thanks for the reviewing, all your comments will be
addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/2424
[FLINK-4459][Scheduler] Introduce SlotProvider for Scheduler
Introduce SlotProvider, prepare for the further slot allocation refactoring
You can merge this pull request into a Git repository by
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2388
I think i shall do the resolving thing.
The commits are squashed and conflicts been resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2388
Yes, this is for ResourceManager
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2388#discussion_r76919875
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/SlotManager.java
---
@@ -0,0 +1,525 @@
+/*
+ * Licensed to the
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2388#discussion_r76919953
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/SlotManager.java
---
@@ -0,0 +1,525 @@
+/*
+ * Licensed to the
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2388#discussion_r76920002
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotID.java
---
@@ -75,9 +75,15 @@ public int hashCode
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2388#discussion_r76919993
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceID.java
---
@@ -63,9 +63,7 @@ public final int hashCode
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2388#discussion_r76920351
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotID.java
---
@@ -75,9 +75,15 @@ public int hashCode
Github user KurtYoung closed the pull request at:
https://github.com/apache/flink/pull/2388
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r77101490
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotAllocationFuture.java
---
@@ -20,73 +20,125 @@
import
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/2480
[FLINK-4408][JobManager] Introduce JobMasterRunner and implement job
submission & setting up the ExecutionGraph
Introduce JobMasterRunner to deal with job level leader election and
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2472#discussion_r77970498
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/impl/FlinkCompletableFuture.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2472#discussion_r77971053
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/impl/FlinkCompletableFuture.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/2497
[FLINK-4339][cluster management] Implement Slot Pool core on JobManager
Introduce __SlotDescriptor__ to hold static information of a __Slot__.
__Slot__ is used as runtime objects and contains
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3406
Hi @fhueske , i like your propose about moving the annotation from
`TableSource` to `TableSourceConverter`. Lets do it this way.
BTW, i noticed that you offered three possible methods to the
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3488
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3510#discussion_r105417009
--- Diff: docs/dev/stream/process_function.md ---
@@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends
RichProcessFunction
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3510#discussion_r105418830
--- Diff: docs/dev/stream/process_function.md ---
@@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends
RichProcessFunction
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3510#discussion_r105420011
--- Diff: docs/dev/stream/process_function.md ---
@@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends
RichProcessFunction
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3510#discussion_r105420103
--- Diff: docs/dev/stream/process_function.md ---
@@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends
RichProcessFunction
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3510#discussion_r105419777
--- Diff: docs/dev/stream/process_function.md ---
@@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends
RichProcessFunction
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3510#discussion_r105422108
--- Diff: docs/dev/stream/process_function.md ---
@@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends
RichProcessFunction
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3510
Thanks @maocorte for the quick fix, looks good to merge now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/3520
[FLINK-3849] [table] Add FilterableTableSource interface and rules for
pushing it
This PR is based on #3166 , and added following changes:
1. Refactor `RexProgramExpressionExtractor` and
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3520
To address the problem of not reusing `TableSource` when we create a new
scan for table source, i changed some inheritance for current `BatchScan`,
`StreamScan`, `BatchTableSourceScan
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3530#discussion_r105869656
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/datastream/DataStreamUserDefinedFunctionITCase.scala
---
@@ -85,6
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3530
looks good, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106321885
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/ProjectableTableSource.scala
---
@@ -24,7 +24,7 @@ package
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106322568
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetCalc.scala
---
@@ -42,63 +41,40 @@ class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106324868
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala
---
@@ -39,4 +39,6 @@ trait TableSource[T
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106324883
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/BatchTableSourceScan.scala
---
@@ -58,16 +60,24 @@ class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106327707
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala
---
@@ -0,0
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106329079
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala
---
@@ -0,0
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106329099
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala
---
@@ -0,0 +1,184
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106328751
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/TableSourceTable.scala
---
@@ -25,6 +25,7 @@ import
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106329225
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/PushFilterIntoStreamTableSourceScanRule.scala
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106329219
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/PushFilterIntoBatchTableSourceScanRule.scala
---
@@ -0,0
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106335660
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala
---
@@ -0,0 +1,184
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106335709
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala
---
@@ -0,0 +1,184
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106335718
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FilterableTableSource.scala
---
@@ -0,0 +1,66
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3520
Hi @fhueske @godfreyhe, thanks for the review, i addressed most all your
comments.
@fhueske Except for letting `TableSourceScan` be aware of whether filter
has been pushed down. I'
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3520
Hi @fhueske, you just pointed out a question i had when tonycox
implementing the first version. Why we are preventing `FilterableTableSource`
from modifying the expressions? I think it's to
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106565688
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FilterableTableSource.scala
---
@@ -20,47 +20,40 @@ package
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106565668
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala
---
@@ -36,36
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106566042
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/TestFilterableTableSource.scala
---
@@ -0,0 +1,142
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106566606
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/util/RexProgramExtractorTest.scala
---
@@ -0,0 +1,347
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106566599
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/util/RexProgramExtractorTest.scala
---
@@ -0,0 +1,347
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106566787
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/util/RexProgramTestBase.scala
---
@@ -16,106 +16,96
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106568641
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/TableSourceTest.scala
---
@@ -0,0 +1,382 @@
+/*
+ * Licensed to the
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3520
Hi @fhueske, thanks for the review. I addressed all your comments and will
rebase to master to let travis check. Will merge this after build success.
---
If your project is set up for it, you can
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3520
Sure, so the result is there will be 2 commits to master repository?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106606071
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala
---
@@ -36,36
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3560#discussion_r106669352
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala
---
@@ -227,18 +227,23 @@ object
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3560#discussion_r106772134
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala
---
@@ -227,18 +227,23 @@ object
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3406
Seems good to merge now, merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3559#discussion_r106796945
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkPlannerImpl.scala
---
@@ -100,6 +101,7 @@ class FlinkPlannerImpl
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3553
Since `IF` is not sql standard, i think we could let java user just use
`case when`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108318278
--- Diff: flink-core/src/test/java/org/apache/flink/types/RowTest.java ---
@@ -21,6 +21,7 @@
import org.junit.Test;
import static
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108318419
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/TableFunction.scala
---
@@ -86,12 +90,79 @@ abstract class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108318532
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/TableFunction.scala
---
@@ -131,8 +202,10 @@ abstract class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108319900
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala
---
@@ -27,52 +27,73 @@ import
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108320419
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala
---
@@ -27,52 +27,73 @@ import
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108320480
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/TableFunction.scala
---
@@ -86,12 +90,79 @@ abstract class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108624761
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -358,4 +366,116
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108624874
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -358,4 +366,116
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108624961
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -358,4 +366,116
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108625307
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -358,4 +366,116
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108625377
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -358,4 +366,116
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108628113
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/DeferredTypeFlinkTableFunction.scala
---
@@ -0,0 +1,64
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r108628810
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -358,4 +366,116
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3623
Looks good to me, @twalthr @fhueske can you also take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/2934
[FLINK-5251] [Table] Decouple StreamTableSourceScan with TableSourceTable
This jira is actually a supplement of
https://github.com/apache/flink/pull/2921, since it's also make sens
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/2949
[FLINK-5257] [table] display optimized logical plan when explaining table
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KurtYoung/flink
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2810
Hi @tonycox , i want to appologize first for opening another "project
pushdown" issue when this one is still in active. We actually come up with some
whole new idea and designs comp
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2810
Hi @fhueske, I think this is a fair enough approach, thanks for your
effort. We will change our pr ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2949#discussion_r91209202
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/BatchTableEnvironment.scala
---
@@ -275,17 +278,27 @@ abstract class
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2926
Cool, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/2961
[FLINK-5266] [table] eagerly project unused fields when selecting
aggregation fields
This PR is based on #2926 , only the second commit is related.
I add a "plan" test directo
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2961#discussion_r91641034
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -881,24 +883,21 @@ class GroupWindowedTable
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2961
rebased to latest master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2961#discussion_r91729382
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -881,24 +883,21 @@ class GroupWindowedTable
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2961#discussion_r91885381
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -881,24 +883,21 @@ class GroupWindowedTable
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/2989
[FLINK-5314] [table] add tpch functionality test
All the cases not marked with "@Ignore" are supported by now. In the
future, if more queries are supported and we should open the cor
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2989
Seems like it's not allowed to include tpch queries in open source project,
closing this now.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user KurtYoung closed the pull request at:
https://github.com/apache/flink/pull/2989
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2961
Hi @fhueske , i have added the case of selecting from GroupWindowedTable.
And have leave some test cases for EventTimeWindow in batch mode, since it
supports using arbitrary field as the time
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3026
hi @chermenin , can you try to rebase this first, seems consists lots of
conflicts now. I will try to review this after you rebase it.
---
If your project is set up for it, you can reply to this
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2976
hi @chermenin , can you try to rebase this first, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/3689
[FLINK-5435] [table] Remove FlinkAggregateJoinTransposeRule and Flinkâ¦
â¦RelDecorrelator after calcite updated to 1.12
You can merge this pull request into a Git repository by running
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/3695
[FLINK-5545] [table] Remove FlinkAggregateExpandDistinctAggregatesRulâ¦
â¦e after bumping Calcite to v1.12.
You can merge this pull request into a Git repository by running:
$ git pull
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111856357
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
---
@@ -228,15 +229,24 @@ abstract class
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111857715
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/rel/logical/FlinkLogicalJoin.scala
---
@@ -0,0 +1,130
1 - 100 of 256 matches
Mail list logo
