Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2388#discussion_r76920351
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotID.java
---
@@ -75,9 +75,15 @@ public int hashCode() {
@Override
public String toString() {
- return "SlotID{" +
- "resourceId=" + resourceId +
- ", slotId=" + slotId +
- '}';
+ return resourceId + "_" + slotId;
+ }
+
+ /**
+ * Generate a random slot id.
+ *
+ * @return A random slot id.
+ */
+ public static SlotID generate() {
+ return new SlotID(ResourceID.generate(), 0);
--- End diff --
A SlotID is a identify of the slot which locates in some TaskManager. In
current flink's implementaion, we use integer to represent a slot within TM, i
think we should make this more explicit.
For generating a random slot, i think random a resource id which slot is
located is enough. (We may have some limitation of the integer else where, like
the integer can not be greater than the total slot number of the TM, so i
choose 0)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
