Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r111856357
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
---
@@ -228,15 +229,24 @@ abstract class BatchTableEnvironment(
}
// 3. optimize the logical Flink plan
- val optRuleSet = getOptRuleSet
- val flinkOutputProps =
relNode.getTraitSet.replace(DataSetConvention.INSTANCE).simplify()
- val optimizedPlan = if (optRuleSet.iterator().hasNext) {
- runVolcanoPlanner(optRuleSet, normalizedPlan, flinkOutputProps)
+ val logicalOptRuleSet = getLogicalOptRuleSet
+ val logicalOutputProps =
relNode.getTraitSet.replace(FlinkConventions.LOGICAL).simplify()
+ val logicalPlan = if (logicalOptRuleSet.iterator().hasNext) {
+ runVolcanoPlanner(logicalOptRuleSet, normalizedPlan,
logicalOutputProps)
--- End diff --
Yes, i will first test how HepPlanner works in some test and product
environments and then decide whether or how we change it to rule-based planner.
So this will be my follow up task.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
