Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3623#discussion_r108624761 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -358,4 +366,116 @@ object UserDefinedFunctionUtils { InstantiationUtil .deserializeObject[UserDefinedFunction](byteData, Thread.currentThread.getContextClassLoader) } + + /** + * Build a TableFunctionCall, a name and a sequence of params will determine a unique + * [[TableFunctionCall]] + * + * @param name function name + * @param implicitResultType If no result type returned, it will use this type. + * @param params The input expressions + * @return A unique [[TableFunctionCall]] + */ + private[table] def buildTableFunctionCall( + name: String, + tableFunction: TableFunction[_], + implicitResultType: TypeInformation[_], + params: Expression*): TableFunctionCall = { + val arguments = expressionsToArguments(params: _*) + val userDefinedResultType = tableFunction.getResultType(arguments) + val resultType = { + if (userDefinedResultType != null) userDefinedResultType + else implicitResultType + } + TableFunctionCall(name, tableFunction, params, resultType) + } + + /** + * Transform the expressions or rex nodes to Objects + * Only literal expressions will be passed, nulls for non-literal ones + * + * @param params actual parameters of the function + * @return A java List of the Objects + */ + private[table] def expressionsToArguments(params: Expression*): java.util.List[AnyRef] = { --- End diff -- rename to transformLiteralExpresssions to better fits the purpose?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---