Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-04 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1510727272 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java: ## @@ -1071,6 +1077,110 @@ protected SingleOutputStreamOperator ag

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-04 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1510728074 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sort/AbstractSortPartitionOperator.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-04 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1510732371 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sort/AbstractSortPartitionOperator.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-04 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1510732710 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sort/AbstractSortPartitionOperator.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-04 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1510733360 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sort/AbstractSortPartitionOperator.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-04 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1510733720 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sort/AbstractSortPartitionOperator.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-04 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1510734111 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sort/NonKeyedSortPartitionOperator.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-04 Thread via GitHub
WencongLiu commented on PR #24398: URL: https://github.com/apache/flink/pull/24398#issuecomment-1975951178 > Thanks @WencongLiu for bring this up. This is a valuable feature! > > I I've only reviewed two of the commits so far and will look at the rest later. Thanks for the care

[PR] [FLINK-33263][bugfix][table-planner] Remove redundant transformation verification logic. [flink]

2024-03-04 Thread via GitHub
BIOINSu opened a new pull request, #24431: URL: https://github.com/apache/flink/pull/24431 ## What is the purpose of the change This pull request removes redundant transformation verification logic and use `ExplainDetail.JSON_EXECUTION_PLAN` toverify the parallelism instea

Re: [PR] [FLINK-33263][bugfix][table-planner] Remove redundant transformation verification logic. [flink]

2024-03-04 Thread via GitHub
flinkbot commented on PR #24431: URL: https://github.com/apache/flink/pull/24431#issuecomment-1975961845 ## CI report: * 127a4cc3bdd4818a23e546646c4750605c8d38de UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.18][FLINK-34517][table]fix environment configs ignored when calling procedure operation [flink]

2024-03-04 Thread via GitHub
luoyuxia merged PR #24419: URL: https://github.com/apache/flink/pull/24419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Commented] (FLINK-34517) environment configs ignored when calling procedure operation

2024-03-04 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823069#comment-17823069 ] luoyuxia commented on FLINK-34517: -- 1.18: 620c5a7aeba448d247107ad44a6ba6f1e759052e mas

[jira] [Comment Edited] (FLINK-34517) environment configs ignored when calling procedure operation

2024-03-04 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823069#comment-17823069 ] luoyuxia edited comment on FLINK-34517 at 3/4/24 8:20 AM: -- 1.18

Re: [PR] feat: autoscaling decision parallelism improvement [FLINK-34563] [flink-kubernetes-operator]

2024-03-04 Thread via GitHub
mxm commented on code in PR #787: URL: https://github.com/apache/flink-kubernetes-operator/pull/787#discussion_r1509934269 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -129,6 +131,11 @@ public boolean scaleResource(

Re: [PR] [Draft][bugfix] Move the deserialization of shuffleDescriptor to a separate … [flink]

2024-03-04 Thread via GitHub
zhuzhurk commented on PR #24115: URL: https://github.com/apache/flink/pull/24115#issuecomment-1976014749 Hi @caodizhou , is there any progress? Should we re-enable the excluded tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [hotfix] Improve FlinkDeployment spec overview doc [flink-kubernetes-operator]

2024-03-04 Thread via GitHub
mxm commented on code in PR #788: URL: https://github.com/apache/flink-kubernetes-operator/pull/788#discussion_r1510789812 ## docs/content/docs/custom-resource/overview.md: ## @@ -85,7 +85,7 @@ The spec contains all the information the operator need to deploy and manage you

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-04 Thread via GitHub
Zakelly commented on code in PR #24418: URL: https://github.com/apache/flink/pull/24418#discussion_r1510799597 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/WithinCheckpointFileMergingSnapshotManager.java: ## @@ -41,12 +41,13 @@ public class With

[jira] [Commented] (FLINK-34400) Kafka sources with watermark alignment sporadically stop consuming

2024-03-04 Thread Alexis Sarda-Espinosa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823102#comment-17823102 ] Alexis Sarda-Espinosa commented on FLINK-34400: --- Hi [~fanrui], sorry for t

[jira] [Comment Edited] (FLINK-34400) Kafka sources with watermark alignment sporadically stop consuming

2024-03-04 Thread Alexis Sarda-Espinosa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823102#comment-17823102 ] Alexis Sarda-Espinosa edited comment on FLINK-34400 at 3/4/24 9:32 AM: ---

Re: [PR] [FLINK-34429] [flink-kubernetes] Adding K8S Annotations to Internal Service [flink]

2024-03-04 Thread via GitHub
dannycranmer commented on PR #24348: URL: https://github.com/apache/flink/pull/24348#issuecomment-1976154596 @barakbn please rebase and squash commits and I will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-34352][doc] Improve the documentation of allowNonRestoredState [flink]

2024-03-04 Thread via GitHub
masteryhx commented on PR #24396: URL: https://github.com/apache/flink/pull/24396#issuecomment-1976157579 > Hi @masteryhx , I suggest minor adjustments in Chinese. PTAL, thanks! Thanks for the suggestions, I have addressed and rebased commits. PTAL again. -- This is an automated mes

[PR] [FLINK-25544][streaming][JUnit5 Migration] The util,graph,experimental,environment package of module flink-stream-java [flink]

2024-03-04 Thread via GitHub
Jiabao-Sun opened a new pull request, #24432: URL: https://github.com/apache/flink/pull/24432 ## What is the purpose of the change [FLINK-25544][streaming][JUnit5 Migration] The util,graph,experimental,environment package of module flink-stream-java ## Brief change log

Re: [PR] [FLINK-25544][streaming][JUnit5 Migration] The util,graph,experimental,environment package of module flink-stream-java [flink]

2024-03-04 Thread via GitHub
flinkbot commented on PR #24432: URL: https://github.com/apache/flink/pull/24432#issuecomment-1976310900 ## CI report: * 267e6e0287c75dd99ddd81950d5c6fa285ed1e0a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-03-04 Thread via GitHub
dawidwys commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1510982540 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -1516,4 +1517,141 @@ private Stream arr

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-03-04 Thread via GitHub
dawidwys commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1510988286 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-03-04 Thread via GitHub
dawidwys commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1510988286 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-03-04 Thread via GitHub
dawidwys commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1510994873 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/EqualityAndHashcodeProvider.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apac

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-03-04 Thread via GitHub
dawidwys commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1510994873 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/EqualityAndHashcodeProvider.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apac

Re: [PR] [FLINK-34334][state] Add sub-task level RocksDB file count metrics [flink]

2024-03-04 Thread via GitHub
masteryhx commented on code in PR #24322: URL: https://github.com/apache/flink/pull/24322#discussion_r1511001449 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricMonitor.java: ## @@ -114,7 +114,14 @@ pri

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-03-04 Thread via GitHub
dawidwys commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1511000467 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/ObjectContainer.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-31530] support oracle catalog [flink-connector-jdbc]

2024-03-04 Thread via GitHub
whhe commented on PR #43: URL: https://github.com/apache/flink-connector-jdbc/pull/43#issuecomment-1976373645 Any plan for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-34572) JDBC: Support OceanBase catalog

2024-03-04 Thread He Wang (Jira)
He Wang created FLINK-34572: --- Summary: JDBC: Support OceanBase catalog Key: FLINK-34572 URL: https://issues.apache.org/jira/browse/FLINK-34572 Project: Flink Issue Type: New Feature Compo

Re: [PR] [FLINK-12590][docs] Replace HTTP links [flink]

2024-03-04 Thread via GitHub
zentol closed pull request #8519: [FLINK-12590][docs] Replace HTTP links URL: https://github.com/apache/flink/pull/8519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [FLINK-7958][metrics] Reporters provide default delimiter [flink]

2024-03-04 Thread via GitHub
zentol closed pull request #9867: [FLINK-7958][metrics] Reporters provide default delimiter URL: https://github.com/apache/flink/pull/9867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments [flink]

2024-03-04 Thread via GitHub
zentol closed pull request #13190: [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments URL: https://github.com/apache/flink/pull/13190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-27467][cli][tests] Drop CliFrontendTestBase [flink]

2024-03-04 Thread via GitHub
zentol closed pull request #19620: [FLINK-27467][cli][tests] Drop CliFrontendTestBase URL: https://github.com/apache/flink/pull/19620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [FLINK-29399][tests] Wait until job was cancelled [flink]

2024-03-04 Thread via GitHub
zentol closed pull request #20952: [FLINK-29399][tests] Wait until job was cancelled URL: https://github.com/apache/flink/pull/20952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Updated] (FLINK-29399) TableITCase is unstable

2024-03-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29399: --- Labels: pull-request-available (was: ) > TableITCase is unstable > ---

Re: [PR] [FLINK-29866][build] Split flink-dist [flink]

2024-03-04 Thread via GitHub
zentol closed pull request #21228: [FLINK-29866][build] Split flink-dist URL: https://github.com/apache/flink/pull/21228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [hotfix][ci] Sync CI setup & Reuse workflow [flink-connector-aws]

2024-03-04 Thread via GitHub
zentol closed pull request #38: [hotfix][ci] Sync CI setup & Reuse workflow URL: https://github.com/apache/flink-connector-aws/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [FLINK-32179][tests] Harden FileUtils#findFlinkDist against custom repo names [flink]

2024-03-04 Thread via GitHub
zentol closed pull request #22653: [FLINK-32179][tests] Harden FileUtils#findFlinkDist against custom repo names URL: https://github.com/apache/flink/pull/22653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Updated] (FLINK-32179) Handle more repo names for automatic dist discovery

2024-03-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32179: --- Labels: pull-request-available (was: ) > Handle more repo names for automatic dist discover

Re: [PR] FLINK-30455 [core] Excluding java.lang.String and primitive types from closure cleaning [flink]

2024-03-04 Thread via GitHub
zentol closed pull request #21532: FLINK-30455 [core] Excluding java.lang.String and primitive types from closure cleaning URL: https://github.com/apache/flink/pull/21532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [FLINK-11913] Shading cassandra driver dependencies in cassandra conector [flink]

2024-03-04 Thread via GitHub
flinkbot commented on PR #7980: URL: https://github.com/apache/flink/pull/7980#issuecomment-1976427637 ## CI report: * a523bdc12f9f0f00c60d1940927454bd497859a5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re

Re: [PR] [FLINK-12520] Support to provide fully-qualified domain host name in TaskManagerMetricGroup [flink]

2024-03-04 Thread via GitHub
flinkbot commented on PR #8545: URL: https://github.com/apache/flink/pull/8545#issuecomment-1976428068 ## CI report: * dcf2c5bd6d1c3ebe4b349c2b479a66f8c225f7ce UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re

Re: [PR] [FLINK-34483][docs] Improve the documentation of 'state.checkpoints.dir' and 'state.checkpoint-storage' [flink]

2024-03-04 Thread via GitHub
masteryhx commented on code in PR #24401: URL: https://github.com/apache/flink/pull/24401#discussion_r1511051492 ## flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java: ## @@ -76,6 +76,17 @@ public class CheckpointingOptions { * CheckpointStor

Re: [PR] [FLINK-32075][FLIP-306][Checkpoint] Delete merged files on checkpoint abort or subsumption [flink]

2024-03-04 Thread via GitHub
masteryhx closed pull request #24181: [FLINK-32075][FLIP-306][Checkpoint] Delete merged files on checkpoint abort or subsumption URL: https://github.com/apache/flink/pull/24181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Resolved] (FLINK-32075) Delete merged files on checkpoint abort or subsumption

2024-03-04 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-32075. -- Fix Version/s: 1.20.0 (was: 1.19.0) Resolution: Fixed merged cd9

[jira] [Commented] (FLINK-34536) Support reading long value as Timestamp column in JSON format

2024-03-04 Thread yisha zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823143#comment-17823143 ] yisha zhou commented on FLINK-34536: [~libenchao] Thanks for your insight, it helps

Re: [PR] [FLINK-33557] Externalize Cassandra Python connector code [flink-connector-cassandra]

2024-03-04 Thread via GitHub
ferenc-csaky commented on PR #26: URL: https://github.com/apache/flink-connector-cassandra/pull/26#issuecomment-1976453914 @echauchot Sorry to ping you out of the blue, I saw that you were an active contributor to the Cassandra connector. If you have some time, would you mind reviewing thi

Re: [PR] [FLINK-33210] Introduce lineage graph relevant interfaces [flink]

2024-03-04 Thread via GitHub
FangYongs commented on PR #23626: URL: https://github.com/apache/flink/pull/23626#issuecomment-1976455987 Thanks @JingGe , please help to review this PR again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33210] Introduce lineage graph relevant interfaces [flink]

2024-03-04 Thread via GitHub
FangYongs commented on PR #23626: URL: https://github.com/apache/flink/pull/23626#issuecomment-1976458731 @HuangZhenQiu @mobuchowski I have add dataset and facet interfaces in lineage vertex, please help to review this PR cc @X-czh -- This is an automated message from the Apache Git Serv

Re: [PR] [hotfix] Improve FlinkDeployment spec overview doc [flink-kubernetes-operator]

2024-03-04 Thread via GitHub
caicancai commented on code in PR #788: URL: https://github.com/apache/flink-kubernetes-operator/pull/788#discussion_r1511081946 ## docs/content/docs/custom-resource/overview.md: ## @@ -85,7 +85,7 @@ The spec contains all the information the operator need to deploy and manage

Re: [PR] [FLINK-33210] Introduce lineage graph relevant interfaces [flink]

2024-03-04 Thread via GitHub
X-czh commented on code in PR #23626: URL: https://github.com/apache/flink/pull/23626#discussion_r1511095895 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/lineage/DefaultLineageGraphTest.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Fo

[jira] [Commented] (FLINK-33992) Add option to fetch the jar from private repository in FlinkSessionJob

2024-03-04 Thread Ahmed Soliman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823159#comment-17823159 ] Ahmed Soliman commented on FLINK-33992: --- Hello [~skala]  I have some thoughts her

Re: [PR] [FLINK-34352][doc] Improve the documentation of allowNonRestoredState [flink]

2024-03-04 Thread via GitHub
masteryhx closed pull request #24396: [FLINK-34352][doc] Improve the documentation of allowNonRestoredState URL: https://github.com/apache/flink/pull/24396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-33210] Introduce lineage graph relevant interfaces [flink]

2024-03-04 Thread via GitHub
X-czh commented on PR #23626: URL: https://github.com/apache/flink/pull/23626#issuecomment-1976492211 @FangYongs Thanks for the PR. The changes LGTM except for a nit on the UT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Resolved] (FLINK-34352) Improve the documentation of allowNonRestoredState

2024-03-04 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-34352. -- Fix Version/s: 1.20.0 Resolution: Fixed merged e168cd4d into master. > Improve the doc

[jira] [Commented] (FLINK-34566) Flink Kubernetes Operator reconciliation parallelism setting not work

2024-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823163#comment-17823163 ] Gyula Fora commented on FLINK-34566: Looking at this in detail I think it should wor

Re: [PR] [FLINK-34268] Add a test to verify if restore test exists for ExecNode [flink]

2024-03-04 Thread via GitHub
dawidwys commented on code in PR #24219: URL: https://github.com/apache/flink/pull/24219#discussion_r1511101924 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestCompleteness.java: ## @@ -0,0 +1,129 @@ +/* + * Li

[jira] [Commented] (FLINK-34566) Flink Kubernetes Operator reconciliation parallelism setting not work

2024-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823164#comment-17823164 ] Gyula Fora commented on FLINK-34566: Even if the core pool size is 10, the maxpoolsi

[jira] (FLINK-34566) Flink Kubernetes Operator reconciliation parallelism setting not work

2024-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34566 ] Gyula Fora deleted comment on FLINK-34566: was (Author: gyfora): {noformat} A ThreadPoolExecutor will automatically adjust the pool size (see getPoolSize) according to the bounds set by core

[jira] [Commented] (FLINK-34566) Flink Kubernetes Operator reconciliation parallelism setting not work

2024-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823166#comment-17823166 ] Gyula Fora commented on FLINK-34566: >From the java docs: "A ThreadPoolExecutor wil

[jira] [Commented] (FLINK-34566) Flink Kubernetes Operator reconciliation parallelism setting not work

2024-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823165#comment-17823165 ] Gyula Fora commented on FLINK-34566: {noformat} A ThreadPoolExecutor will automatica

[jira] [Commented] (FLINK-33992) Add option to fetch the jar from private repository in FlinkSessionJob

2024-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823168#comment-17823168 ] Gyula Fora commented on FLINK-33992: For session job submissions the jar generally h

[jira] [Commented] (FLINK-33992) Add option to fetch the jar from private repository in FlinkSessionJob

2024-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823169#comment-17823169 ] Gyula Fora commented on FLINK-33992: It would be great if Flink itself would have a

[jira] [Created] (FLINK-34573) the task is stuck on the high presure

2024-03-04 Thread LSZ (Jira)
LSZ created FLINK-34573: --- Summary: the task is stuck on the high presure Key: FLINK-34573 URL: https://issues.apache.org/jira/browse/FLINK-34573 Project: Flink Issue Type: Bug Components: Run

Re: [PR] [hotfix] Improve FlinkDeployment spec overview doc [flink-kubernetes-operator]

2024-03-04 Thread via GitHub
mxm merged PR #788: URL: https://github.com/apache/flink-kubernetes-operator/pull/788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (FLINK-32497) IF FUNCTION is FALSE and the false_value parameter is a function, then an exception will be thrown

2024-03-04 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823172#comment-17823172 ] david radley commented on FLINK-32497: -- I notice this is a critical issue. But from

[jira] [Updated] (FLINK-34573) the task is stuck on the high presure

2024-03-04 Thread LSZ (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LSZ updated FLINK-34573: Attachment: rate.PNG > the task is stuck on the high presure > - > >

[jira] [Updated] (FLINK-34573) the task is stuck on the high presure

2024-03-04 Thread LSZ (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LSZ updated FLINK-34573: Description: we havae a flink job , jst one taskmanger; when use high presure as soure data,it will be stuck. som

[jira] [Created] (FLINK-34574) Add CPU and memory size autoscaler quota

2024-03-04 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-34574: - Summary: Add CPU and memory size autoscaler quota Key: FLINK-34574 URL: https://issues.apache.org/jira/browse/FLINK-34574 Project: Flink Issue Type: New Fe

[jira] [Assigned] (FLINK-34574) Add CPU and memory size autoscaler quota

2024-03-04 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi reassigned FLINK-34574: - Assignee: Gabor Somogyi > Add CPU and memory size autoscaler quota > --

Re: [PR] [FLINK-33263][bugfix][table-planner] Remove redundant transformation verification logic. [flink]

2024-03-04 Thread via GitHub
libenchao merged PR #24431: URL: https://github.com/apache/flink/pull/24431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Commented] (FLINK-20392) Migrating bash e2e tests to Java/Docker

2024-03-04 Thread Lorenzo Affetti (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823188#comment-17823188 ] Lorenzo Affetti commented on FLINK-20392: - [~mapohl] [~jark]  In order to bette

[jira] [Commented] (FLINK-20392) Migrating bash e2e tests to Java/Docker

2024-03-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823193#comment-17823193 ] Matthias Pohl commented on FLINK-20392: --- The goal is to move away from bash-based

[PR] Add CPU and memory size autoscaler quota [flink-kubernetes-operator]

2024-03-04 Thread via GitHub
gaborgsomogyi opened a new pull request, #789: URL: https://github.com/apache/flink-kubernetes-operator/pull/789 ## What is the purpose of the change Flink can report slot sharing group information in the vertex information. This can be used to fine tune the autoscaler algorithm to de

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-03-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823201#comment-17823201 ] Matthias Pohl commented on FLINK-29114: --- * https://github.com/apache/flink/action

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-03-04 Thread via GitHub
ferenc-csaky commented on code in PR #22789: URL: https://github.com/apache/flink/pull/22789#discussion_r1511222835 ## flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopFreeTests.java: ## Review Comment: Use AssertJ's `assertThatThrownBy

Re: [PR] [FLINK-34419][docker] Add tests for JDK 17 & 21 [flink-docker]

2024-03-04 Thread via GitHub
XComp commented on code in PR #182: URL: https://github.com/apache/flink-docker/pull/182#discussion_r1511250389 ## .github/workflows/ci.yml: ## @@ -17,14 +17,22 @@ name: "CI" on: [push, pull_request] +env: + TAR_URL: "https://s3.amazonaws.com/flink-nightly/flink-1.20-SNAP

Re: [PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

2024-03-04 Thread via GitHub
ferenc-csaky commented on PR #42: URL: https://github.com/apache/flink-connector-hbase/pull/42#issuecomment-1976709968 @Tan-JiaLiang if you have some time can you PTAL? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-33557] Externalize Cassandra Python connector code [flink-connector-cassandra]

2024-03-04 Thread via GitHub
echauchot commented on PR #26: URL: https://github.com/apache/flink-connector-cassandra/pull/26#issuecomment-1976742586 > @echauchot Sorry to ping you out of the blue, I saw that you were an active contributor to the Cassandra connector. If you have some time, would you mind reviewing this

Re: [PR] [FLINK-34152] Add an option to scale memory when downscaling [flink-kubernetes-operator]

2024-03-04 Thread via GitHub
gyfora commented on code in PR #786: URL: https://github.com/apache/flink-kubernetes-operator/pull/786#discussion_r1511285884 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/tuning/MemoryTuning.java: ## @@ -148,8 +149,11 @@ public static ConfigChanges tuneTaskMana

Re: [PR] Add CPU and memory size autoscaler quota [flink-kubernetes-operator]

2024-03-04 Thread via GitHub
mxm commented on code in PR #789: URL: https://github.com/apache/flink-kubernetes-operator/pull/789#discussion_r1511294060 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/topology/JobTopology.java: ## @@ -97,10 +109,6 @@ public boolean isSource(JobVertexID jobVert

[jira] [Closed] (FLINK-34566) Flink Kubernetes Operator reconciliation parallelism setting not work

2024-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-34566. -- Resolution: Not A Problem I am closing this ticket for now, if you feel that this resolution is incorr

Re: [PR] Add CPU and memory size autoscaler quota [flink-kubernetes-operator]

2024-03-04 Thread via GitHub
mxm commented on code in PR #789: URL: https://github.com/apache/flink-kubernetes-operator/pull/789#discussion_r1511292849 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/EvaluatedMetrics.java: ## @@ -30,6 +31,7 @@ @NoArgsConstructor @AllArgsConstructor

Re: [PR] [FLINK-34152] Add an option to scale memory when downscaling [flink-kubernetes-operator]

2024-03-04 Thread via GitHub
mxm commented on code in PR #786: URL: https://github.com/apache/flink-kubernetes-operator/pull/786#discussion_r1511334711 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/tuning/MemoryTuning.java: ## @@ -148,8 +149,11 @@ public static ConfigChanges tuneTaskManager

[jira] [Created] (FLINK-34575) Vulnerabilities in commons-compress 1.24.0; upgrade to 1.26.0 needed.

2024-03-04 Thread Adrian Vasiliu (Jira)
Adrian Vasiliu created FLINK-34575: -- Summary: Vulnerabilities in commons-compress 1.24.0; upgrade to 1.26.0 needed. Key: FLINK-34575 URL: https://issues.apache.org/jira/browse/FLINK-34575 Project: Fl

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

2024-03-04 Thread via GitHub
LadyForest commented on PR #24390: URL: https://github.com/apache/flink/pull/24390#issuecomment-1976845985 Hi @XComp, would you mind taking a look when you're available? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-20392) Migrating bash e2e tests to Java/Docker

2024-03-04 Thread Lorenzo Affetti (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823242#comment-17823242 ] Lorenzo Affetti commented on FLINK-20392: - {quote}I'm not able to follow what yo

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-03-04 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1511439120 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

2024-03-04 Thread via GitHub
XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1511414346 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/utils/PathUtils.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-03-04 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1511453416 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/EqualityAndHashcodeProvider.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-03-04 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1511453416 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/EqualityAndHashcodeProvider.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the A

[jira] [Assigned] (FLINK-34531) Build and stage Java and Python artifacts

2024-03-04 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-34531: --- Assignee: lincoln lee > Build and stage Java and Python artifacts > ---

[jira] [Assigned] (FLINK-34532) Stage source and binary releases on dist.apache.org

2024-03-04 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-34532: --- Assignee: lincoln lee > Stage source and binary releases on dist.apache.org > -

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-03-04 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1511584785 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -1516,4 +1517,141 @@ private Stream

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-03-04 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1511610616 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/ObjectContainer.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-03-04 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1511610976 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/EqualityAndHashcodeProvider.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-31663][table] Add-ARRAY_EXCEPT-function. [flink]

2024-03-04 Thread via GitHub
hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1511611341 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/ObjectContainer.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Softwa

  1   2   >