Zakelly commented on code in PR #24418:
URL: https://github.com/apache/flink/pull/24418#discussion_r1510799597
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/WithinCheckpointFileMergingSnapshotManager.java:
##########
@@ -41,12 +41,13 @@ public class WithinCheckpointFileMergingSnapshotManager
extends FileMergingSnaps
* this map consist of checkpoint id, subtask key, and checkpoint scope,
which collectively
* determine the physical file to be reused.
*/
- private final Map<Tuple3<Long, SubtaskKey, CheckpointedStateScope>,
PhysicalFile>
+ private final Map<Tuple3<Long, SubtaskKey, CheckpointedStateScope>,
PhysicalFilePool>
Review Comment:
I'm a little bit lost here. Does a pool should contain and manage a set of
physical files that may resue multiple times? Considering the files may share
across SubtaskKeys (In exclusive scope), I suggest we leave ` Map<Long,
PhysicalFilePool>` here, and let PhysicalFilePool handle the file sharing
between subtasks in Exclusive scope and exclusive between Shared Scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
