gyfora commented on code in PR #786:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/786#discussion_r1511285884
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/tuning/MemoryTuning.java:
##########
@@ -148,8 +149,11 @@ public static ConfigChanges tuneTaskManagerHeapMemory(
final long flinkMemoryDiffBytes = heapDiffBytes + managedDiffBytes +
networkDiffBytes;
// Update total memory according to memory diffs
- final MemorySize totalMemory =
+ MemorySize totalMemory =
new MemorySize(maxMemoryBySpec.getBytes() -
memBudget.getRemaining());
+ totalMemory =
+ MemoryScaling.applyMemoryScaling(
+ totalMemory, maxMemoryBySpec, context,
scalingSummaries, evaluatedMetrics);
Review Comment:
The memory scaling config specifies that both managed and heap memory is
scaled based on the TM scaling factor. But it seems like we only scale the heap
as the managed memory size is computed before this.
Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
