mxm commented on code in PR #786:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/786#discussion_r1511334711
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/tuning/MemoryTuning.java:
##########
@@ -148,8 +149,11 @@ public static ConfigChanges tuneTaskManagerHeapMemory(
final long flinkMemoryDiffBytes = heapDiffBytes + managedDiffBytes +
networkDiffBytes;
// Update total memory according to memory diffs
- final MemorySize totalMemory =
+ MemorySize totalMemory =
new MemorySize(maxMemoryBySpec.getBytes() -
memBudget.getRemaining());
+ totalMemory =
+ MemoryScaling.applyMemoryScaling(
+ totalMemory, maxMemoryBySpec, context,
scalingSummaries, evaluatedMetrics);
Review Comment:
Good catch, the scaling is heap only. Managed memory is never adjusted,
unless none is used at all (then it is set to zero) or the option to maximize
managed memory is turned on. I've adjusted the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
