[GitHub] flink issue #2231: [FLINK-4035] Bump Kafka producer in Kafka sink to Kafka 0...

2016-07-22 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2231 Hi @radekg , There was a recent change to the connector code to how the Kafka metrics are reported, so right now the PR has conflicts and can't be built. Would you like to rebase this PR on the

[jira] [Commented] (FLINK-4035) Bump Kafka producer in Kafka sink to Kafka 0.10.0.0

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389060#comment-15389060 ] ASF GitHub Bot commented on FLINK-4035: --- Github user tzulitai commented on the issue

[jira] [Commented] (FLINK-3397) Failed streaming jobs should fall back to the most recent checkpoint/savepoint

2016-07-22 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389062#comment-15389062 ] ramkrishna.s.vasudevan commented on FLINK-3397: --- [~uce] A gentle ping !!! :)

[GitHub] flink issue #2279: [FLINK-4229] Only start JMX server when port is specified

2016-07-22 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2279 @StephanEwen did you merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[jira] [Commented] (FLINK-4229) Do not start Metrics Reporter by default

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389181#comment-15389181 ] ASF GitHub Bot commented on FLINK-4229: --- Github user aljoscha commented on the issue

[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-22 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/1989 @fpompermaier I think you can close this PR. I will take your commit, put the Scala conversion on top of it and open a new PR. --- If your project is set up for it, you can reply to this email and h

[jira] [Commented] (FLINK-3901) Create a RowCsvInputFormat to use as default CSV IF in Table API

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389214#comment-15389214 ] ASF GitHub Bot commented on FLINK-3901: --- Github user twalthr commented on the issue:

[jira] [Created] (FLINK-4253) Rename "recovery.mode" config key to "high-availability"

2016-07-22 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-4253: -- Summary: Rename "recovery.mode" config key to "high-availability" Key: FLINK-4253 URL: https://issues.apache.org/jira/browse/FLINK-4253 Project: Flink Issue Type

[jira] [Created] (FLINK-4254) Add file system based high-availability mode

2016-07-22 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-4254: -- Summary: Add file system based high-availability mode Key: FLINK-4254 URL: https://issues.apache.org/jira/browse/FLINK-4254 Project: Flink Issue Type: New Featur

[GitHub] flink issue #2279: [FLINK-4229] Only start JMX server when port is specified

2016-07-22 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2279 Was waiting for travis after the rebase, but got the green light now. Will push it to master... --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[jira] [Commented] (FLINK-4229) Do not start Metrics Reporter by default

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389232#comment-15389232 ] ASF GitHub Bot commented on FLINK-4229: --- Github user StephanEwen commented on the is

[GitHub] flink pull request #2279: [FLINK-4229] Only start JMX server when port is sp...

2016-07-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4229) Do not start Metrics Reporter by default

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389233#comment-15389233 ] ASF GitHub Bot commented on FLINK-4229: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-4229) Do not start Metrics Reporter by default

2016-07-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-4229. --- > Do not start Metrics Reporter by default > > >

[GitHub] flink pull request #2283: [FLINK-3901] [table] Create a RowCsvInputFormat fo...

2016-07-22 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/2283 [FLINK-3901] [table] Create a RowCsvInputFormat for Table API Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.

[jira] [Commented] (FLINK-3901) Create a RowCsvInputFormat to use as default CSV IF in Table API

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389265#comment-15389265 ] ASF GitHub Bot commented on FLINK-3901: --- GitHub user twalthr opened a pull request:

[jira] [Commented] (FLINK-4240) Cannot use expressions in Scala Table API's groupBy method

2016-07-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389269#comment-15389269 ] Till Rohrmann commented on FLINK-4240: -- Oh yes, you're right. Sorry stupid mistake. W

[jira] [Closed] (FLINK-4240) Cannot use expressions in Scala Table API's groupBy method

2016-07-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-4240. Resolution: Not A Problem > Cannot use expressions in Scala Table API's groupBy method > ---

[jira] [Closed] (FLINK-4249) CsvTableSource does not support reading SqlTimeTypeInfo types

2016-07-22 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-4249. --- Resolution: Duplicate > CsvTableSource does not support reading SqlTimeTypeInfo types > --

[jira] [Assigned] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-4246: --- Assignee: Aljoscha Krettek > Allow Specifying Multiple Metrics Reporters > --

[jira] [Commented] (FLINK-4249) CsvTableSource does not support reading SqlTimeTypeInfo types

2016-07-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389279#comment-15389279 ] Till Rohrmann commented on FLINK-4249: -- Sorry, I must have clicked twice the create i

[GitHub] flink pull request #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-22 Thread fpompermaier
Github user fpompermaier closed the pull request at: https://github.com/apache/flink/pull/1989 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (FLINK-4250) Cannot select other than first column from Table

2016-07-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389280#comment-15389280 ] Till Rohrmann commented on FLINK-4250: -- Ah ok that makes sense. And indeed when chang

[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-22 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/1989 Ok for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-3901) Create a RowCsvInputFormat to use as default CSV IF in Table API

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389282#comment-15389282 ] ASF GitHub Bot commented on FLINK-3901: --- Github user fpompermaier commented on the i

[jira] [Commented] (FLINK-3901) Create a RowCsvInputFormat to use as default CSV IF in Table API

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389281#comment-15389281 ] ASF GitHub Bot commented on FLINK-3901: --- Github user fpompermaier closed the pull re

[jira] [Commented] (FLINK-4252) Table program cannot be compiled

2016-07-22 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389284#comment-15389284 ] Timo Walther commented on FLINK-4252: - We had a similar issue with the old Table API.

[jira] [Comment Edited] (FLINK-4252) Table program cannot be compiled

2016-07-22 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389284#comment-15389284 ] Timo Walther edited comment on FLINK-4252 at 7/22/16 10:31 AM: -

[GitHub] flink issue #2271: [FLINK-4202] Add restarting time JM metric

2016-07-22 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2271 Good points with the documentation and the exposed metrics. I'll update the documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-4202) Add JM metric which shows the restart duration

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389285#comment-15389285 ] ASF GitHub Bot commented on FLINK-4202: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-4250) Cannot select other than first column from Table

2016-07-22 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389288#comment-15389288 ] Timo Walther commented on FLINK-4250: - We have to figure that out. We should also add

[GitHub] flink pull request #2284: [FLINK-4202] [metrics] Update restarting time metr...

2016-07-22 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2284 [FLINK-4202] [metrics] Update restarting time metric documentation Update the restarting time JM metric documentation. Please review @zentol. You can merge this pull request into

[jira] [Commented] (FLINK-4202) Add JM metric which shows the restart duration

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389300#comment-15389300 ] ASF GitHub Bot commented on FLINK-4202: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-4173) Replace maven-assembly-plugin by maven-shade-plugin in flink-metrics

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389308#comment-15389308 ] ASF GitHub Bot commented on FLINK-4173: --- Github user zentol commented on the issue:

[GitHub] flink issue #2216: [FLINK-4173] Use shade-plugin in flink-metrics

2016-07-22 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2216 I've made the following changes: * use "append" instead of "override" for the shade configuration * include the missing `org.acplt:oncrpc` dependency --- If your project is set up for it, you

[GitHub] flink issue #2284: [FLINK-4202] [metrics] Update restarting time metric docu...

2016-07-22 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2284 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (FLINK-4202) Add JM metric which shows the restart duration

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389314#comment-15389314 ] ASF GitHub Bot commented on FLINK-4202: --- Github user zentol commented on the issue:

[GitHub] flink pull request #2218: [FLINK-4161] Add Quickstart exclusion for flink-di...

2016-07-22 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/2218 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4161) Quickstarts can exclude more flink-dist dependencies

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389320#comment-15389320 ] ASF GitHub Bot commented on FLINK-4161: --- Github user zentol closed the pull request

[jira] [Commented] (FLINK-4252) Table program cannot be compiled

2016-07-22 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389341#comment-15389341 ] Jark Wu commented on FLINK-4252: Do we have the JIRA? Or just modify this JIRA to track i

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-22 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2226 I tried to see if we can move the entire set of metrics classes to the independent `flink-metrics-core` module. Here is how that would look like: https://github.com/StephanEwen/incubator-flink/tr

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389345#comment-15389345 ] ASF GitHub Bot commented on FLINK-4192: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-22 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 I had a chat with @tillrohrmann about moving all classes when i started working on this issue. We decided to not include implementations in the new module, to be able to use NetUtils and Preconditions

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389355#comment-15389355 ] ASF GitHub Bot commented on FLINK-4192: --- Github user zentol commented on the issue:

[GitHub] flink issue #2245: [hotfix] Fix Redis Sink to fail at opening if Redis is no...

2016-07-22 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2245 Done! Thanks @tillrohrmann --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #2245: [hotfix] Fix Redis Sink to fail at opening if Redi...

2016-07-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2245#discussion_r71869449 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java --- @@ -105,18 +

[GitHub] flink pull request #2245: [hotfix] Fix Redis Sink to fail at opening if Redi...

2016-07-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2245#discussion_r71869391 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java --- @@ -105,18 +

[GitHub] flink issue #2284: [FLINK-4202] [metrics] Update restarting time metric docu...

2016-07-22 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2284 Merging PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[jira] [Commented] (FLINK-4202) Add JM metric which shows the restart duration

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389385#comment-15389385 ] ASF GitHub Bot commented on FLINK-4202: --- Github user tillrohrmann commented on the i

[GitHub] flink pull request #2245: [hotfix] Fix Redis Sink to fail at opening if Redi...

2016-07-22 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2245#discussion_r71869640 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java --- @@ -105,18 +105,13 @

[jira] [Closed] (FLINK-4202) Add JM metric which shows the restart duration

2016-07-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-4202. Resolution: Fixed Fixed via b3fa459d4c9657e95fdc875d2566b57d48a0a027 > Add JM metric which shows th

[jira] [Commented] (FLINK-4202) Add JM metric which shows the restart duration

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389389#comment-15389389 ] ASF GitHub Bot commented on FLINK-4202: --- Github user asfgit closed the pull request

[GitHub] flink pull request #2284: [FLINK-4202] [metrics] Update restarting time metr...

2016-07-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2276: [FLINK-4201] [runtime] Forward suspend to checkpoi...

2016-07-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Closed] (FLINK-4201) Checkpoints for jobs in non-terminal state (e.g. suspended) get deleted

2016-07-22 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-4201. -- Resolution: Fixed Fix Version/s: 1.1.0 Fixed in 54f02ec (master). > Checkpoints for jobs in non-

[jira] [Commented] (FLINK-4201) Checkpoints for jobs in non-terminal state (e.g. suspended) get deleted

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389401#comment-15389401 ] ASF GitHub Bot commented on FLINK-4201: --- Github user asfgit closed the pull request

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-22 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2226 Think of this as part of the discussion with another guy in the community ;-) The split of metric classes between `flink-core` and `flink-metric-core` made it to me a bit complicated to

[GitHub] flink issue #2245: [hotfix] Fix Redis Sink to fail at opening if Redis is no...

2016-07-22 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2245 I think this is ok now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389406#comment-15389406 ] ASF GitHub Bot commented on FLINK-4192: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-4161) Quickstarts can exclude more flink-dist dependencies

2016-07-22 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389432#comment-15389432 ] Greg Hogan commented on FLINK-4161: --- What happened here? PR is closed but ticket remains

[jira] [Commented] (FLINK-4251) Add possiblity for the RMQ Streaming Sink to customize the queue

2016-07-22 Thread Kanstantsin Kamkou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389455#comment-15389455 ] Kanstantsin Kamkou commented on FLINK-4251: --- I'm not sure who created the first

[jira] [Commented] (FLINK-4251) Add possiblity for the RMQ Streaming Sink to customize the queue

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389459#comment-15389459 ] ASF GitHub Bot commented on FLINK-4251: --- Github user kkamkou commented on the issue:

[GitHub] flink issue #2281: RMQ Sink: Possibility to customize queue config [FLINK-42...

2016-07-22 Thread kkamkou
Github user kkamkou commented on the issue: https://github.com/apache/flink/pull/2281 Please, merge this ticket in 1.1.0, otherwise the rabbitmq sink functionality is unusable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[jira] [Commented] (FLINK-4161) Quickstarts can exclude more flink-dist dependencies

2016-07-22 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389463#comment-15389463 ] Chesnay Schepler commented on FLINK-4161: - i deleted the branch by accident. > Qu

[jira] [Assigned] (FLINK-3940) Add support for ORDER BY OFFSET FETCH

2016-07-22 Thread GaoLun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] GaoLun reassigned FLINK-3940: - Assignee: GaoLun > Add support for ORDER BY OFFSET FETCH > - > >

[GitHub] flink pull request #2281: RMQ Sink: Possibility to customize queue config [F...

2016-07-22 Thread kkamkou
Github user kkamkou commented on a diff in the pull request: https://github.com/apache/flink/pull/2281#discussion_r71876785 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -58,6 +58,15 @

[jira] [Commented] (FLINK-4251) Add possiblity for the RMQ Streaming Sink to customize the queue

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389475#comment-15389475 ] ASF GitHub Bot commented on FLINK-4251: --- Github user kkamkou commented on a diff in

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/2285 [FLINK-4246] Allow Specifying Multiple Metrics Reporters This also updates documentation and tests. Reporters can now be specified like this: metrics.reporters: foo,bar me

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389487#comment-15389487 ] ASF GitHub Bot commented on FLINK-4246: --- GitHub user aljoscha opened a pull request:

[GitHub] flink pull request #2286: [FLINK-4210][metrics] Move close()/isClosed() out ...

2016-07-22 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2286 [FLINK-4210][metrics] Move close()/isClosed() out of MetricGroup This PR moves the `close()` and `isClosed()` methods from the MetricGroup interface into the AbstractMetricGroup class. The r

[jira] [Commented] (FLINK-4210) Move close()/isClosed() out of MetricGroup interface

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389494#comment-15389494 ] ASF GitHub Bot commented on FLINK-4210: --- GitHub user zentol opened a pull request:

[GitHub] flink issue #2051: [FLINK-3779] Add support for queryable state

2016-07-22 Thread soumyasd
Github user soumyasd commented on the issue: https://github.com/apache/flink/pull/2051 Any idea which Flink version this feature is going live with ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[jira] [Commented] (FLINK-3779) Add support for queryable state

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389496#comment-15389496 ] ASF GitHub Bot commented on FLINK-3779: --- Github user soumyasd commented on the issue

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-22 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 Separating classes certainly makes navigation trickier, but should we sacrifice code-stability (Preconditions/NetUtils) for it? I believe a separation of interfaces and implementation is a good compro

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389484#comment-15389484 ] ASF GitHub Bot commented on FLINK-4192: --- Github user zentol commented on the issue:

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71879184 --- Diff: docs/apis/metrics.md --- @@ -227,14 +227,25 @@ or by assigning unique names to jobs and operators. ## Reporter -Metrics can be ex

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71879710 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -75,77 +78,92 @@ public MetricRegistry(Configuration config) {

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389508#comment-15389508 ] ASF GitHub Bot commented on FLINK-4246: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389513#comment-15389513 ] ASF GitHub Bot commented on FLINK-4246: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71879969 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -75,77 +78,92 @@ public MetricRegistry(Configuration config) {

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389503#comment-15389503 ] ASF GitHub Bot commented on FLINK-4246: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71880194 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -198,8 +220,13 @@ public void register(Metric metric, String metricName,

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389517#comment-15389517 ] ASF GitHub Bot commented on FLINK-4246: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71880255 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -263,6 +276,7 @@ private ReporterTask(Scheduled reporter) {

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389515#comment-15389515 ] ASF GitHub Bot commented on FLINK-4246: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389522#comment-15389522 ] ASF GitHub Bot commented on FLINK-4246: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389525#comment-15389525 ] ASF GitHub Bot commented on FLINK-4246: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71881023 --- Diff: docs/apis/metrics.md --- @@ -227,14 +227,25 @@ or by assigning unique names to jobs and operators. ## Reporter -Metrics can be ex

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389524#comment-15389524 ] ASF GitHub Bot commented on FLINK-4246: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71881022 --- Diff: docs/apis/metrics.md --- @@ -227,14 +227,25 @@ or by assigning unique names to jobs and operators. ## Reporter -Metrics can be ex

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71881920 --- Diff: docs/apis/metrics.md --- @@ -227,14 +227,25 @@ or by assigning unique names to jobs and operators. ## Reporter -Metrics can be ex

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71880869 --- Diff: docs/apis/metrics.md --- @@ -227,14 +227,25 @@ or by assigning unique names to jobs and operators. ## Reporter -Metrics can be ex

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389532#comment-15389532 ] ASF GitHub Bot commented on FLINK-4246: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71882304 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -651,14 +651,38 @@ //

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389536#comment-15389536 ] ASF GitHub Bot commented on FLINK-4246: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71882489 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -651,14 +651,38 @@ //

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389539#comment-15389539 ] ASF GitHub Bot commented on FLINK-4246: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71882781 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -75,77 +78,92 @@ public MetricRegistry(Configuration config) {

[jira] [Commented] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389543#comment-15389543 ] ASF GitHub Bot commented on FLINK-4246: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2285: [FLINK-4246] Allow Specifying Multiple Metrics Rep...

2016-07-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2285#discussion_r71883212 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/DelegatingConfigurationTest.java --- @@ -28,7 +28,7 @@ import java.util.Comparator;

  1   2   3   >