[
https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389484#comment-15389484
]
ASF GitHub Bot commented on FLINK-4192:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2226
Separating classes certainly makes navigation trickier, but should we
sacrifice code-stability (Preconditions/NetUtils) for it? I believe a
separation of interfaces and implementation is a good compromise; users can
write against the small flink-metrics-core jar, but we retain the ability to
use all utilities have.
If we want to move implementations into flink-metrics-core to make
navigation easier i would propose to move all classes there. Being able to use
JobID etc. directly is imo less of a benefit than the utilities.
> Move Metrics API to separate module
> -----------------------------------
>
> Key: FLINK-4192
> URL: https://issues.apache.org/jira/browse/FLINK-4192
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.1.0
>
>
> All metrics code currently resides in flink-core. If a user implements a
> reporter and wants a fat jar it will now have to include the entire
> flink-core module.
> Instead, we could move several interfaces into a separate module.
> These interfaces to move include:
> * Counter, Gauge, Histogram(Statistics)
> * MetricGroup
> * MetricReporter, Scheduled, AbstractReporter
> In addition a new MetricRegistry interface will be required as well as a
> replacement for the Configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
