[ 
https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389406#comment-15389406
 ] 

ASF GitHub Bot commented on FLINK-4192:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2226
  
    Think of this as part of the discussion with another guy in the community 
;-)
    
    The split of metric classes between `flink-core` and `flink-metric-core` 
made it to me a bit complicated to find the way around the metric code. I made 
attempt looking at what would actually be the consequences of trying to move 
all.
    
    I think that this is part of the issue that this PR addresses, rather than 
a followup.


> Move Metrics API to separate module
> -----------------------------------
>
>                 Key: FLINK-4192
>                 URL: https://issues.apache.org/jira/browse/FLINK-4192
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.1.0
>
>
> All metrics code currently resides in flink-core. If a user implements a 
> reporter and wants a fat jar it will now have to include the entire 
> flink-core module.
> Instead, we could move several interfaces into a separate module.
> These interfaces to move include:
> * Counter, Gauge, Histogram(Statistics)
> * MetricGroup
> * MetricReporter, Scheduled, AbstractReporter
> In addition a new MetricRegistry interface will be required as well as a 
> replacement for the Configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to