[
https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389355#comment-15389355
]
ASF GitHub Bot commented on FLINK-4192:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2226
I had a chat with @tillrohrmann about moving all classes when i started
working on this issue. We decided to not include implementations in the new
module, to be able to use NetUtils and Preconditions. As such, the scope of
this issue was defined as moving user-facing interfaces into a separate module.
If you want to move the remaining classes as well, please open a separate
JIRA so we can revisit the discussion.
As there is no conflict between your proposal and the changes in this PR, i
would propose merging the PR as is.
> Move Metrics API to separate module
> -----------------------------------
>
> Key: FLINK-4192
> URL: https://issues.apache.org/jira/browse/FLINK-4192
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.1.0
>
>
> All metrics code currently resides in flink-core. If a user implements a
> reporter and wants a fat jar it will now have to include the entire
> flink-core module.
> Instead, we could move several interfaces into a separate module.
> These interfaces to move include:
> * Counter, Gauge, Histogram(Statistics)
> * MetricGroup
> * MetricReporter, Scheduled, AbstractReporter
> In addition a new MetricRegistry interface will be required as well as a
> replacement for the Configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
