zhuzhurk closed pull request #24025: [FLINK-33980][core] Reorganize job
configuration
URL: https://github.com/apache/flink/pull/24025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1451894290
##
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##
@@ -792,7 +792,11 @@ public CompletableFuture
disposeSavepoint(String savepoin
JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1451892446
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/CheckpointAfterAllTasksFinishedITCase.java:
##
@@ -82,7 +83,8 @@ public void setUp() {
@Test
zhuzhurk commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1451774802
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java:
##
@@ -140,7 +140,7 @@ public StreamGraph(
ExecutionConfig ex
zhuzhurk commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1451772433
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/CheckpointAfterAllTasksFinishedITCase.java:
##
@@ -82,7 +83,8 @@ public void setUp() {
@Test
JunRuiLee commented on PR #24025:
URL: https://github.com/apache/flink/pull/24025#issuecomment-1890399834
Thanks @zhuzhurk and @1996fanrui for your reviews, I've updated this pr
accordingly, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1451424406
##
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironmentTest.java:
##
@@ -520,9 +518,7 @@ void testConfigureCheckpo
JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1451424325
##
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironmentComplexConfigurationTest.java:
##
@@ -72,7 +73,7 @@ public
JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1451422776
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##
@@ -2562,19 +2505,26 @@ private StreamGraphGenera
1996fanrui commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1451171109
##
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironmentComplexConfigurationTest.java:
##
@@ -222,7 +223,7 @@ publ
JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1450526101
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/CheckpointAfterAllTasksFinishedITCase.java:
##
@@ -82,7 +83,8 @@ public void setUp() {
@Test
zhuzhurk commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1448756961
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##
@@ -2562,19 +2505,26 @@ private StreamGraphGenerat
zhuzhurk commented on PR #24025:
URL: https://github.com/apache/flink/pull/24025#issuecomment-1886946306
> Thanks @JunRuiLee for the rebase!
>
> Hi @zhuzhurk , would you like to review this PR as well? If no any
comments, I will merge this PR next Monday.
Thanks for helping wit
JunRuiLee commented on PR #24025:
URL: https://github.com/apache/flink/pull/24025#issuecomment-1884160739
Thanks @masteryhx for the heads up, I've updated the PR following the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
masteryhx commented on PR #24025:
URL: https://github.com/apache/flink/pull/24025#issuecomment-1884076649
Hi, @JunRuiLee, https://github.com/apache/flink/pull/24046 has been merged.
You could rebase the master and go ahead.
--
This is an automated message from the Apache Git Service.
To
JunRuiLee commented on PR #24025:
URL: https://github.com/apache/flink/pull/24025#issuecomment-1882495740
> Hi @JunRuiLee , would you mind rebaseing the master branch to fix the CI?
thanks~
Hi @1996fanrui , I am currently waiting for the merge of
https://github.com/apache/flink/pull/
1996fanrui commented on PR #24025:
URL: https://github.com/apache/flink/pull/24025#issuecomment-1882410385
Hi @JunRuiLee , would you mind rebaseing the master branch to fix the CI?
thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
JunRuiLee commented on PR #24025:
URL: https://github.com/apache/flink/pull/24025#issuecomment-1879625110
Updated this PR with a rebase onto the master branch and resolved conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1442718242
##
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##
@@ -1201,6 +1212,9 @@ public void configure(ReadableConfig configuration,
ClassLoade
1996fanrui commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1442706214
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##
@@ -453,7 +440,10 @@ public StreamExecutionEnvir
1996fanrui commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1442704443
##
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##
@@ -1201,6 +1212,9 @@ public void configure(ReadableConfig configuration,
ClassLoad
JunRuiLee commented on PR #24025:
URL: https://github.com/apache/flink/pull/24025#issuecomment-1878390963
Thanks @1996fanrui for the quick reviews, I've updated this pr, PTAL~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1442675488
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##
@@ -453,7 +440,10 @@ public StreamExecutionEnviro
JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1442659438
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java:
##
@@ -385,7 +335,9 @@ private void configureStreamGraph(final S
JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1442658972
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java:
##
@@ -614,7 +563,9 @@ private Collection
legacyTransform(Trans
JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1442656319
##
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##
@@ -1201,6 +1212,9 @@ public void configure(ReadableConfig configuration,
ClassLoade
JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1442654302
##
flink-core/src/main/java/org/apache/flink/api/common/cache/DistributedCache.java:
##
@@ -228,6 +229,21 @@ public static List>
parseCachedFilesFromSt
1996fanrui commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1442527329
##
flink-core/src/main/java/org/apache/flink/api/common/cache/DistributedCache.java:
##
@@ -228,6 +229,21 @@ public static List>
parseCachedFilesFromSt
JunRuiLee commented on PR #24025:
URL: https://github.com/apache/flink/pull/24025#issuecomment-1878160985
> Thanks @JunRuiLee for the contribution!
>
> [FLINK-33935](https://issues.apache.org/jira/browse/FLINK-33935) improves
2 options related to statebackend and checkpoint. It is mer
JunRuiLee commented on PR #24025:
URL: https://github.com/apache/flink/pull/24025#issuecomment-1876320136
@zhuzhurk Could you help to review this PR ? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
flinkbot commented on PR #24025:
URL: https://github.com/apache/flink/pull/24025#issuecomment-187628
## CI report:
* 0d717f15ab0a48c816817eb0231b45378f00d8ec UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
JunRuiLee opened a new pull request, #24025:
URL: https://github.com/apache/flink/pull/24025
## What is the purpose of the change
Reorganize job configuration
## Brief change log
1. Migrate configuration from non-ConfigOption objects to use ConfigOption.
2. Adopt a
32 matches
Mail list logo
