JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1451422776


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##########
@@ -2562,19 +2505,26 @@ private StreamGraphGenerator 
getStreamGraphGenerator(List<Transformation<?>> tra
                     "No operators defined in streaming topology. Cannot 
execute.");
         }
 
+        // Synchronize the cached file to config option 
PipelineOptions.CACHED_FILES
+        if (!getCachedFiles().isEmpty()) {

Review Comment:
   Because the cacheFile object is exposed to users and users can add items 
externally, so we could not migrate it to configuration. I'll add some comment 
for this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to