JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1451424406
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironmentTest.java:
##########
@@ -520,9 +518,7 @@ void testConfigureCheckpointStorage() {
StreamExecutionEnvironment.getExecutionEnvironment(configuration);
CheckpointStorage storage =
env.getCheckpointConfig().getCheckpointStorage();
- assertThat(storage).isInstanceOf(JobManagerCheckpointStorage.class);
- assertThat(((JobManagerCheckpointStorage) storage).getCheckpointPath())
- .isEqualTo(new Path(path));
+ assertThat(storage).isNull();
Review Comment:
Since there are already corresponding unit tests covering the creation of
StateBackend, CheckpointStorage, and Restart Strategy from the job
configuration of the execution graph, I have added a case,
testJobConfigFromEnvToExecutionGraph, to cover the transfer of the
configuration from the environment to the execution graph as the job
configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
