JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1442675488
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##########
@@ -453,7 +440,10 @@ public StreamExecutionEnvironment setBufferTimeout(long
timeoutMillis) {
throw new IllegalArgumentException("Timeout of buffer must be
non-negative or -1");
}
- this.bufferTimeout = timeoutMillis;
+ if (timeoutMillis == ExecutionOptions.DISABLED_NETWORK_BUFFER_TIMEOUT)
{
+ this.configuration.set(ExecutionOptions.BUFFER_TIMEOUT_ENABLED,
false);
+ }
+ this.configuration.set(ExecutionOptions.BUFFER_TIMEOUT,
Duration.ofMillis(timeoutMillis));
return this;
Review Comment:
In fact, the getter/setter API provides a user-friendly configuration
method, and for me, I have not yet found a very clear and compelling reason for
removing this API.
WDYT？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
