Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4674
I'm +1 with the first option, i.e. declare the element field as
`transient`. You are right, the `SingleElementIterable` is not necessary to be
serialized.
---
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4936
I will help and merge this .
---
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4936
Thanks for the work! The code looks good to me.
+1
---
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4710
Looks good to me.
+1
---
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4536
Hi @fhueske , I have fixed the conflicts and update the docs to describe
the var-arg support.
---
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4536#discussion_r140163581
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/TableSqlFunction.scala
---
@@ -40,17 +40,14 @@ class
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4635
Hi @fhueske , thanks for the work! It is a very important fix! I'm fine
with the changes.
+1 to merge
---
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r136363886
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala
---
@@ -19,9 +19,21 @@
package
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r136362552
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
---
@@ -106,6 +106,43 @@ abstract class
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4629
Thanks for the hotfix, will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4624
The CI failed but is not related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4624#discussion_r136308757
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UserDefinedFunction.scala
---
@@ -41,7 +41,7 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4624#discussion_r136308925
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -268,6 +269,7 @@ object
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4536
Hi @sunjincheng121 I have updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4536#discussion_r136287683
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/TableSqlFunction.scala
---
@@ -74,48 +75,102 @@ class
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4620
Thanks for updating.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4620#discussion_r136014510
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/validation/UserDefinedFunctionValidationTest.scala
---
@@ -0,0 +1,42
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4620#discussion_r136014662
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/validation/UserDefinedFunctionValidationTest.scala
---
@@ -0,0 +1,42
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4620#discussion_r136014229
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/ScalarSqlFunction.scala
---
@@ -106,7 +106,9 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4536#discussion_r135430307
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala
---
@@ -71,6 +69,9 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4536#discussion_r135430161
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala
---
@@ -36,10 +36,8 @@ import
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4585
Hi @suez1224 thanks for the PR, I think we can use `Array` instead of
`AbstractMultiSet`. `AbstractMultiSet` is too obscure for users. In that case,
we do not need the MultiSetSerilizer and
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4355
The new created method `open(ctx)` and `close()` of `GeneratedAggregations`
are not called by `AggregateAggFunction` which is used in window aggregate. I
suggest to call the `open(ctx)` method but
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4536
@sunjincheng121 @fhueske I would be great if you can have a look ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134158258
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala
---
@@ -19,9 +19,21 @@
package
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134158670
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -132,6 +132,44 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134162144
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -502,26 +513,140 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134177144
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -502,26 +513,140 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134173548
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -800,6 +794,66 @@ class Table
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134180276
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CsvSQLTableSink.scala
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134161822
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -502,26 +513,140 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134173572
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -800,6 +794,66 @@ class Table
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134160516
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -502,26 +513,140 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134135181
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -162,13 +172,66 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134151688
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/StateViewUtils.scala
---
@@ -0,0 +1,75 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134137708
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1646,4 +1649,86 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134134801
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala
---
@@ -100,6 +107,11 @@ abstract
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134153349
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -80,7 +82,8 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134118741
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/MapView.scala
---
@@ -0,0 +1,192 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134118886
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -105,6 +108,13 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134138469
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1646,4 +1649,86 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134151559
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134139167
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1646,4 +1649,86 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134118759
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/MapView.scala
---
@@ -0,0 +1,192 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134137525
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1646,4 +1649,86 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134118408
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134118959
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -162,13 +172,66 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134152736
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -307,6 +312,119 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134118851
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134119014
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -162,13 +172,66 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134118744
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/MapView.scala
---
@@ -0,0 +1,192 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134118240
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -108,30 +112,38 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134118203
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -307,6 +312,119 @@ object
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4530
I'm fine with the changes. +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4544
[FLINK-7451] [table] Support non-ascii character literals in Table API and
SQL
## What is the purpose of the change
The non-ascii characters in string literals causes calcite planner to
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4532
I'm +1 to merge this.
I have create two followup issue, we can move the discussion under the JIRA:
(1) FLINK-7446
Support to define an existing field as the rowtime fiel
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4488#discussion_r133104586
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/StreamTableSourceScan.scala
---
@@ -46,29 +47,29 @@ class
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4538
Thanks for the reminding @zentol . I will pay attention to the commit
message in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4538
[FLINK-7441] [table] Double quote string literals is not supported in Table
API and SQL
## What is the purpose of the change
Code generation doesn't handle double quote string literal
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4536
[FLINK-7439] [table] Support variable arguments for UDTF in SQL
## What is the purpose of the change
Support variable arguments for UDTF in SQL
## Brief change log
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132863952
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/ProctimeSqlFunction.scala
---
@@ -22,12 +22,12 @@ import
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132840719
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -719,33 +715,47 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132841043
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132834552
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132839934
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/conversion/CRowToJavaTupleMapRunner.scala
---
@@ -16,32 +16,32
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4488#discussion_r132819009
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/CRowInputTupleOutputMapRunner.scala
---
@@ -19,7 +19,9 @@
package
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4488#discussion_r132817997
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1247,27 +1258,32 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4488#discussion_r132818559
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/StreamTableSourceScan.scala
---
@@ -46,29 +47,29 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4488#discussion_r132819122
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/WrappingTimestampSetterProcessFunction.scala
---
@@ -0,0 +1,61
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4488
@twalthr I'm working on other issues before Thursday, so I would like to
have a look at it at Thursday (Beijing). But if you are hurry, I'm fine to
merge this first.
---
If your proj
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4373#discussion_r131512787
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/calcite/rel/rules/PushProjector.java
---
@@ -0,0 +1,864 @@
+/*
+ * Licensed to the
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4373#discussion_r131302891
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/JoinTest.scala
---
@@ -55,12 +55,13 @@ class JoinTest extends
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128798162
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4379
Loos good to me. +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128499164
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -535,4 +654,21 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128499278
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -535,4 +654,21 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128495510
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/ListViewSerializer.scala
---
@@ -0,0 +1,111
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128493758
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/HeapViewFactory.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128495405
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/ListViewSerializer.scala
---
@@ -0,0 +1,111
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128495770
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/ListViewSerializer.scala
---
@@ -0,0 +1,111
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128496007
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/MapViewSerializer.scala
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128500452
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1399,14 +1463,28 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128492343
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128493583
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/DataViewFactory.scala
---
@@ -0,0 +1,35 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128493316
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -357,6 +423,9 @@ class
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4263
@rtudoran I have exactly the same idea with you. Calcite doesn't push
partition fields to LogicalSort. Actually, LogicalSort doesn't have a partition
field. So I make a custom rule to
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4263
Hi @fhueske , I left this comment under the JIRA. To make sure you know
our situation, I post it here:
>I think the most useful feature is PR3 "ORDER BY OFFSET FETCH"
(i.e.
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4128#discussion_r127868400
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala
---
@@ -33,6 +33,14 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4128#discussion_r127866461
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -82,4 +82,24 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4128#discussion_r127868565
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
@@ -352,6 +352,14 @@ class
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4171
@fhueske thanks for reviewing. I had fixed the code style issue.
I will merge this once the CI pass.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4263
@rtudoran "SELECT x FROM stream ORDER BY *time FETCH 2" do not need
retraction. Because it is order by ascending time. The query will only emit the
first 2 rows and after that drop al
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4324
The code looks good to me. Good refactoring!
+1 to merge.
BTW, I have a question. This time-windowed join is different with
`DataStream.join(...).window(...)`. The
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4274
+1 to merge.
I will merge this in this weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4274#discussion_r127382075
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/stringExpressions.scala
---
@@ -277,3 +278,47 @@ case class Overlay
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4266#discussion_r127192628
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala
---
@@ -0,0 +1,187
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4266#discussion_r127173868
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala
---
@@ -0,0 +1,187
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4266#discussion_r127165003
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala
---
@@ -0,0 +1,187
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4266#discussion_r126683700
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/JoinITCase.scala
---
@@ -0,0 +1,117
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4266#discussion_r127142150
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeWindowInnerJoin.scala
---
@@ -0,0 +1,326
1 - 100 of 647 matches
Mail list logo
