Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134173548
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -800,6 +794,66 @@ class Table(
}
/**
+ * Writes the [[Table]] to a [[TableSink]] specified by given name. The
tableSink name
+ * represents a registered [[TableSink]] which defines an external
storage location.
+ *
+ * A batch [[Table]] can only be written to a
+ * [[org.apache.flink.table.sinks.BatchTableSink]], a streaming
[[Table]] requires a
+ * [[org.apache.flink.table.sinks.AppendStreamTableSink]], a
+ * [[org.apache.flink.table.sinks.RetractStreamTableSink]], or an
+ * [[org.apache.flink.table.sinks.UpsertStreamTableSink]].*
+ *
+ * @param tableSink Name of the [[TableSink]] to which the [[Table]] is
written.
+ * @tparam T The data type that the [[TableSink]] expects.
+ */
+ def insertInto[T](tableSink: String): Unit = {
+ insertInto(tableSink,
QueryConfig.getQueryConfigFromTableEnv(this.tableEnv))
+ }
+
+ /**
+ * Writes the [[Table]] to a [[TableSink]] specified by given name. The
tableSink name
+ * represents a registered [[TableSink]] which defines an external
storage location.
+ *
+ * A batch [[Table]] can only be written to a
+ * [[org.apache.flink.table.sinks.BatchTableSink]], a streaming
[[Table]] requires a
+ * [[org.apache.flink.table.sinks.AppendStreamTableSink]], a
+ * [[org.apache.flink.table.sinks.RetractStreamTableSink]], or an
+ * [[org.apache.flink.table.sinks.UpsertStreamTableSink]].*
+ *
+ * @param tableSink Name of the [[TableSink]] to which the [[Table]] is
written.
+ * @param conf The [[QueryConfig]] to use.
+ * @tparam T The data type that the [[TableSink]] expects.
+ */
+ def insertInto[T](tableSink: String, conf: QueryConfig): Unit = {
--- End diff --
change the parameter name `tableSink` to `tableName` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
