Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4488#discussion_r132817997
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1247,27 +1258,32 @@ abstract class CodeGenerator(
}
}
- private[flink] def generateRecordTimestamp(isEventTime: Boolean):
GeneratedExpression = {
+ private[flink] def generateRowtimeAccess(): GeneratedExpression = {
val resultTerm = newName("result")
- val resultTypeTerm =
primitiveTypeTermForTypeInfo(SqlTimeTypeInfo.TIMESTAMP)
+ val nullTerm = newName("isNull")
- val resultCode = if (isEventTime) {
+ val accessCode =
s"""
- |$resultTypeTerm $resultTerm;
- |if ($contextTerm.timestamp() == null) {
+ |Long $resultTerm = $contextTerm.timestamp();
+ |if ($resultTerm == null) {
| throw new RuntimeException("Rowtime timestamp is null. Please
make sure that a proper " +
| "TimestampAssigner is defined and the stream environment uses
the EventTime time " +
| "characteristic.");
|}
- |else {
- | $resultTerm = $contextTerm.timestamp();
- |}
- |""".stripMargin
- } else {
+ |boolean $nullTerm = false;
+ """.stripMargin
+
+ GeneratedExpression(resultTerm, nullTerm, accessCode,
TimeIndicatorTypeInfo.ROWTIME_INDICATOR)
+ }
+
+ private[flink] def generateProctimeTimestamp(): GeneratedExpression = {
+ val resultTerm = newName("result")
+ val resultTypeTerm =
primitiveTypeTermForTypeInfo(SqlTimeTypeInfo.TIMESTAMP)
+
+ val resultCode =
s"""
|$resultTypeTerm $resultTerm =
$contextTerm.timerService().currentProcessingTime();
--- End diff --
Why not hardcode the `$resultTypeTerm` as `long` ? The
`currentProcessingTime()` always returns `long` primitive type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
