Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4620#discussion_r136014229
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/ScalarSqlFunction.scala
---
@@ -106,7 +106,9 @@ object ScalarSqlFunction {
val operandTypeInfo = getOperandTypeInfo(callBinding)
val foundSignature = getEvalMethodSignature(scalarFunction,
operandTypeInfo)
- .getOrElse(throw new ValidationException(s"Operand types of
could not be inferred."))
+ .getOrElse(throw new ValidationException(
+ s"[${scalarFunction.getClass}]'s Operand types of
[${operandTypeInfo}] " +
--- End diff --
I think the message can be improve like this , I copied the code from
`createOperandTypeChecker` in this class.
```
throw new ValidationException(
s"Given parameters of function '$name' do not match any
signature. \n" +
s"Actual: ${signatureToString(operandTypeInfo)} \n" +
s"Expected: ${signaturesToString(scalarFunction, "eval")}")`
```
And I think we need to update AggregateSqlFunction as well if needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
