Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6392
Thanks, merging
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6231
Thanks for verification and reporting issue!
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6403
One issue. Please copy
> According to the DefinedFieldMapping interface the field mapping can also
contain the input fields. However, the Kafka table source factory was call
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6392#discussion_r204696678
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java
---
@@ -46,8 +46,6 @@
public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6392#discussion_r204695915
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java
---
@@ -46,8 +46,6 @@
public
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6231
True, `checkNotNull(nestedSerializers);` is useless.
Allowing nulls without enabled compile errors on violated `@Nullable`
checks (this we can not enable in Flink) always leads to some
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/6392
[FLINK-9694][table] Fix NPE in CRowSerializerConfigSnapshot constructor
## What is the purpose of the change
Fix NPE in CRowSerializerConfigSnapshot constructor
## Verifying this
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6387#discussion_r204406421
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSink.java
---
@@ -40,27 +45,68
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6231
Nope, you are not quite correct. This:
```
def this() = this(null)//scala
```
translates to
```
CompositeTypeSerializerConfigSnapshot(null);
```
But because of
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6387#discussion_r204351776
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceSinkFactoryBase.java
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6387#discussion_r204347924
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSink.java
---
@@ -40,27 +45,68
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6387#discussion_r204351288
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceSinkFactoryBase.java
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6387#discussion_r204342252
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010TableSink.java
---
@@ -0,0 +1,73
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6387#discussion_r204348635
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSink.java
---
@@ -82,49 +129,97
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6387#discussion_r204346083
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka011TableSink.java
---
@@ -0,0 +1,73
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6387#discussion_r204342102
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010JsonTableSink.java
---
@@ -58,14
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6387#discussion_r204346197
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java
---
@@ -84,7
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6387#discussion_r204346382
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08TableSink.java
---
@@ -0,0 +1,73
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6387#discussion_r204346742
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka09TableSink.java
---
@@ -0,0 +1,73
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r204330930
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyClientServerSslTest.java
---
@@ -65,6 +68,60 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r204336114
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -163,80 +163,188 @@ public static void
setSSLVerifyHostname
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r204298813
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyConfig.java
---
@@ -189,23 +192,34 @@ public TransportType
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r204300332
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyClient.java
---
@@ -52,6 +56,9 @@
private Bootstrap
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r204329262
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -249,14 +357,73 @@ public static SSLContext
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r204326191
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -163,80 +163,188 @@ public static void
setSSLVerifyHostname
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r204301373
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyClient.java
---
@@ -52,6 +56,9 @@
private Bootstrap
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r204325132
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyServer.java
---
@@ -61,6 +63,9 @@
private
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r204328091
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -163,80 +163,188 @@ public static void
setSSLVerifyHostname
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r204324645
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyClient.java
---
@@ -175,7 +183,6 @@ ChannelFuture connect(final
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r204329756
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyClientServerSslTest.java
---
@@ -65,6 +68,60 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6355#discussion_r204328596
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -163,80 +163,188 @@ public static void
setSSLVerifyHostname
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6231
I agree with @zentol and I do not see reason for supporting nulls here.
This fix looks like hiding underlying implementation problem. Default
constructor of `CRowSerializerConfigSnapshot` could
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6091
Looking at the git history it looks like it's there.
---
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r203301509
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -18,33 +18,299
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r203303655
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableUtil.scala
---
@@ -0,0 +1,148
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r203341010
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/StreamTableDescriptor.scala
---
@@ -0,0 +1,182
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r203301285
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -18,33 +18,299
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r203304035
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/BatchTableDescriptor.scala
---
@@ -0,0 +1,126
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r202966706
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/BatchTableDescriptor.scala
---
@@ -0,0 +1,126
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r202963074
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableUtil.scala
---
@@ -0,0 +1,148
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r202923853
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -18,33 +18,299
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r202915534
--- Diff:
flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/EnvironmentTest.java
---
@@ -40,10 +41,18
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r202964715
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchematicDescriptor.scala
---
@@ -19,14 +19,17 @@
package
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r202964290
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableUtil.scala
---
@@ -0,0 +1,148
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r202966786
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/CsvAppendTableSinkFactory.scala
---
@@ -0,0 +1,52
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r202965391
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/StreamTableDescriptor.scala
---
@@ -0,0 +1,182
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r202964952
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/StreamTableDescriptor.scala
---
@@ -0,0 +1,182
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r202965060
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/BatchTableDescriptor.scala
---
@@ -0,0 +1,126
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r202963234
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableUtil.scala
---
@@ -0,0 +1,148
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r202961529
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -18,33 +18,299
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202520986
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/SourceSink.java
---
@@ -51,16 +51,10 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202521065
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFormatFactory.scala
---
@@ -16,42 +16,17
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202521122
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala
---
@@ -18,143 +18,358
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202521212
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala
---
@@ -18,143 +18,358
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202520938
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactory.scala
---
@@ -16,14 +16,14 @@
* limitations
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202520618
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
---
@@ -329,14 +341,46 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202520454
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
@@ -354,6 +398,23 @@ private void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202520415
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
@@ -173,55 +180,92 @@ public void open
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6332
One more thing. Do we need this `-u` flag? Shouldn't it be enough to
support something like:
`flink-cli < query01.sql` or `echo "SELECT * FROM foo" | flink-cli`
---
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202398523
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
@@ -85,6 +86,9 @@ public CliClient
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202421703
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
---
@@ -371,6 +416,13 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202421784
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
---
@@ -381,6 +433,23 @@ private
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202421005
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
---
@@ -329,14 +341,46 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202407651
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
@@ -173,55 +180,92 @@ public void open
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202427682
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ProgramDeployer.java
---
@@ -73,7 +86,7 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202408478
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
@@ -173,55 +180,92 @@ public void open
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202420258
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
@@ -354,6 +398,23 @@ private void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202419608
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
@@ -173,55 +180,92 @@ public void open
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202407072
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/SqlClient.java
---
@@ -97,14 +97,34 @@ private void start
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202356170
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/CsvTableSinkFactory.scala
---
@@ -104,17 +100,12 @@ class
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202282221
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
---
@@ -214,15 +216,18 @@ private static
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202282478
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/SourceSink.java
---
@@ -51,16 +51,10 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202338408
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala
---
@@ -18,143 +18,358
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202335703
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala
---
@@ -18,143 +18,358
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202350406
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -114,6 +114,8 @@ abstract class
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202327344
--- Diff:
flink-libraries/flink-table/src/test/resources/META-INF/services/org.apache.flink.table.connectors.DiscoverableTableFactory
---
@@ -13,5 +13,10
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202334688
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala
---
@@ -18,143 +18,358
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202350170
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
---
@@ -103,24 +103,40 @@ abstract class
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202269785
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -54,51
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202336263
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala
---
@@ -18,143 +18,358
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202335205
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala
---
@@ -18,143 +18,358
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202289678
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableSourceUtil.scala
---
@@ -44,32 +43,27 @@ object
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202275530
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactory.scala
---
@@ -21,7 +21,14 @@ package
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202352869
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalTableSourceScan.scala
---
@@ -52,12 +52,9
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202347281
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
---
@@ -329,18 +329,6 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202333467
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/exceptions.scala
---
@@ -143,118 +143,82 @@ case class
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202356462
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/TableEnvironmentITCase.scala
---
@@ -186,7 +186,7
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202337455
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala
---
@@ -18,143 +18,358
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202348312
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ProgramDeployer.java
---
@@ -63,65 +62,45 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202334605
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala
---
@@ -18,143 +18,358
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202281623
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
---
@@ -214,15 +216,18 @@ private static
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202268019
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -54,51
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202268054
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -54,51
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202332281
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFormatFactory.scala
---
@@ -16,42 +16,17
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202351647
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -465,14 +465,14 @@ abstract class
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202334214
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala
---
@@ -18,143 +18,358
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202282838
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSourceFactoryTest.java
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202354777
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/TableSourceSinkTable.scala
---
@@ -21,23 +21,47 @@ package
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202271871
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceFactory.java
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202282625
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/TableSinkDescriptor.scala
---
@@ -22,9 +22,11 @@ package
1 - 100 of 902 matches
Mail list logo
