Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202281623
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
---
@@ -214,15 +216,18 @@ private static TableDescriptor
createTableDescriptor(String name, Map<String, Ob
if (typeObject == null || !(typeObject instanceof String)) {
throw new SqlClientException("Invalid 'type' attribute
for table '" + name + "'.");
}
- final String type = (String) config.get(TABLE_TYPE);
+ final String type = (String) typeObject;
+ final Map<String, Object> properties = new HashMap<>(config);
--- End diff --
copy of `config` named as `properties`? this is confusing. Rename `config`
to `properties` and inline this copy? Or inline `properties` and rename
`normalizedProperties` back to `normalizedConfig`
---
