[GitHub] flink pull request #6343: [FLINK-9852] [table] Expose descriptor-based sink ...

[pnowojski]

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6343#discussion_r202915534
  
    --- Diff: 
flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/EnvironmentTest.java
 ---
    @@ -40,10 +41,18 @@
     
        @Test
        public void testMerging() throws Exception {
    -           final Environment env1 = 
EnvironmentFileUtil.parseUnmodified(DEFAULTS_ENVIRONMENT_FILE);
    +           final Map<String, String> replaceVars1 = new HashMap<>();
    +           replaceVars1.put("$VAR_UPDATE_MODE", "update-mode: append");
    +           final Environment env1 = EnvironmentFileUtil.parseModified(
    +                   DEFAULTS_ENVIRONMENT_FILE,
    +                   replaceVars1);
    +
    +           final Map<String, String> replaceVars2 = new HashMap<>();
    --- End diff --
    
    ```
    final Map<String, String> replaceVars2 = new HashMap<>(replaceVars1);
    ```
    and you can drop the line below


---