Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6323#discussion_r202348312
  
    --- Diff: 
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ProgramDeployer.java
 ---
    @@ -63,65 +62,45 @@ public void run() {
                        LOG.debug("Submitting job {} with the following 
environment: \n{}",
                                        jobGraph.getJobID(), 
context.getMergedEnvironment());
                }
    -           if (result != null) {
    -                   executionResultBucket.add(deployJob(context, jobGraph, 
result));
    -           } else {
    -                   deployJob(context, jobGraph, result);
    -           }
    +           executionResultBucket.add(deployJob(context, jobGraph, result));
        }
     
        public JobExecutionResult fetchExecutionResult() {
    -           if (result != null) {
    -                   return executionResultBucket.poll();
    -           } else {
    -                   return null;
    -           }
    +           return executionResultBucket.poll();
        }
     
        /**
    -    * Deploys a job. Depending on the deployment creates a new job 
cluster. If result is requested,
    -    * it saves the cluster id in the result and blocks until job 
completion.
    +    * Deploys a job. Depending on the deployment creates a new job 
cluster. It saves the cluster id in
    --- End diff --
    
    How do those changes in this file relate to rest of the PR/commit?


---

Reply via email to