Re: [PR] [FLINK-37078] Fix for jackson-mapper-asl 1.9.13 vulnerability [flink]

2025-04-29 Thread via GitHub
anupamaggarwal commented on PR #25890: URL: https://github.com/apache/flink/pull/25890#issuecomment-2840935863 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Closed] (FLINK-37734) Update version to 3.5-SNAPSHOT and update related docs

2025-04-29 Thread Yanquan Lv (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanquan Lv closed FLINK-37734. -- Resolution: Fixed Fixed in master via ecaf82e435052570d78fd92a41b195b287504079 > Update version to 3.

[jira] [Assigned] (FLINK-37734) Update version to 3.5-SNAPSHOT and update related docs

2025-04-29 Thread Yanquan Lv (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanquan Lv reassigned FLINK-37734: -- Assignee: Yanquan Lv > Update version to 3.5-SNAPSHOT and update related docs > -

[jira] [Reopened] (FLINK-37728) Incorrect import in EmbeddedPythonWindowOperator.java

2025-04-29 Thread Shuyi Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuyi Chen reopened FLINK-37728: > Incorrect import in EmbeddedPythonWindowOperator.java >

[jira] [Resolved] (FLINK-37728) Incorrect import in EmbeddedPythonWindowOperator.java

2025-04-29 Thread Shuyi Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuyi Chen resolved FLINK-37728. Resolution: Fixed > Incorrect import in EmbeddedPythonWindowOperator.java > --

Re: [PR] Externalized Kudu connector blog post [flink-web]

2025-04-29 Thread via GitHub
ferenc-csaky merged PR #791: URL: https://github.com/apache/flink-web/pull/791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[jira] [Comment Edited] (FLINK-37370) [Observer] Finished batch jobs throw ReconciliationException and never reach FINISHED in the CR

2025-04-29 Thread Jakob Homan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948304#comment-17948304 ] Jakob Homan edited comment on FLINK-37370 at 4/30/25 12:06 AM: ---

[jira] [Commented] (FLINK-37370) [Observer] Finished batch jobs throw ReconciliationException and never reach FINISHED in the CR

2025-04-29 Thread Jakob Homan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948304#comment-17948304 ] Jakob Homan commented on FLINK-37370: -  Hey [~rmetzger] - we've hit this.  Do you ex

Re: [PR] Externalized Kudu connector blog post [flink-web]

2025-04-29 Thread via GitHub
ferenc-csaky commented on code in PR #791: URL: https://github.com/apache/flink-web/pull/791#discussion_r2067429195 ## docs/content/posts/2025-04-30-introducing-the-externalized-kudu-connector.md: ## @@ -0,0 +1,89 @@ +--- +title: "Introducing the externalized Kudu connector" +d

[jira] [Updated] (FLINK-37751) Add vertex name to autoscaler metrics

2025-04-29 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Sharath Dandi updated FLINK-37751: -- Priority: Minor (was: Major) > Add vertex name to autoscaler metrics > --

Re: [PR] [hotfix][python] Enable parallel builds for python API docs [flink]

2025-04-29 Thread via GitHub
autophagy commented on PR #26520: URL: https://github.com/apache/flink/pull/26520#issuecomment-2840059080 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-37751) Add vertex name to autoscaler metrics

2025-04-29 Thread Sai Sharath Dandi (Jira)
Sai Sharath Dandi created FLINK-37751: - Summary: Add vertex name to autoscaler metrics Key: FLINK-37751 URL: https://issues.apache.org/jira/browse/FLINK-37751 Project: Flink Issue Type: I

[jira] [Commented] (FLINK-37751) Add vertex name to autoscaler metrics

2025-04-29 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948268#comment-17948268 ] Sai Sharath Dandi commented on FLINK-37751: --- Hi [~fanrui] , Could you please r

Re: [PR] [FLINK-37733] Externalise DynamoDB connector IT Test to E2E test package [flink-connector-aws]

2025-04-29 Thread via GitHub
darenwkt commented on code in PR #203: URL: https://github.com/apache/flink-connector-aws/pull/203#discussion_r2067097654 ## flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/table/RowDataToAttributeValueConverterTest.java: ## @@ -21

Re: [PR] [hotfix] Update high-availability configs to newer syntax [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
maxime-menard commented on PR #764: URL: https://github.com/apache/flink-kubernetes-operator/pull/764#issuecomment-2839790198 While doing the migration to Flink 2.0, I had to make the change otherwise I was getting this ``` WARN Config uses deprecated configuration key 'high-ava

Re: [PR] [FLINK-37695][table] Fix parsing for built-in function JSON in JSON_OBJECT for all positions [flink]

2025-04-29 Thread via GitHub
gustavodemorais commented on code in PR #26474: URL: https://github.com/apache/flink/pull/26474#discussion_r2067090762 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java: ## @@ -821,12 +821,18 @@ private static List

Re: [PR] [FLINK-31406] Do not delete jobgraph on scale only last-state upgrades [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
pchoudhury22 commented on PR #968: URL: https://github.com/apache/flink-kubernetes-operator/pull/968#issuecomment-2839727922 Thanks so much for all the notes!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-36666) CI/CD should check NOTICE files for discrepancies.

2025-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-3: --- Labels: pull-request-available (was: ) > CI/CD should check NOTICE files for discrepancies.

[PR] [FLINK-36666] Add unit test to verify dependencies in META-INF/NOTICE [flink-connector-aws]

2025-04-29 Thread via GitHub
darenwkt opened a new pull request, #204: URL: https://github.com/apache/flink-connector-aws/pull/204 ## Purpose of the change [FLINK-3] Add unit test to verify dependencies in META-INF/NOTICE - Currently, META-INF/NOTICE file is verified manually - This change in

Re: [PR] [FLINK-37695][table] Fix parsing for built-in function JSON in JSON_OBJECT for all positions [flink]

2025-04-29 Thread via GitHub
lihaosky commented on code in PR #26474: URL: https://github.com/apache/flink/pull/26474#discussion_r2066987345 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java: ## @@ -821,12 +821,18 @@ private static List jsonSp

Re: [PR] [FLINK-37695][table] Fix parsing for built-in function JSON in JSON_OBJECT for all positions [flink]

2025-04-29 Thread via GitHub
gustavodemorais commented on code in PR #26474: URL: https://github.com/apache/flink/pull/26474#discussion_r2066973510 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java: ## @@ -821,12 +821,18 @@ private static List

Re: [PR] Externalized Kudu connector blog post [flink-web]

2025-04-29 Thread via GitHub
mbalassi commented on code in PR #791: URL: https://github.com/apache/flink-web/pull/791#discussion_r2066950306 ## docs/content/posts/2025-04-30-introducing-the-externalized-kudu-connector.md: ## @@ -0,0 +1,89 @@ +--- +title: "Introducing the externalized Kudu connector" +date:

Re: [PR] [hotfix][python] Enable parallel builds for python API docs [flink]

2025-04-29 Thread via GitHub
flinkbot commented on PR #26520: URL: https://github.com/apache/flink/pull/26520#issuecomment-2839503780 ## CI report: * 0ef58034bdc18b0bd4efbc3d88bcebae6f644e07 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][python] Enable parallel builds for python API docs [flink]

2025-04-29 Thread via GitHub
autophagy opened a new pull request, #26520: URL: https://github.com/apache/flink/pull/26520 ## What is the purpose of the change I noticed that building the Flink Python API docs by running `make html` in `flink-python/docs` can take longer than I expected - often well over 1 minute,

Re: [PR] Externalized Kudu connector blog post [flink-web]

2025-04-29 Thread via GitHub
fruska commented on code in PR #791: URL: https://github.com/apache/flink-web/pull/791#discussion_r2066879049 ## docs/content/posts/2025-04-30-introducing-the-externalized-kudu-connector.md: ## @@ -0,0 +1,89 @@ +--- +title: "Introducing the externalized Kudu connector" +date: "

Re: [PR] Externalized Kudu connector blog post [flink-web]

2025-04-29 Thread via GitHub
fruska commented on code in PR #791: URL: https://github.com/apache/flink-web/pull/791#discussion_r2066879049 ## docs/content/posts/2025-04-30-introducing-the-externalized-kudu-connector.md: ## @@ -0,0 +1,89 @@ +--- +title: "Introducing the externalized Kudu connector" +date: "

Re: [PR] Externalized Kudu connector blog post [flink-web]

2025-04-29 Thread via GitHub
fruska commented on code in PR #791: URL: https://github.com/apache/flink-web/pull/791#discussion_r2066877804 ## docs/content/posts/2025-04-30-introducing-the-externalized-kudu-connector.md: ## @@ -0,0 +1,89 @@ +--- +title: "Introducing the externalized Kudu connector" Review

Re: [PR] [FLINK-37695][table] Fix parsing for built-in function JSON in JSON_OBJECT for all positions [flink]

2025-04-29 Thread via GitHub
lihaosky commented on code in PR #26474: URL: https://github.com/apache/flink/pull/26474#discussion_r2066877602 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java: ## @@ -821,12 +821,18 @@ private static List jsonSp

Re: [PR] Externalized Kudu connector blog post [flink-web]

2025-04-29 Thread via GitHub
ferenc-csaky commented on code in PR #791: URL: https://github.com/apache/flink-web/pull/791#discussion_r2066875547 ## docs/content/posts/2025-04-30-introducing-the-externalized-kudu-connector.md: ## @@ -0,0 +1,89 @@ +--- +title: "Introducing the externalized Kudu connector" +d

Re: [PR] Externalized Kudu connector blog post [flink-web]

2025-04-29 Thread via GitHub
fruska commented on code in PR #791: URL: https://github.com/apache/flink-web/pull/791#discussion_r2066871128 ## docs/content/posts/2025-04-30-introducing-the-externalized-kudu-connector.md: ## @@ -0,0 +1,89 @@ +--- +title: "Introducing the externalized Kudu connector" +date: "

Re: [PR] Externalized Kudu connector blog post [flink-web]

2025-04-29 Thread via GitHub
fruska commented on code in PR #791: URL: https://github.com/apache/flink-web/pull/791#discussion_r2066871128 ## docs/content/posts/2025-04-30-introducing-the-externalized-kudu-connector.md: ## @@ -0,0 +1,89 @@ +--- +title: "Introducing the externalized Kudu connector" +date: "

[PR] Externalized Kudu connector blog post [flink-web]

2025-04-29 Thread via GitHub
ferenc-csaky opened a new pull request, #791: URL: https://github.com/apache/flink-web/pull/791 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [FLINK-37750] Remove unused method FutureUtils.runIfNotDoneAndGet() [flink]

2025-04-29 Thread via GitHub
pranav234 closed pull request #26519: [FLINK-37750] Remove unused method FutureUtils.runIfNotDoneAndGet() URL: https://github.com/apache/flink/pull/26519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] [hotfix][docs] typo Adaptvie/Adaptive in autoscaler docs [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
alkagin opened a new pull request, #976: URL: https://github.com/apache/flink-kubernetes-operator/pull/976 ## What is the purpose of the change *(For example: This pull request adds a new feature to periodically create and maintain savepoints through the `FlinkDeployment` cust

[jira] [Commented] (FLINK-37747) GlobalCommitterOperator cannot commit after scaling writer/committer

2025-04-29 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948176#comment-17948176 ] Arvid Heise commented on FLINK-37747: - https://github.com/apache/flink/pull/26518#is

Re: [PR] [FLINK-37747][runtime] Use old subtask count for restored committable objects [flink]

2025-04-29 Thread via GitHub
AHeise commented on PR #26518: URL: https://github.com/apache/flink/pull/26518#issuecomment-2839056740 Here are some pointers for the IT. I recently added a [rescale test for KafkaSink ](https://github.com/apache/flink-connector-kafka/blob/5384ab2f3a0bc42e6c3019c151f3b72bb4983926/flin

Re: [PR] [FLINK-37750] Remove unused method FutureUtils.runIfNotDoneAndGet() [flink]

2025-04-29 Thread via GitHub
flinkbot commented on PR #26519: URL: https://github.com/apache/flink/pull/26519#issuecomment-2838980391 ## CI report: * 02711a5fe8ece436bf74929293b40fd25c31be29 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-37750) Remove legacy function runIfNotDoneAndGet() in FutureUtils class

2025-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37750: --- Labels: pull-request-available (was: ) > Remove legacy function runIfNotDoneAndGet() in Fut

[PR] [FLINK-37750] Remove unused method FutureUtils.runIfNotDoneAndGet() [flink]

2025-04-29 Thread via GitHub
pranav234 opened a new pull request, #26519: URL: https://github.com/apache/flink/pull/26519 The runIfNotDoneAndGet function is no longer used in the codebase. Removing this function will reduce technical debt and improve code maintainability ## What is the purpose of the change

[jira] [Created] (FLINK-37750) Remove legacy function runIfNotDoneAndGet() in FutureUtils class

2025-04-29 Thread Pranav Mahajan (Jira)
Pranav Mahajan created FLINK-37750: -- Summary: Remove legacy function runIfNotDoneAndGet() in FutureUtils class Key: FLINK-37750 URL: https://issues.apache.org/jira/browse/FLINK-37750 Project: Flink

[jira] [Resolved] (FLINK-37605) SinkWriter may incorrectly infer end of input during rescale

2025-04-29 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise resolved FLINK-37605. - Fix Version/s: 1.19.3 Resolution: Fixed > SinkWriter may incorrectly infer end of input d

[jira] [Commented] (FLINK-37605) SinkWriter may incorrectly infer end of input during rescale

2025-04-29 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948164#comment-17948164 ] Arvid Heise commented on FLINK-37605: - Merged into 1.19 as f869ae8e7ccd2d257f7cb5b2

Re: [PR] [FLINK-37605][runtime] Infer checkpoint id on endInput in sink [1.19] [flink]

2025-04-29 Thread via GitHub
AHeise merged PR #26458: URL: https://github.com/apache/flink/pull/26458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Assigned] (FLINK-37747) GlobalCommitterOperator cannot commit after scaling writer/committer

2025-04-29 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise reassigned FLINK-37747: --- Assignee: David > GlobalCommitterOperator cannot commit after scaling writer/committer > --

[jira] [Updated] (FLINK-37605) SinkWriter may incorrectly infer end of input during rescale

2025-04-29 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise updated FLINK-37605: Fix Version/s: 1.20.2 > SinkWriter may incorrectly infer end of input during rescale > ---

[jira] [Commented] (FLINK-37605) SinkWriter may incorrectly infer end of input during rescale

2025-04-29 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948160#comment-17948160 ] Arvid Heise commented on FLINK-37605: - Merged into 1.20 as 0b6da412cc33b25f9f1ab812

Re: [PR] [FLINK-37605][runtime] Infer checkpoint id on endInput in sink [1.20] [flink]

2025-04-29 Thread via GitHub
AHeise merged PR #26457: URL: https://github.com/apache/flink/pull/26457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-30571] Estimate scalability coefficient from past scaling history using linear regression [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
mxm commented on PR #966: URL: https://github.com/apache/flink-kubernetes-operator/pull/966#issuecomment-2838608059 +1 Let's remove the weighting completely for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [FLINK-37746] Added serialVersionUID in MapTypeInfo class [flink]

2025-04-29 Thread via GitHub
pranav234 commented on code in PR #26515: URL: https://github.com/apache/flink/pull/26515#discussion_r2066170710 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/MapTypeInfo.java: ## @@ -39,6 +39,8 @@ @PublicEvolving public class MapTypeInfo extends TypeInformat

Re: [PR] [FLINK-36528] [Kubernetes Operator] Update org.apache.avro from 1.8.2 to 1.12.0 [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
gyfora commented on PR #901: URL: https://github.com/apache/flink-kubernetes-operator/pull/901#issuecomment-2838530885 Closing this in favor of updating the beam dependency later. Please re-open when necessary :) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-36528] [Kubernetes Operator] Update org.apache.avro from 1.8.2 to 1.12.0 [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
gyfora closed pull request #901: [FLINK-36528] [Kubernetes Operator] Update org.apache.avro from 1.8.2 to 1.12.0 URL: https://github.com/apache/flink-kubernetes-operator/pull/901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Closed] (FLINK-31406) Do not delete jobgraph on scale only last-state upgrades

2025-04-29 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-31406. -- Resolution: Won't Do The gain from this feature is pretty limited as newer Flink versions all support

Re: [PR] [FLINK-31406] Do not delete jobgraph on scale only last-state upgrades [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
gyfora commented on PR #968: URL: https://github.com/apache/flink-kubernetes-operator/pull/968#issuecomment-2838497510 Based on offline discussions, due to the introduced complexity and the very limited benefit we decided to drop this feature and close this jira for now. -- This is an au

Re: [PR] [FLINK-31406] Do not delete jobgraph on scale only last-state upgrades [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
gyfora closed pull request #968: [FLINK-31406] Do not delete jobgraph on scale only last-state upgrades URL: https://github.com/apache/flink-kubernetes-operator/pull/968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-30571] Estimate scalability coefficient from past scaling history using linear regression [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
gyfora commented on PR #966: URL: https://github.com/apache/flink-kubernetes-operator/pull/966#issuecomment-2838495767 > Thank you @pchoudhury22, this is a great addition! Code looks very clean. @mxm We discussed this with @pchoudhury22 offline a little and came to the conclusion tha

[jira] [Created] (FLINK-37749) FileSystem Connector fails writing to S3 bucket

2025-04-29 Thread Fred Teunissen (Jira)
Fred Teunissen created FLINK-37749: -- Summary: FileSystem Connector fails writing to S3 bucket Key: FLINK-37749 URL: https://issues.apache.org/jira/browse/FLINK-37749 Project: Flink Issue Typ

Re: [PR] [FLINK-33139] Add Prometheus Sink Table API [flink-connector-prometheus]

2025-04-29 Thread via GitHub
darenwkt commented on PR #22: URL: https://github.com/apache/flink-connector-prometheus/pull/22#issuecomment-2838314070 > Thanks for the updates, loving the work to migrate the AWS specific Prometheus behaviour out. I've added additional comments on the updates. Thanks for the review

Re: [PR] [FLINK-33139] Add Prometheus Sink Table API [flink-connector-prometheus]

2025-04-29 Thread via GitHub
darenwkt commented on code in PR #22: URL: https://github.com/apache/flink-connector-prometheus/pull/22#discussion_r2066049547 ## flink-connector-prometheus-request-signer-amp/src/test/java/org/apache/flink/connector/prometheus/sink/aws/AmazonManagedPrometheusWriteRequestSignerFactoryT

Re: [PR] [FLINK-30571] Estimate scalability coefficient from past scaling history using linear regression [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
mxm commented on code in PR #966: URL: https://github.com/apache/flink-kubernetes-operator/pull/966#discussion_r2066005803 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java: ## @@ -236,6 +248,97 @@ public ParallelismChange computeScaleTargetPara

Re: [PR] [FLINK-32097][Connectors/Kinesis] Implement support for Kinesis deaggregation [flink-connector-aws]

2025-04-29 Thread via GitHub
nicusX commented on code in PR #188: URL: https://github.com/apache/flink-connector-aws/pull/188#discussion_r2066006151 ## flink-connector-aws/flink-connector-aws-kinesis-streams/pom.xml: ## @@ -52,6 +60,11 @@ under the License. kinesis + +

Re: [PR] [FLINK-37747][runtime] Use old subtask count for restored committable objects [flink]

2025-04-29 Thread via GitHub
bjlovegithub commented on PR #26518: URL: https://github.com/apache/flink/pull/26518#issuecomment-2838222314 hey @AHeise I updated the PR with extra UT cases to cover scale up/down and no scaling. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Commented] (FLINK-30513) HA storage dir leaks on cluster termination

2025-04-29 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948135#comment-17948135 ] Zhanghao Chen commented on FLINK-30513: --- [~xinchen147] We imlemented this feature

Re: [PR] [BP-3.4.0] Fix environment variable check for FLINK_CDC_HOME in YarnApplicationDeploymentExecutor. [flink-cdc]

2025-04-29 Thread via GitHub
lvyanquan merged PR #4013: URL: https://github.com/apache/flink-cdc/pull/4013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [BP-3.4.0] Fix environment variable check for FLINK_CDC_HOME in YarnApplicationDeploymentExecutor. [flink-cdc]

2025-04-29 Thread via GitHub
lvyanquan commented on PR #4013: URL: https://github.com/apache/flink-cdc/pull/4013#issuecomment-2838129536 The failure case of OceanBaseE2eITCase.testOceanBaseCDC is unrelated to the change here, and is traced in https://issues.apache.org/jira/browse/FLINK-37307. -- This is an automated

[jira] [Commented] (FLINK-37552) Made StateMetaInfo consistent for ForStKeyeStateBackend and ForStSyncKeyeStateBackend.

2025-04-29 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948128#comment-17948128 ] Yue Ma commented on FLINK-37552: [~Zakelly]  I have updated this PR. Can you please help

Re: [PR] [FLINK-37739][cli] fix flink-conf is not obtained in local mode [flink-cdc]

2025-04-29 Thread via GitHub
MOBIN-F commented on code in PR #4006: URL: https://github.com/apache/flink-cdc/pull/4006#discussion_r2065903217 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposer.java: ## @@ -254,4 +251,27 @@ private Optional getContainingJar(Class cl

Re: [PR] [FLINK-37739][cli] fix flink-conf is not obtained in local mode [flink-cdc]

2025-04-29 Thread via GitHub
MOBIN-F commented on code in PR #4006: URL: https://github.com/apache/flink-cdc/pull/4006#discussion_r2065880889 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposer.java: ## @@ -59,32 +60,28 @@ public class FlinkPipelineComposer implemen

Re: [PR] [FLINK-37745] Serialize partial deletes in ChangelogMode to JSON [flink]

2025-04-29 Thread via GitHub
twalthr commented on code in PR #26516: URL: https://github.com/apache/flink/pull/26516#discussion_r2065864255 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ChangelogModeJsonDeserializer.java: ## @@ -49,8 +51,14 @@ public C

Re: [PR] [FLINK-33139] Add Prometheus Sink Table API [flink-connector-prometheus]

2025-04-29 Thread via GitHub
foxus commented on code in PR #22: URL: https://github.com/apache/flink-connector-prometheus/pull/22#discussion_r2065830625 ## flink-connector-prometheus-request-signer-amp/src/test/java/org/apache/flink/connector/prometheus/sink/aws/AmazonManagedPrometheusWriteRequestSignerFactoryTest

Re: [PR] [FLINK-36876] Support external eventLoopGroup for RestClient [flink]

2025-04-29 Thread via GitHub
gyfora commented on PR #25788: URL: https://github.com/apache/flink/pull/25788#issuecomment-2838034219 @chenyuzhi459 can you please rebase on the latest master to retrigger the tests before we merge this? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [FLINK-36876] Add proxy for restClient [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
chenyuzhi459 commented on PR #956: URL: https://github.com/apache/flink-kubernetes-operator/pull/956#issuecomment-2837981756 It depends on when will the pr https://github.com/apache/flink/pull/25788 could be merged. If necessary, I can submit the pr fix in both 1.20 and 2.x versions

Re: [PR] [FLINK-37748][Kubernetes Operator]Remove JDK only JVM arguments from Flink operator Helm chart [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
davidradl commented on code in PR #975: URL: https://github.com/apache/flink-kubernetes-operator/pull/975#discussion_r2065811570 ## helm/flink-kubernetes-operator/conf/flink-conf.yaml: ## @@ -24,8 +24,8 @@ parallelism.default: 1 # These should be kept in-sync with the flink di

Re: [PR] [FLINK-37748][Kubernetes Operator]Remove JDK only JVM arguments from Flink operator Helm chart [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
gyfora commented on PR #975: URL: https://github.com/apache/flink-kubernetes-operator/pull/975#issuecomment-2837962953 Makes sense @ekazakas thanks for the explanation :) Let's try this -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Commented] (FLINK-37747) GlobalCommitterOperator cannot commit after scaling writer/committer

2025-04-29 Thread David (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948068#comment-17948068 ] David commented on FLINK-37747: --- Thanks [~arvid] . We are using FLINK 1.20.1. Could you gi

Re: [PR] [FLINK-37728][python] add support org.apache.flink.table.runtime.operators.window.GlobalWindow [flink]

2025-04-29 Thread via GitHub
HuangXingBo merged PR #26506: URL: https://github.com/apache/flink/pull/26506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-37748][Kubernetes Operator]Remove JDK only JVM arguments from Flink operator Helm chart [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
ekazakas commented on PR #975: URL: https://github.com/apache/flink-kubernetes-operator/pull/975#issuecomment-2837903339 It doesn't make the compatibility better, since Flink jobs do not require compiler modules. In case of very specific applications that for some reason would need to acce

[jira] [Commented] (FLINK-37747) GlobalCommitterOperator cannot commit after scaling writer/committer

2025-04-29 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948051#comment-17948051 ] Arvid Heise commented on FLINK-37747: - Thank you for raising the issue and your deta

Re: [PR] [FLINK-37745] Serialize partial deletes in ChangelogMode to JSON [flink]

2025-04-29 Thread via GitHub
snuyanzin commented on code in PR #26516: URL: https://github.com/apache/flink/pull/26516#discussion_r2065732308 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ChangelogModeJsonDeserializer.java: ## @@ -49,8 +51,14 @@ public

Re: [PR] [FLINK-37745] Serialize partial deletes in ChangelogMode to JSON [flink]

2025-04-29 Thread via GitHub
snuyanzin commented on code in PR #26516: URL: https://github.com/apache/flink/pull/26516#discussion_r2065732308 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ChangelogModeJsonDeserializer.java: ## @@ -49,8 +51,14 @@ public

Re: [PR] Update publish-snapshot workflow actions [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
gyfora merged PR #973: URL: https://github.com/apache/flink-kubernetes-operator/pull/973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] Update publish-snapshot workflow actions [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
kornys commented on PR #973: URL: https://github.com/apache/flink-kubernetes-operator/pull/973#issuecomment-2837842698 GitHub is retiring the old cache service on 1 Feb 2025. -> https://stackoverflow.com/questions/77897660/github-actions-node-js-16-actions-are-deprecated-warning Olde

Re: [PR] [hotfix][python] Add pandas type annotations for TableEnvironment.from_pandas and Table.to_pandas [flink]

2025-04-29 Thread via GitHub
autophagy commented on code in PR #26510: URL: https://github.com/apache/flink/pull/26510#discussion_r2065715763 ## flink-python/docs/conf.py: ## @@ -102,6 +103,11 @@ autosummary_generate = True autodoc_docstring_signature = True +# Map to external docs for type annotations

Re: [PR] [FLINK-30571] Estimate scalability coefficient from past scaling history using linear regression [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
gyfora commented on code in PR #966: URL: https://github.com/apache/flink-kubernetes-operator/pull/966#discussion_r2065705970 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java: ## @@ -236,6 +248,97 @@ public ParallelismChange computeScaleTargetP

[jira] [Resolved] (FLINK-37740) Fix flink-docker snapshots GitHub workflow

2025-04-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-37740. --- Resolution: Fixed master (flink-docker): [6e226503dbb228467905c70ccfb6f33f4c676872|https://

Re: [PR] [FLINK-37740][flink-docker] Fix GitHub snapshots workflow failure [flink-docker]

2025-04-29 Thread via GitHub
XComp commented on PR #224: URL: https://github.com/apache/flink-docker/pull/224#issuecomment-2837781051 I triggered a [test run](https://github.com/apache/flink-docker/actions/runs/14724358848) which went through. Thanks for picking this up, @morazow 👍 -- This is an automated message f

Re: [PR] [FLINK-37740][flink-docker] Fix GitHub snapshots workflow failure [flink-docker]

2025-04-29 Thread via GitHub
morazow commented on PR #224: URL: https://github.com/apache/flink-docker/pull/224#issuecomment-2837806801 Ahh great, no need to wait for schedule, thanks @XComp! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [FLINK-32097][Connectors/Kinesis] Implement support for Kinesis deaggregation [flink-connector-aws]

2025-04-29 Thread via GitHub
dannycranmer commented on code in PR #188: URL: https://github.com/apache/flink-connector-aws/pull/188#discussion_r2065697710 ## flink-connector-aws/flink-connector-aws-kinesis-streams/pom.xml: ## @@ -52,6 +60,11 @@ under the License. kinesis +

Re: [PR] [FLINK-37739][cli] fix flink-conf is not obtained in local mode [flink-cdc]

2025-04-29 Thread via GitHub
joyCurry30 commented on code in PR #4006: URL: https://github.com/apache/flink-cdc/pull/4006#discussion_r2065689400 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposer.java: ## @@ -254,4 +251,27 @@ private Optional getContainingJar(Class

[jira] [Updated] (FLINK-37739) flink-conf is not obtained in local mode

2025-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37739: --- Labels: pull-request-available (was: ) > flink-conf is not obtained in local mode > ---

Re: [PR] [FLINK-37739][cli] fix flink-conf is not obtained in local mode [flink-cdc]

2025-04-29 Thread via GitHub
joyCurry30 commented on code in PR #4006: URL: https://github.com/apache/flink-cdc/pull/4006#discussion_r2065686169 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposer.java: ## @@ -59,32 +60,28 @@ public class FlinkPipelineComposer imple

[PR] [BP-3.4.0] Fix environment variable check for FLINK_CDC_HOME in YarnApplicationDeploymentExecutor. [flink-cdc]

2025-04-29 Thread via GitHub
joyCurry30 opened a new pull request, #4013: URL: https://github.com/apache/flink-cdc/pull/4013 Fix environment variable check for FLINK_CDC_HOME in YarnApplicationDeploymentExecutor. (#4012) (cherry picked from commit ceffbc0ea1a223bb2a81bd63c507be5978dee7f3) -- This is an automa

Re: [PR] [FLINK-37748][Kubernetes Operator]Remove JDK only JVM arguments from Flink operator Helm chart [flink-kubernetes-operator]

2025-04-29 Thread via GitHub
gyfora commented on PR #975: URL: https://github.com/apache/flink-kubernetes-operator/pull/975#issuecomment-2837732076 > > These were added to improve java 17 compatibility for Flink apps, will this affect that? If so having the warnings doesn't seem like a big deal > > It should not

Re: [PR] [hotfix] Fix environment variable check for FLINK_CDC_HOME in YarnApplicationDeploymentExecutor. [flink-cdc]

2025-04-29 Thread via GitHub
lvyanquan merged PR #4012: URL: https://github.com/apache/flink-cdc/pull/4012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a