nicusX commented on code in PR #188:
URL:
https://github.com/apache/flink-connector-aws/pull/188#discussion_r2066006151
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/pom.xml:
##########
@@ -52,6 +60,11 @@ under the License.
<artifactId>kinesis</artifactId>
</dependency>
+ <dependency>
+ <groupId>software.amazon.kinesis</groupId>
+ <artifactId>amazon-kinesis-client</artifactId>
Review Comment:
@dannycranmer `KinesisClientRecord` has some transitive dependencies.
However, the KCL can be substantially lightened removing most of transitive
dependencies
See [this
example](https://github.com/aws-samples/amazon-managed-service-for-apache-flink-examples/blob/5e4873883c64c28484261125b3a2e20df3455c84/java/KinesisSourceDeaggregation/flink-app/pom.xml#L85)
which is an alternative solution, implementing de-aggregation in the
Deserialization Schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
