joyCurry30 commented on code in PR #4006:
URL: https://github.com/apache/flink-cdc/pull/4006#discussion_r2065686169
##########
flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposer.java:
##########
@@ -59,32 +60,28 @@ public class FlinkPipelineComposer implements
PipelineComposer {
public static FlinkPipelineComposer ofRemoteCluster(
org.apache.flink.configuration.Configuration flinkConfig,
List<Path> additionalJars) {
StreamExecutionEnvironment env = new
StreamExecutionEnvironment(flinkConfig);
- additionalJars.forEach(
- jarPath -> {
- try {
- FlinkEnvironmentUtils.addJar(
- env,
-
jarPath.makeQualified(jarPath.getFileSystem()).toUri().toURL());
- } catch (Exception e) {
- throw new RuntimeException(
- String.format(
- "Unable to convert JAR path \"%s\" to
URL when adding JAR to Flink environment",
- jarPath),
- e);
- }
- });
+ addAdditionalJars(env, additionalJars);
return new FlinkPipelineComposer(env, false);
}
public static FlinkPipelineComposer
ofApplicationCluster(StreamExecutionEnvironment env) {
return new FlinkPipelineComposer(env, false);
}
+ @VisibleForTesting
public static FlinkPipelineComposer ofMiniCluster() {
return new FlinkPipelineComposer(
StreamExecutionEnvironment.getExecutionEnvironment(), true);
}
Review Comment:
Is it still necessary to keep this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
