snuyanzin commented on code in PR #26516:
URL: https://github.com/apache/flink/pull/26516#discussion_r2065732308
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ChangelogModeJsonDeserializer.java:
##########
@@ -49,8 +51,14 @@ public ChangelogMode deserialize(
ChangelogMode.Builder builder = ChangelogMode.newBuilder();
JsonNode rowKindsNode = jsonParser.readValueAsTree();
for (JsonNode rowKindNode : rowKindsNode) {
- RowKind rowKind =
RowKind.valueOf(rowKindNode.asText().toUpperCase());
- builder.addContainedKind(rowKind);
+ final String rowKindText = rowKindNode.asText().toUpperCase();
Review Comment:
```suggestion
final String rowKindText =
rowKindNode.asText().toUpperCase(Locale.ROOT);
```
what values are planned to be there, should we care. about something tricky
e.g. turkish locales?
i guess only enum values, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
