beliefer opened a new pull request, #25836:
URL: https://github.com/apache/flink/pull/25836
## What is the purpose of the change
This PR propose to rename `PunctuatedWatermarkStrategyWrapper` with
`PunctuatedWatermarkAssignerWrapper`.
## Brief change log
Rename Punct
flinkbot commented on PR #25836:
URL: https://github.com/apache/flink/pull/25836#issuecomment-2557993125
## CI report:
* ef3f9b1ccbcd7caed872a2aa827a76a3b7b92403 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
RocMarshal commented on PR #25800:
URL: https://github.com/apache/flink/pull/25800#issuecomment-2557992989
hi, @wuchong Could you help take a look it if you had the free time ?
Many thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
flinkbot commented on PR #25835:
URL: https://github.com/apache/flink/pull/25835#issuecomment-2557962119
## CI report:
* 8ce6f8cc3582de3d86bbe4f8111873b9ea530d2b UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
beliefer opened a new pull request, #25835:
URL: https://github.com/apache/flink/pull/25835
## What is the purpose of the change
This PR propose to deprecated StreamSink and SinkOperator.
## Brief change log
Add the annotation Deprecated for StreamSink and SinkOperator.
yiyutian1 commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1894521745
##
flink-python/pyflink/table/tests/test_expression.py:
##
@@ -299,6 +299,10 @@ def test_expressions(self):
lit(2).hours)))
sel
yiyutian1 commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1894520087
##
docs/data/sql_functions.yml:
##
@@ -642,7 +642,10 @@ temporal:
description: Returns TRUE if two time intervals defined by (timepoint1,
temporal1) and (timepo
lihaosky commented on PR #25834:
URL: https://github.com/apache/flink/pull/25834#issuecomment-2557775590
```
2024-12-20T21:31:47.4797792Z Dec 20 21:31:47 21:31:47.478 [INFO] Running
org.apache.flink.table.planner.plan.rules.physical.stream.WatermarkAssignerChangelogNormalizeTransposeRuleT
piotrp commented on code in PR #25813:
URL: https://github.com/apache/flink/pull/25813#discussion_r1894392968
##
flink-core/src/main/java/org/apache/flink/util/MdcUtils.java:
##
@@ -45,7 +45,13 @@ public class MdcUtils {
public static MdcCloseable withContext(Map context) {
piotrp commented on code in PR #25813:
URL: https://github.com/apache/flink/pull/25813#discussion_r1894357267
##
flink-core/pom.xml:
##
@@ -180,6 +180,13 @@ under the License.
test
+
Review Comment:
Done.
I had
afedulov commented on PR #25833:
URL: https://github.com/apache/flink/pull/25833#issuecomment-2557638919
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
snuyanzin commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1894341087
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java:
##
@@ -1026,20 +1026,86 @@ void createTemporarySystemFunction(
snuyanzin commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1894341087
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java:
##
@@ -1026,20 +1026,86 @@ void createTemporarySystemFunction(
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894308435
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894308435
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894146265
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
snuyanzin commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1894272407
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##
@@ -1297,30 +1303,42 @@ public void dropMaterializedTable(
snuyanzin commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1894272407
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##
@@ -1297,30 +1303,42 @@ public void dropMaterializedTable(
flinkbot commented on PR #25834:
URL: https://github.com/apache/flink/pull/25834#issuecomment-2557561234
## CI report:
* 6dc5c1d2edf86c4470afedc6032f298cfaef9f96 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-35014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-35014:
---
Labels: pull-request-available (was: )
> SqlNode to operation conversion for models
> -
snuyanzin commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1894272407
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##
@@ -1297,30 +1303,42 @@ public void dropMaterializedTable(
lihaosky commented on PR #25834:
URL: https://github.com/apache/flink/pull/25834#issuecomment-2557553713
cc @twalthr to review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
lihaosky opened a new pull request, #25834:
URL: https://github.com/apache/flink/pull/25834
## What is the purpose of the change
Add `SqlNode` to `SqlOperation` conversion for models
## Brief change log
* Support Model CRUD node to operation conversion
snuyanzin commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1894272407
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##
@@ -1297,30 +1303,42 @@ public void dropMaterializedTable(
afedulov commented on code in PR #25656:
URL: https://github.com/apache/flink/pull/25656#discussion_r1894239482
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##
@@ -1029,6 +1029,11 @@ private TableResultInternal
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894146265
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
ferenc-csaky commented on PR #54:
URL:
https://github.com/apache/flink-connector-hbase/pull/54#issuecomment-2557428849
Hi, thanks for your contribution! I am planning to try to include at least
JDK 17 (and possibly 21) support for the next release, which will require to
bump HBase version
[
https://issues.apache.org/jira/browse/FLINK-36923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Csaky updated FLINK-36923:
-
Affects Version/s: (was: hbase-4.1.0)
> Bump flink-connector-hbase to Flink 1.20
> -
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894201016
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-36923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Csaky updated FLINK-36923:
-
Fix Version/s: hbase-4.1.0
> Bump flink-connector-hbase to Flink 1.20
>
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894146265
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
snuyanzin commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894179515
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
snuyanzin commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894179515
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
flinkbot commented on PR #25833:
URL: https://github.com/apache/flink/pull/25833#issuecomment-2557386028
## CI report:
* c8f3c26629996819cea131ef8cf11526e6b98369 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
afedulov commented on PR #25833:
URL: https://github.com/apache/flink/pull/25833#issuecomment-2557385736
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
afedulov opened a new pull request, #25833:
URL: https://github.com/apache/flink/pull/25833
Unmodified backport of https://github.com/apache/flink/pull/23439 to 1.20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894166214
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894166214
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894166214
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894166214
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894146265
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894146265
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894146265
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
davidradl commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894143500
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
davidradl commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1894138335
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##
@@ -1297,30 +1303,42 @@ public void dropMaterializedTable(
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894140247
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java:
##
@@ -804,4 +813,163 @@ private Stream floorTestC
davidradl commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1894138335
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##
@@ -1297,30 +1303,42 @@ public void dropMaterializedTable(
snuyanzin commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894130094
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
snuyanzin commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894130094
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
davidradl commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1894119512
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java:
##
@@ -1026,20 +1026,86 @@ void createTemporarySystemFunction(
hanyuzheng7 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894127361
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed
afedulov commented on code in PR #25813:
URL: https://github.com/apache/flink/pull/25813#discussion_r1894125426
##
flink-core/pom.xml:
##
@@ -180,6 +180,13 @@ under the License.
test
+
Review Comment:
Mockito is inten
davidradl commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1894119512
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java:
##
@@ -1026,20 +1026,86 @@ void createTemporarySystemFunction(
davidradl commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1894119512
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java:
##
@@ -1026,20 +1026,86 @@ void createTemporarySystemFunction(
afedulov commented on PR #25813:
URL: https://github.com/apache/flink/pull/25813#issuecomment-2557293147
@piotrp thanks for the contribution. Please consider that usage of Mockito
in Flink is generally discouraged:
https://flink.apache.org/how-to-contribute/code-style-and-quality-common/
davidradl commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1894119512
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java:
##
@@ -1026,20 +1026,86 @@ void createTemporarySystemFunction(
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894119140
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Expressions.java:
##
@@ -366,6 +366,61 @@ public static ApiExpression toTimestampLtz(Obje
[
https://issues.apache.org/jira/browse/FLINK-36931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonard Xu reassigned FLINK-36931:
--
Assignee: Wenkai Qi
> FlinkCDC YAML supports synchronizing the full amount of data of the ent
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894092145
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java:
##
@@ -804,4 +813,163 @@ private Stream floorTestC
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894106052
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894092145
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java:
##
@@ -804,4 +813,163 @@ private Stream floorTestC
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1894092145
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java:
##
@@ -804,4 +813,163 @@ private Stream floorTestC
piotrp commented on PR #25813:
URL: https://github.com/apache/flink/pull/25813#issuecomment-2557159727
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
davidradl commented on PR #25815:
URL: https://github.com/apache/flink/pull/25815#issuecomment-2557154359
Reviewed by Chi on 19/12/2024 Go back to the submitter with review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
piotrp commented on PR #25813:
URL: https://github.com/apache/flink/pull/25813#issuecomment-2557151894
CI fixed, it was chekstyle complaining about Mockito
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
davidradl commented on code in PR #25815:
URL: https://github.com/apache/flink/pull/25815#discussion_r1894022766
##
flink-runtime/src/test/java/org/apache/flink/streaming/util/KeyedTwoInputStreamOperatorTestHarness.java:
##
@@ -64,8 +67,24 @@ public KeyedTwoInputStreamOperatorTe
davidradl commented on code in PR #25815:
URL: https://github.com/apache/flink/pull/25815#discussion_r1894022766
##
flink-runtime/src/test/java/org/apache/flink/streaming/util/KeyedTwoInputStreamOperatorTestHarness.java:
##
@@ -64,8 +67,24 @@ public KeyedTwoInputStreamOperatorTe
davidradl commented on code in PR #25815:
URL: https://github.com/apache/flink/pull/25815#discussion_r1894022766
##
flink-runtime/src/test/java/org/apache/flink/streaming/util/KeyedTwoInputStreamOperatorTestHarness.java:
##
@@ -64,8 +67,24 @@ public KeyedTwoInputStreamOperatorTe
davidradl commented on code in PR #25815:
URL: https://github.com/apache/flink/pull/25815#discussion_r1894022766
##
flink-runtime/src/test/java/org/apache/flink/streaming/util/KeyedTwoInputStreamOperatorTestHarness.java:
##
@@ -64,8 +67,24 @@ public KeyedTwoInputStreamOperatorTe
snuyanzin commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1894021871
##
docs/data/sql_functions.yml:
##
@@ -642,7 +642,10 @@ temporal:
description: Returns TRUE if two time intervals defined by (timepoint1,
temporal1) and (timepo
snuyanzin commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1894021871
##
docs/data/sql_functions.yml:
##
@@ -642,7 +642,10 @@ temporal:
description: Returns TRUE if two time intervals defined by (timepoint1,
temporal1) and (timepo
hanyuzheng7 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1893365985
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed
davidradl commented on code in PR #25815:
URL: https://github.com/apache/flink/pull/25815#discussion_r1894013315
##
flink-runtime/src/main/java/org/apache/flink/runtime/state/v2/ListStateDescriptor.java:
##
@@ -40,6 +41,16 @@ public ListStateDescriptor(String stateId,
TypeInfor
piotrp commented on code in PR #25813:
URL: https://github.com/apache/flink/pull/25813#discussion_r1894011657
##
flink-core/src/test/java/org/apache/flink/util/MdcUtilsTest.java:
##
@@ -50,6 +56,19 @@ class MdcUtilsTest {
public final LoggerAuditingExtension loggerExtension
davidradl commented on PR #25814:
URL: https://github.com/apache/flink/pull/25814#issuecomment-2557125563
Reviewed by Chi on 19/12/2024 Go back to the submitter with review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
davidradl commented on PR #25814:
URL: https://github.com/apache/flink/pull/25814#issuecomment-2557125131
> > CI failing Is the Jira issue correct - it says : File not found
exception on restoring state handles with file merging Does this relate to this?
>
> Jira's address can be foun
davidradl commented on PR #25813:
URL: https://github.com/apache/flink/pull/25813#issuecomment-2557118755
CI failing
Reviewed by Chi on 19/12/2024 Go back to the submitter with review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
davidradl commented on code in PR #25813:
URL: https://github.com/apache/flink/pull/25813#discussion_r1894005895
##
flink-core/src/test/java/org/apache/flink/util/MdcUtilsTest.java:
##
@@ -50,6 +56,19 @@ class MdcUtilsTest {
public final LoggerAuditingExtension loggerExtens
davidradl commented on PR #25809:
URL: https://github.com/apache/flink/pull/25809#issuecomment-2557113161
Reviewed by Chi on 19/12/2024 Approve - looking for committer to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
afedulov commented on PR #25794:
URL: https://github.com/apache/flink/pull/25794#issuecomment-2557111034
If I understand correctly that the version upgrade is mainly
vulnarabilities-related (please update the
https://issues.apache.org/jira/browse/FLINK-36739 with the description), should
w
davidradl commented on PR #25807:
URL: https://github.com/apache/flink/pull/25807#issuecomment-2557109020
Reviewed by Chi on 19/12/2024 Go back to the submitter with review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
davidradl commented on code in PR #25807:
URL: https://github.com/apache/flink/pull/25807#discussion_r1893999727
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecTemporalSort.java:
##
@@ -119,9 +123,11 @@ protected
davidradl commented on PR #25806:
URL: https://github.com/apache/flink/pull/25806#issuecomment-2557103817
CI still failing
Reviewed by Chi on 19/12/2024 Need a committer to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
davidradl commented on PR #25804:
URL: https://github.com/apache/flink/pull/25804#issuecomment-2557099519
CI failing.
Reviewed by Chi on 19/12/2024 Need a committer to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
davidradl commented on PR #25800:
URL: https://github.com/apache/flink/pull/25800#issuecomment-2557095942
Reviewed by Chi on 19/12/2024 Approve - looking for committer to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
davidradl commented on code in PR #25800:
URL: https://github.com/apache/flink/pull/25800#discussion_r1893990065
##
flink-core/src/test/java/org/apache/flink/configuration/TaskManagerLoadBalanceModeTest.java:
##
@@ -1,49 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation
nictownsend commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1893987970
##
docs/data/sql_functions.yml:
##
@@ -642,7 +642,10 @@ temporal:
description: Returns TRUE if two time intervals defined by (timepoint1,
temporal1) and (time
davidradl commented on PR #25799:
URL: https://github.com/apache/flink/pull/25799#issuecomment-2557090758
Reviewed by Chi on 19/12/2024 Go back to the submitter with review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
davidradl commented on PR #25798:
URL: https://github.com/apache/flink/pull/25798#issuecomment-2557090078
Reviewed by Chi on 19/12/2024 Go back to the submitter with review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
hanyuzheng7 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1893365985
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed
davidradl commented on code in PR #25798:
URL: https://github.com/apache/flink/pull/25798#discussion_r1893986452
##
flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/jsonplan/StreamGraphJsonSchema.java:
##
@@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Software Fou
davidradl commented on PR #25797:
URL: https://github.com/apache/flink/pull/25797#issuecomment-2557081806
Reviewed by Chi on 19/12/2024 Go back to the submitter with review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
davidradl commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1893979290
##
docs/data/sql_functions.yml:
##
@@ -642,7 +642,10 @@ temporal:
description: Returns TRUE if two time intervals defined by (timepoint1,
temporal1) and (timepo
davidradl commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1893977637
##
flink-python/pyflink/table/tests/test_expression.py:
##
@@ -299,6 +299,10 @@ def test_expressions(self):
lit(2).hours)))
sel
davidradl commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1893975529
##
docs/data/sql_functions.yml:
##
@@ -642,7 +642,10 @@ temporal:
description: Returns TRUE if two time intervals defined by (timepoint1,
temporal1) and (timepo
davidradl commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1893960744
##
flink-python/pyflink/table/expressions.py:
##
@@ -350,14 +350,19 @@ def temporal_overlaps(left_time_point,
def date_format(timestamp, format) -> Expression:
nictownsend commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1893958758
##
docs/data/sql_functions.yml:
##
@@ -642,7 +642,10 @@ temporal:
description: Returns TRUE if two time intervals defined by (timepoint1,
temporal1) and (time
davidradl commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1893959599
##
flink-python/pyflink/table/expressions.py:
##
@@ -350,14 +350,19 @@ def temporal_overlaps(left_time_point,
def date_format(timestamp, format) -> Expression:
[
https://issues.apache.org/jira/browse/FLINK-36770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-36770:
---
Labels: pull-request-available (was: )
> Support Request Timeout for AWS sinks
> --
vahmed-hamdy opened a new pull request, #186:
URL: https://github.com/apache/flink-connector-aws/pull/186
## Purpose of the change
- Move `submitRequestEntries` implementation for AWS sinks to use
`ResultHandler`
- Bump flink version to 1.20
- Adapt pipelines
1 - 100 of 196 matches
Mail list logo