afedulov commented on code in PR #25656:
URL: https://github.com/apache/flink/pull/25656#discussion_r1894239482


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -1029,6 +1029,11 @@ private TableResultInternal executeInternal(
                         defaultJobName,
                         jobStatusHookList);
         try {
+            // Current context class loader here is the application class 
loader.

Review Comment:
   @ammu20-dev @davidradl @seb-pereira 
   This modifies a pretty critical execution path. How confident are we that it 
doesn't introduce regressions? Specifically, could any existing 
functionality—such as built-in serializers for various connector formats—break 
if libraries are inadvertently loaded from user JARs instead of Flink's parent 
class loader?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to