snuyanzin commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1894021871
##########
docs/data/sql_functions.yml:
##########
@@ -642,7 +642,10 @@ temporal:
description: Returns TRUE if two time intervals defined by (timepoint1,
temporal1) and (timepoint2, temporal2) overlap. The temporal values could be
either a time point or a time interval. E.g., (TIME '2:55:00', INTERVAL '1'
HOUR) OVERLAPS (TIME '3:30:00', INTERVAL '2' HOUR) returns TRUE; (TIME
'9:00:00', TIME '10:00:00') OVERLAPS (TIME '10:15:00', INTERVAL '3' HOUR)
returns FALSE.
- sql: DATE_FORMAT(timestamp, string)
table: dateFormat(TIMESTAMP, STRING)
- description: Converts timestamp to a value of string in the format
specified by the date format string. The format string is compatible with
Java's SimpleDateFormat.
+ description: Converts timestamp to a value of string in the format
specified by the date format string. The format string is compatible with
Java's DateTimeFormatter.
+ - sql: DATE_FORMAT(string, string)
+ table: dateFormat(STRING, STRING)
+ description: Re-format a timestamp string to another string, using a
custom format. The format string is compatible with Java's SimpleDateFormat.
Review Comment:
I have a slightly different thought
Since it is Flink 2.0 and anyway it brings some breaking changes. May be we
can completely switch to DateTimeFormatter in 2.0 while for 1.19 and 1.20 we
just fix documentation.
However this option requires a discussion in ML
i can start one if no objections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
