Re: [PR] [FLINK-34111][table] Add support for json_quote, json_unquote, address PR feedback #24156 [flink]

2024-07-10 Thread via GitHub
anupamaggarwal commented on code in PR #24967: URL: https://github.com/apache/flink/pull/24967#discussion_r1673409493 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/JsonUnquoteFunction.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed

Re: [PR] [FLINK-31215] [autoscaler] Backpropagate processing rate limits from non-scalable bottlenecks to upstream operators [flink-kubernetes-operator]

2024-07-10 Thread via GitHub
gyfora commented on PR #847: URL: https://github.com/apache/flink-kubernetes-operator/pull/847#issuecomment-163270 > Hi, @mxm, @gyfora. I rewrote the code for the processing rate backpropagation. Unfortunately, backpropagation results depend on the vertices order during backpropagation

Re: [PR] [FLINK-35717][table] Allow defining partition keys and table distribution in CREATE TABLE AS (CTAS) [flink]

2024-07-10 Thread via GitHub
twalthr commented on PR #24993: URL: https://github.com/apache/flink/pull/24993#issuecomment-18 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-35749] Kafka sink component will lose data when kafka cluster is unavailable for a while [flink-connector-kafka]

2024-07-10 Thread via GitHub
AHeise commented on PR #107: URL: https://github.com/apache/flink-connector-kafka/pull/107#issuecomment-142699 > > At this point, we just try to get the build green. You can check locally by running `mvn verify`. > > checked, should be green now. Retriggering CI. -- Thi

[jira] [Commented] (FLINK-35004) SqlGatewayE2ECase could not start container

2024-07-10 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864922#comment-17864922 ] Rui Fan commented on FLINK-35004: - https://dev.azure.com/apache-flink/apache-flink/_buil

[jira] [Created] (FLINK-35810) AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUnorderedWithRetry fails

2024-07-10 Thread Rui Fan (Jira)
Rui Fan created FLINK-35810: --- Summary: AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUnorderedWithRetry fails Key: FLINK-35810 URL: https://issues.apache.org/jira/browse/FLINK-35810 Project: Flink

Re: [PR] [AZP-Trigger] Fixing two issues about checkpoint file-merging [flink]

2024-07-10 Thread via GitHub
Zakelly closed pull request #25071: [AZP-Trigger] Fixing two issues about checkpoint file-merging URL: https://github.com/apache/flink/pull/25071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-33672) Use MapState.entries() instead of keys() and get() in over window

2024-07-10 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864917#comment-17864917 ] Zakelly Lan commented on FLINK-33672: - I haven't done any perf on this. :D > Use Ma

Re: [PR] [FLINK-35805][transform] Add `__op_type__` metadata column [flink-cdc]

2024-07-10 Thread via GitHub
lvyanquan commented on code in PR #3468: URL: https://github.com/apache/flink-cdc/pull/3468#discussion_r1673449557 ## flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposerITCase.java: ## @@ -335,6 +337,65 @@ void testTransform(ValuesDataSink.

Re: [PR] [FLINK-35801] Fix SnapshotFileMergingCompatibilityITCase, wait for file deletion before quit [flink]

2024-07-10 Thread via GitHub
Zakelly commented on PR #25066: URL: https://github.com/apache/flink/pull/25066#issuecomment-088556 I have run the test with the last commit for 200 times. No failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [meta] Add automated PR governance workflows [flink-cdc]

2024-07-10 Thread via GitHub
yuxiqian commented on PR #3466: URL: https://github.com/apache/flink-cdc/pull/3466#issuecomment-055928 Tested in my forked repo, and reviewer auto-assigning & PR progress tagging features work as expected. Looking forward to @GOODBOY008 @leonardBang's thoughts. -- This is an au

Re: [PR] [FLINK-34111][table] Add support for json_quote, json_unquote, address PR feedback #24156 [flink]

2024-07-10 Thread via GitHub
anupamaggarwal commented on code in PR #24967: URL: https://github.com/apache/flink/pull/24967#discussion_r1673409493 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/JsonUnquoteFunction.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

2024-07-10 Thread via GitHub
kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1673394381 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManage

Re: [PR] [FLINK-31215] [autoscaler] Backpropagate processing rate limits from non-scalable bottlenecks to upstream operators [flink-kubernetes-operator]

2024-07-10 Thread via GitHub
aplyusnin commented on PR #847: URL: https://github.com/apache/flink-kubernetes-operator/pull/847#issuecomment-003461 Hi, @mxm, @gyfora. I rewrote the code for the processing rate backpropagation. Unfortunately, backpropagation results depend on the vertices order during backpropagatio

[jira] [Assigned] (FLINK-20628) Port RabbitMQ Sources to FLIP-27 API

2024-07-10 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-20628: --- Assignee: (was: RocMarshal) > Port RabbitMQ Sources to FLIP-27 API > --

Re: [PR] [FLINK-35749] Kafka sink component will lose data when kafka cluster is unavailable for a while [flink-connector-kafka]

2024-07-10 Thread via GitHub
JimmyZZZ commented on PR #107: URL: https://github.com/apache/flink-connector-kafka/pull/107#issuecomment-2221950554 > At this point, we just try to get the build green. You can check locally by running `mvn verify`. checked, should be green now. -- This is an automated message f

[PR] [FLINK-35749] Kafka sink component will lose data when kafka cluster is unavailable for a while [flink-connector-kafka]

2024-07-10 Thread via GitHub
JimmyZZZ opened a new pull request, #107: URL: https://github.com/apache/flink-connector-kafka/pull/107 ## What is the purpose of the change Fix the bug for losing data during kafka cluster is unavailable for a while. The related issue: https://issues.apache.org/jira/browse/FLINK-35

Re: [PR] [FLINK-35749] Kafka sink component will lose data when kafka cluster is unavailable for a while [flink-connector-kafka]

2024-07-10 Thread via GitHub
JimmyZZZ closed pull request #107: [FLINK-35749] Kafka sink component will lose data when kafka cluster is unavailable for a while URL: https://github.com/apache/flink-connector-kafka/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Commented] (FLINK-35754) SqlGatewayE2ECase.testMaterializedTableInFullMode failed due to Internal Server Error

2024-07-10 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864884#comment-17864884 ] Feng Jin commented on FLINK-35754: -- I submitted the backport pr  [https://github.com/ap

Re: [PR] [BP-1.20][FLINK-35754][e2e] Fix SqlGatewayE2ECase.testMaterializedTableInFullMode failed due to Internal Server Error [flink]

2024-07-10 Thread via GitHub
flinkbot commented on PR #25073: URL: https://github.com/apache/flink/pull/25073#issuecomment-2221901401 ## CI report: * db07a5a7d16ebb7a702c12e14fb45000950ca539 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35801] Fix SnapshotFileMergingCompatibilityITCase, wait for file deletion before quit [flink]

2024-07-10 Thread via GitHub
Zakelly commented on PR #25066: URL: https://github.com/apache/flink/pull/25066#issuecomment-2221899392 I don't think the CI failure is related with file-merging. It happens when file-merging is disabled. I'm investigating the potential file leak. -- This is an automated message from the

Re: [PR] [FLINK-12450] Add leftshift, rightshift functions support in Table API and SQL [flink]

2024-07-10 Thread via GitHub
superdiaodiao commented on PR #25053: URL: https://github.com/apache/flink/pull/25053#issuecomment-2221897499 > Thanks for the review, @superdiaodiao. Updated the PR to fix the tests. You're welcome! ^_^ I left some suggestion just now, please take a look. -- This is an automated

Re: [PR] [FLINK-12450] Add leftshift, rightshift functions support in Table API and SQL [flink]

2024-07-10 Thread via GitHub
superdiaodiao commented on code in PR #25053: URL: https://github.com/apache/flink/pull/25053#discussion_r1673325921 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/BitLeftShiftFunction.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed t

Re: [PR] [FLINK-12450] Add leftshift, rightshift functions support in Table API and SQL [flink]

2024-07-10 Thread via GitHub
superdiaodiao commented on code in PR #25053: URL: https://github.com/apache/flink/pull/25053#discussion_r1673323514 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/BitLeftShiftFunction.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed t

Re: [PR] [FLINK-12450] Add leftshift, rightshift functions support in Table API and SQL [flink]

2024-07-10 Thread via GitHub
superdiaodiao commented on code in PR #25053: URL: https://github.com/apache/flink/pull/25053#discussion_r1673320514 ## docs/data/sql_functions_zh.yml: ## @@ -302,7 +302,13 @@ arithmetic: 返回截取 integer2 位小数的数字。如果 numeric1 或 integer2 为 `NULL`,则返回 `NULL`。 如果 integer2

[jira] [Commented] (FLINK-35782) Flink connector jdbc works wrong when using sql gateway

2024-07-10 Thread Yi Cai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864877#comment-17864877 ] Yi Cai commented on FLINK-35782: mysql-connector-j-8.0.33.jar is mysql jdbc driver, all

[PR] [BP-1.20][FLINK-35754][e2e] Fix SqlGatewayE2ECase.testMaterializedTableInFullMode failed due to Internal Server Error [flink]

2024-07-10 Thread via GitHub
hackergin opened a new pull request, #25073: URL: https://github.com/apache/flink/pull/25073 BP https://github.com/apache/flink/pull/25029 ## What is the purpose of the change *Fix unstable testMaterializedTableInFullMode test case* ## Brief change log - *Fix

[jira] [Commented] (FLINK-35803) ResumeCheckpointManuallyITCase fails with checkpoint file merging

2024-07-10 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864874#comment-17864874 ] Zakelly Lan commented on FLINK-35803: - Merged into master via: 2cad54846510db63254c5

[jira] [Resolved] (FLINK-35803) ResumeCheckpointManuallyITCase fails with checkpoint file merging

2024-07-10 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-35803. - Fix Version/s: 1.20.0 Resolution: Fixed > ResumeCheckpointManuallyITCase fails with check

[jira] [Updated] (FLINK-35803) ResumeCheckpointManuallyITCase fails with checkpoint file merging

2024-07-10 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-35803: Fix Version/s: 2.0.0 > ResumeCheckpointManuallyITCase fails with checkpoint file merging > ---

Re: [PR] [BP-1.20][FLINK-35803][checkpoint] Fix the wrong file reuse in cp file-merging [flink]

2024-07-10 Thread via GitHub
Zakelly merged PR #25070: URL: https://github.com/apache/flink/pull/25070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-35803][checkpoint] Fix the wrong file reuse in cp file-merging [flink]

2024-07-10 Thread via GitHub
Zakelly merged PR #25069: URL: https://github.com/apache/flink/pull/25069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Created] (FLINK-35809) Deploying Flink History Server and Flink SQL Gateway via Flink Operator.

2024-07-10 Thread Jira
钟洋洋 created FLINK-35809: --- Summary: Deploying Flink History Server and Flink SQL Gateway via Flink Operator. Key: FLINK-35809 URL: https://issues.apache.org/jira/browse/FLINK-35809 Project: Flink Issue

Re: [PR] [AZP-Trigger] Fixing two issues about checkpoint file-merging [flink]

2024-07-10 Thread via GitHub
Zakelly commented on PR #25071: URL: https://github.com/apache/flink/pull/25071#issuecomment-2221864778 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-35782) Flink connector jdbc works wrong when using sql gateway

2024-07-10 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864865#comment-17864865 ] xuyang commented on FLINK-35782: Hi, [~caiyi]. SqlGateway does not provide a driver by d

Re: [PR] [meta] Add PR auto-assign bot [flink-cdc]

2024-07-10 Thread via GitHub
lvyanquan commented on PR #3466: URL: https://github.com/apache/flink-cdc/pull/3466#issuecomment-2221829575 Further more, can you add approve label to help PR reviewing? https://github.com/apache/seatunnel/blob/5bf6f7892a65ed26ef0bee3d6e21638bd7cab37b/.github/workflows/approve-label.yml#L4

[jira] [Commented] (FLINK-35754) SqlGatewayE2ECase.testMaterializedTableInFullMode failed due to Internal Server Error

2024-07-10 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864854#comment-17864854 ] dalongliu commented on FLINK-35754: --- [~hackergin] Can you help backport it to release-

[jira] [Commented] (FLINK-35754) SqlGatewayE2ECase.testMaterializedTableInFullMode failed due to Internal Server Error

2024-07-10 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864853#comment-17864853 ] dalongliu commented on FLINK-35754: --- Merged in master: d04c70fae033bb04ed7a3bb69832be5

Re: [PR] [FLINK-35754][e2e] Fix SqlGatewayE2ECase.testMaterializedTableInFullMode failed due to Internal Server Error [flink]

2024-07-10 Thread via GitHub
lsyldliu merged PR #25029: URL: https://github.com/apache/flink/pull/25029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-35090][cdc][doris] Add database auto-creating support for Doris sink pipeline connector [flink-cdc]

2024-07-10 Thread via GitHub
yuxiqian commented on PR #3222: URL: https://github.com/apache/flink-cdc/pull/3222#issuecomment-2221802936 Closing this for now since it has been implemented in https://github.com/apache/doris-flink-connector/pull/408. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] [FLINK-35090][cdc][doris] Add database auto-creating support for Doris sink pipeline connector [flink-cdc]

2024-07-10 Thread via GitHub
yuxiqian closed pull request #3222: [FLINK-35090][cdc][doris] Add database auto-creating support for Doris sink pipeline connector URL: https://github.com/apache/flink-cdc/pull/3222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-35072][cdc][doris] Support applying compatible `AlterColumnTypeEvent` to Doris sink [flink-cdc]

2024-07-10 Thread via GitHub
yuxiqian commented on PR #3215: URL: https://github.com/apache/flink-cdc/pull/3215#issuecomment-2221802439 Since it has been implemented in https://github.com/apache/doris-flink-connector/pull/408, I'll close it for now and bump dependency version to address this after Doris Flink connector

Re: [PR] [FLINK-35072][cdc][doris] Support applying compatible `AlterColumnTypeEvent` to Doris sink [flink-cdc]

2024-07-10 Thread via GitHub
yuxiqian closed pull request #3215: [FLINK-35072][cdc][doris] Support applying compatible `AlterColumnTypeEvent` to Doris sink URL: https://github.com/apache/flink-cdc/pull/3215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-35799] Add CompiledPlan annotations to BatchExecCalc [flink]

2024-07-10 Thread via GitHub
jnh5y commented on PR #25064: URL: https://github.com/apache/flink/pull/25064#issuecomment-2221656321 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (FLINK-35808) Let ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG be overridable by user in KafkaSourceBuilder

2024-07-10 Thread Kevin Lam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Lam updated FLINK-35808: -- Description: This issue is a follow-up to [this mailing list discussion|https://lists.apache.org/thre

[jira] [Updated] (FLINK-35808) Let ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG be overridable by user in KafkaSourceBuilder

2024-07-10 Thread Kevin Lam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Lam updated FLINK-35808: -- Description: This issue is a follow-up to [this mailing list discussion|https://lists.apache.org/thre

[jira] [Updated] (FLINK-35808) Let ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG be overridable by user in KafkaSourceBuilder

2024-07-10 Thread Kevin Lam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Lam updated FLINK-35808: -- Description: This issue is a follow-up to [this mailing list discussion|https://lists.apache.org/thre

[jira] [Updated] (FLINK-35808) Let ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG be overridable by user in KafkaSourceBuilder

2024-07-10 Thread Kevin Lam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Lam updated FLINK-35808: -- Description: This issue is a follow-up to [this mailing list discussion|https://lists.apache.org/thre

[jira] [Created] (FLINK-35808) Let ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG be overridable by user in KafkaSourceBuilder

2024-07-10 Thread Kevin Lam (Jira)
Kevin Lam created FLINK-35808: - Summary: Let ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG be overridable by user in KafkaSourceBuilder Key: FLINK-35808 URL: https://issues.apache.org/jira/browse/FLINK-35808

[PR] Let ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG overridable by user in `KafkaSourceBuilder` [flink-connector-kafka]

2024-07-10 Thread via GitHub
klam-shop opened a new pull request, #108: URL: https://github.com/apache/flink-connector-kafka/pull/108 Let ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG overridable by user in `KafkaSourceBuilder`, in order to enable the Large Message use-case discussed in this [mailing list discussion]

Re: [PR] Let ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG overridable by user in `KafkaSourceBuilder` [flink-connector-kafka]

2024-07-10 Thread via GitHub
boring-cyborg[bot] commented on PR #108: URL: https://github.com/apache/flink-connector-kafka/pull/108#issuecomment-2221254845 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[jira] [Updated] (FLINK-35706) FLIP-463: Schema Definition in CREATE TABLE AS Statement

2024-07-10 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-35706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Peña updated FLINK-35706: Summary: FLIP-463: Schema Definition in CREATE TABLE AS Statement (was: FLIP-463: Allow defining

[jira] [Updated] (FLINK-35706) FLIP-463: Allow defining partition keys and table distribution in CREATE TABLE AS (CTAS)

2024-07-10 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-35706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Peña updated FLINK-35706: Summary: FLIP-463: Allow defining partition keys and table distribution in CREATE TABLE AS (CTAS)

[jira] [Commented] (FLINK-33672) Use MapState.entries() instead of keys() and get() in over window

2024-07-10 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864748#comment-17864748 ] Roman Khachatryan commented on FLINK-33672: --- Nice optimization! Do you have a

Re: [PR] [AZP-Trigger] Fixing two issues about checkpoint file-merging [flink]

2024-07-10 Thread via GitHub
Zakelly commented on PR #25071: URL: https://github.com/apache/flink/pull/25071#issuecomment-2220990688 Github action attempt 1 passed https://github.com/Zakelly/flink/actions/runs/9875488506/attempts/1 -- This is an automated message from the Apache Git Service. To respond to the message

[jira] [Assigned] (FLINK-34341) Implement DDB Streams Table API support

2024-07-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh reassigned FLINK-34341: --- Assignee: (was: Hong Liang Teoh) > Implement DDB Streams Table API support > --

[jira] [Assigned] (FLINK-34341) Implement DDB Streams Table API support

2024-07-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh reassigned FLINK-34341: --- Assignee: Hong Liang Teoh > Implement DDB Streams Table API support > -

[jira] [Assigned] (FLINK-34341) Implement DDB Streams Table API support

2024-07-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh reassigned FLINK-34341: --- Assignee: Abhi Gupta > Implement DDB Streams Table API support > --

[jira] [Updated] (FLINK-34341) Implement DDB Streams Table API support

2024-07-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh updated FLINK-34341: Fix Version/s: aws-connector-4.4.0 > Implement DDB Streams Table API support > ---

[jira] [Resolved] (FLINK-34341) Implement DDB Streams Table API support

2024-07-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh resolved FLINK-34341. - Resolution: Fixed > Implement DDB Streams Table API support > --

[jira] [Commented] (FLINK-34341) Implement DDB Streams Table API support

2024-07-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864734#comment-17864734 ] Hong Liang Teoh commented on FLINK-34341: -  merged commit [{{7f3483c}}|https://

[jira] [Resolved] (FLINK-32218) Implement support for parent/child shard ordering

2024-07-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh resolved FLINK-32218. - Resolution: Fixed > Implement support for parent/child shard ordering >

[jira] [Updated] (FLINK-32218) Implement support for parent/child shard ordering

2024-07-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh updated FLINK-32218: Fix Version/s: aws-connector-4.4.0 > Implement support for parent/child shard ordering > -

[jira] [Commented] (FLINK-32218) Implement support for parent/child shard ordering

2024-07-10 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864733#comment-17864733 ] Hong Liang Teoh commented on FLINK-32218: -  merged commit [{{c716ca4}}|https://

Re: [PR] [FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-10 Thread via GitHub
hlteoh37 merged PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] [FLINK-35801] Fix SnapshotFileMergingCompatibilityITCase, wait for file deletion before quit [flink]

2024-07-10 Thread via GitHub
Zakelly commented on code in PR #25066: URL: https://github.com/apache/flink/pull/25066#discussion_r1672561489 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/SnapshotFileMergingCompatibilityITCase.java: ## @@ -249,48 +249,42 @@ private void verifyStateHandleTyp

Re: [PR] [FLINK-35801] Fix SnapshotFileMergingCompatibilityITCase, wait for file deletion before quit [flink]

2024-07-10 Thread via GitHub
Zakelly commented on code in PR #25066: URL: https://github.com/apache/flink/pull/25066#discussion_r1672561489 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/SnapshotFileMergingCompatibilityITCase.java: ## @@ -249,48 +249,42 @@ private void verifyStateHandleTyp

Re: [PR] [FLINK-35739][FLIP-444] Native file copy support [flink]

2024-07-10 Thread via GitHub
pnowojski commented on code in PR #25028: URL: https://github.com/apache/flink/pull/25028#discussion_r1672556173 ## flink-core/src/main/java/org/apache/flink/util/FileUtils.java: ## @@ -138,17 +140,27 @@ public static String readFile(File file, String charsetName) throws IOExce

Re: [PR] [BP-1.20][FLINK-35803][checkpoint] Fix the wrong file reuse in cp file-merging [flink]

2024-07-10 Thread via GitHub
Zakelly commented on PR #25070: URL: https://github.com/apache/flink/pull/25070#issuecomment-2220887841 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [BP-1.20][FLINK-35803][checkpoint] Fix the wrong file reuse in cp file-merging [flink]

2024-07-10 Thread via GitHub
Zakelly commented on PR #25070: URL: https://github.com/apache/flink/pull/25070#issuecomment-2220887548 Unrelated CI error, re-running -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-35754) SqlGatewayE2ECase.testMaterializedTableInFullMode failed due to Internal Server Error

2024-07-10 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864727#comment-17864727 ] Zakelly Lan commented on FLINK-35754: - https://dev.azure.com/apache-flink/apache-fli

Re: [PR] [FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-10 Thread via GitHub
z3d1k commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1672531161 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/enumerator/tracker/SplitTrackerTest.java: ##

Re: [PR] [FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-10 Thread via GitHub
z3d1k commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1672531161 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/enumerator/tracker/SplitTrackerTest.java: ##

Re: [PR] [FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-10 Thread via GitHub
z3d1k commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1672530653 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/enumerator/tracker/SplitTrackerTest.java: ##

Re: [PR] [FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-10 Thread via GitHub
hlteoh37 commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1672530257 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/enumerator/tracker/SplitTrackerTest.java: ###

Re: [PR] [FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-10 Thread via GitHub
z3d1k commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1672525373 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/enumerator/tracker/SplitTracker.java: ## @@

Re: [PR] [FLINK-35717][table] Allow defining partition keys and table distribution in CREATE TABLE AS (CTAS) [flink]

2024-07-10 Thread via GitHub
spena commented on code in PR #24993: URL: https://github.com/apache/flink/pull/24993#discussion_r1672522012 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTableAs.java: ## @@ -124,18 +124,6 @@ public void validate() throws SqlValidateExce

Re: [PR] [FLINK-35799] Add CompiledPlan annotations to BatchExecCalc [flink]

2024-07-10 Thread via GitHub
snuyanzin commented on code in PR #25064: URL: https://github.com/apache/flink/pull/25064#discussion_r1672519351 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala: ## @@ -182,6 +186,58 @@ abstract class PlannerBase(

Re: [PR] [FLINK-35739][FLIP-444] Native file copy support [flink]

2024-07-10 Thread via GitHub
pnowojski commented on code in PR #25028: URL: https://github.com/apache/flink/pull/25028#discussion_r1672494318 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/StreamStateHandle.java: ## @@ -38,6 +38,14 @@ public interface StreamStateHandle extends StateObject {

[jira] [Commented] (FLINK-25920) Allow receiving updates of CommittableSummary

2024-07-10 Thread Alexis Sarda-Espinosa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864710#comment-17864710 ] Alexis Sarda-Espinosa commented on FLINK-25920: --- We don't use transactions

Re: [PR] [hotfix][ci] Update builds to test against 1.19.1 [flink-connector-aws]

2024-07-10 Thread via GitHub
hlteoh37 merged PR #147: URL: https://github.com/apache/flink-connector-aws/pull/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] [FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-10 Thread via GitHub
z3d1k commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1672449884 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/proxy/KinesisStreamProxyTest.java: ## @@ -41

[jira] [Created] (FLINK-35807) When restoring a task from a savepoint, tables that were previously synchronized but later deleted still exist in a state

2024-07-10 Thread zhangkunjie (Jira)
zhangkunjie created FLINK-35807: --- Summary: When restoring a task from a savepoint, tables that were previously synchronized but later deleted still exist in a state Key: FLINK-35807 URL: https://issues.apache.org/ji

Re: [PR] [FLINK-35799] Add CompiledPlan annotations to BatchExecCalc [flink]

2024-07-10 Thread via GitHub
jnh5y commented on code in PR #25064: URL: https://github.com/apache/flink/pull/25064#discussion_r1672433347 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala: ## @@ -182,6 +186,58 @@ abstract class PlannerBase( tr

Re: [PR] [FLINK-35799] Add CompiledPlan annotations to BatchExecCalc [flink]

2024-07-10 Thread via GitHub
snuyanzin commented on code in PR #25064: URL: https://github.com/apache/flink/pull/25064#discussion_r1672412991 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/ExecNodeMetadataUtil.java: ## @@ -198,8 +205,9 @@ public static Class> ret

Re: [PR] [FLINK-35799] Add CompiledPlan annotations to BatchExecCalc [flink]

2024-07-10 Thread via GitHub
snuyanzin commented on code in PR #25064: URL: https://github.com/apache/flink/pull/25064#discussion_r1672406225 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala: ## @@ -182,6 +186,58 @@ abstract class PlannerBase(

Re: [PR] [FLINK-35717][table] Allow defining partition keys and table distribution in CREATE TABLE AS (CTAS) [flink]

2024-07-10 Thread via GitHub
spena commented on code in PR #24993: URL: https://github.com/apache/flink/pull/24993#discussion_r1672397308 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java: ## @@ -856,18 +858,30 @@ public void testM

Re: [PR] [FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-10 Thread via GitHub
z3d1k commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1670845570 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/enumerator/tracker/SplitTrackerTest.java: ##

Re: [PR] [FLINK-35799] Add CompiledPlan annotations to BatchExecCalc [flink]

2024-07-10 Thread via GitHub
jnh5y commented on code in PR #25064: URL: https://github.com/apache/flink/pull/25064#discussion_r1672366149 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java: ## @@ -568,7 +568,7 @@ public Optional generat

Re: [PR] [FLINK-35799] Add CompiledPlan annotations to BatchExecCalc [flink]

2024-07-10 Thread via GitHub
jnh5y commented on code in PR #25064: URL: https://github.com/apache/flink/pull/25064#discussion_r1672364217 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/CompiledPlanITCase.java: ## @@ -404,28 +404,13 @@ void testPersistedConfigOption() throws Exce

Re: [PR] [FLINK-35799] Add CompiledPlan annotations to BatchExecCalc [flink]

2024-07-10 Thread via GitHub
jnh5y commented on code in PR #25064: URL: https://github.com/apache/flink/pull/25064#discussion_r1672363121 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecCalc.java: ## @@ -65,6 +76,29 @@ public BatchExecCalc(

Re: [PR] [FLINK-34111][table] Add support for json_quote, json_unquote, address PR feedback #24156 [flink]

2024-07-10 Thread via GitHub
fhueske commented on code in PR #24967: URL: https://github.com/apache/flink/pull/24967#discussion_r1672309798 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java: ## @@ -794,6 +796,218 @@ private static List jsonObj

Re: [PR] [hotfix] [docs] Fix typo in connector.file.src.reader.BulkFormat [flink]

2024-07-10 Thread via GitHub
mattayes commented on PR #25061: URL: https://github.com/apache/flink/pull/25061#issuecomment-2220597610 Thanks @Samrat002! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-35799] Add CompiledPlan annotations to BatchExecCalc [flink]

2024-07-10 Thread via GitHub
twalthr commented on code in PR #25064: URL: https://github.com/apache/flink/pull/25064#discussion_r1672278690 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecSink.java: ## @@ -33,19 +34,38 @@ import org.apache.flin

[jira] [Commented] (FLINK-35796) Ensure that MailboxExecutor.submit is used correctly

2024-07-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864668#comment-17864668 ] Martijn Visser commented on FLINK-35796: [~arvid] Will you backport it also to t

[jira] [Comment Edited] (FLINK-25920) Allow receiving updates of CommittableSummary

2024-07-10 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864666#comment-17864666 ] Arvid Heise edited comment on FLINK-25920 at 7/10/24 1:46 PM:

[jira] [Commented] (FLINK-25920) Allow receiving updates of CommittableSummary

2024-07-10 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864666#comment-17864666 ] Arvid Heise commented on FLINK-25920: - Could you please verify that your transaction

Re: [PR] [FLINK-35799] Add CompiledPlan annotations to BatchExecCalc [flink]

2024-07-10 Thread via GitHub
jnh5y commented on code in PR #25064: URL: https://github.com/apache/flink/pull/25064#discussion_r1672276028 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/ExecNodeMetadataUtil.java: ## @@ -198,8 +205,9 @@ public static Class> retriev

[jira] [Updated] (FLINK-35717) Allow DISTRIBUTED BY in CREATE TABLE AS (CTAS)

2024-07-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35717: --- Labels: pull-request-available (was: ) > Allow DISTRIBUTED BY in CREATE TABLE AS (CTAS) > -

Re: [PR] [FLINK-35717][table] Allow defining partition keys and table distribution in CREATE TABLE AS (CTAS) [flink]

2024-07-10 Thread via GitHub
twalthr commented on code in PR #24993: URL: https://github.com/apache/flink/pull/24993#discussion_r1672253123 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTableAs.java: ## @@ -124,18 +124,6 @@ public void validate() throws SqlValidateEx

  1   2   3   4   5   6   7   8   >