snuyanzin commented on code in PR #25064:
URL: https://github.com/apache/flink/pull/25064#discussion_r1672412991
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/ExecNodeMetadataUtil.java:
##########
@@ -198,8 +205,9 @@ public static Class<? extends ExecNode<?>>
retrieveExecNode(String name, int ver
}
public static <T extends ExecNode<?>> boolean isUnsupported(Class<T>
execNode) {
- return !StreamExecNode.class.isAssignableFrom(execNode)
- || UNSUPPORTED_JSON_SERDE_CLASSES.contains(execNode);
+ boolean streamOrKnownExecNode =
+ StreamExecNode.class.isAssignableFrom(execNode) ||
execNodes().contains(execNode);
+ return !streamOrKnownExecNode ||
UNSUPPORTED_JSON_SERDE_CLASSES.contains(execNode);
Review Comment:
yep, it could be done separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
