z3d1k commented on code in PR #145:
URL:
https://github.com/apache/flink-connector-aws/pull/145#discussion_r1672449884
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/proxy/KinesisStreamProxyTest.java:
##########
@@ -413,10 +414,15 @@ private List<Shard> getTestShards(final int startShardId,
final int endShardId)
private Consumer<ListShardsRequest> getListShardRequestValidation(
final String streamArn, final String startShardId, final String
nextToken) {
return req -> {
+ ShardFilter startingPosition = null;
+ if (startShardId != null) {
+ startingPosition =
+
ListShardsStartingPosition.fromShardId(startShardId).getShardFilter();
+ }
ListShardsRequest expectedReq =
ListShardsRequest.builder()
.streamARN(streamArn)
- .exclusiveStartShardId(startShardId)
+ .shardFilter(startingPosition)
Review Comment:
Expanded validation to all possible variants of starting position for
`listShard`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
