Re: [PR] Fixed Java version dependent on Flink. [flink]

2024-07-04 Thread via GitHub
snuyanzin commented on code in PR #24996: URL: https://github.com/apache/flink/pull/24996#discussion_r1666408605 ## README.md: ## @@ -69,8 +69,8 @@ Prerequisites for building Flink: * Unix-like environment (we use Linux, Mac OS X, Cygwin, WSL) * Git -* Maven (we require vers

Re: [PR] Fixed Java version dependent on Flink. [flink]

2024-07-04 Thread via GitHub
911432 commented on code in PR #24996: URL: https://github.com/apache/flink/pull/24996#discussion_r1666405688 ## README.md: ## @@ -69,8 +69,8 @@ Prerequisites for building Flink: * Unix-like environment (we use Linux, Mac OS X, Cygwin, WSL) * Git -* Maven (we require version

Re: [PR] [FLINK-35126] Rework default checkpoint progress check window [flink-kubernetes-operator]

2024-07-04 Thread via GitHub
mateczagany commented on code in PR #850: URL: https://github.com/apache/flink-kubernetes-operator/pull/850#discussion_r1666395622 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/ClusterHealthEvaluator.java: ## @@ -178,30 +178,46 @@ priv

[PR] [FLINK-35762] Cache hashCode for TableID & Transform descriptors [flink-cdc]

2024-07-04 Thread via GitHub
yuxiqian opened a new pull request, #3454: URL: https://github.com/apache/flink-cdc/pull/3454 This closes FLINK-35762. As previously discussed offline with @lvyanquan, HashMap lookup could be slow since we must calculate key hash code every time, though most key objects are immutable

[jira] [Updated] (FLINK-35762) Cache hashCode for immutable map key classes

2024-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35762: --- Labels: pull-request-available (was: ) > Cache hashCode for immutable map key classes > ---

Re: [PR] [FLINK-31215] [autoscaler] Backpropagate processing rate limits from non-scalable bottlenecks to upstream operators [flink-kubernetes-operator]

2024-07-04 Thread via GitHub
mxm commented on PR #847: URL: https://github.com/apache/flink-kubernetes-operator/pull/847#issuecomment-2210274584 Thanks for the PR @aplyusnin! I'll take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Fixed Java version dependent on Flink. [flink]

2024-07-04 Thread via GitHub
snuyanzin commented on code in PR #24996: URL: https://github.com/apache/flink/pull/24996#discussion_r1666386314 ## README.md: ## @@ -69,8 +69,8 @@ Prerequisites for building Flink: * Unix-like environment (we use Linux, Mac OS X, Cygwin, WSL) * Git -* Maven (we require vers

[jira] [Assigned] (FLINK-35344) Move same code from multiple subclasses to JdbcSourceChunkSplitter

2024-07-04 Thread Ruan Hang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruan Hang reassigned FLINK-35344: - Assignee: Hongshun Wang > Move same code from multiple subclasses to JdbcSourceChunkSplitter >

Re: [PR] Fixed Java version dependent on Flink. [flink]

2024-07-04 Thread via GitHub
911432 commented on PR #24996: URL: https://github.com/apache/flink/pull/24996#issuecomment-2210265055 Why not ‘marge’? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[jira] [Commented] (FLINK-35635) Release Testing: Verify FLIP-445: Support dynamic parallelism inference for HiveSource

2024-07-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863128#comment-17863128 ] Weijie Guo commented on FLINK-35635: Thanks [~JunRuiLi] for the validation! Closed t

[jira] [Closed] (FLINK-35635) Release Testing: Verify FLIP-445: Support dynamic parallelism inference for HiveSource

2024-07-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-35635. -- Resolution: Done > Release Testing: Verify FLIP-445: Support dynamic parallelism inference for > Hive

[jira] [Updated] (FLINK-35635) Release Testing: Verify FLIP-445: Support dynamic parallelism inference for HiveSource

2024-07-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35635: --- Affects Version/s: 1.20.0 > Release Testing: Verify FLIP-445: Support dynamic parallelism inference

[jira] [Commented] (FLINK-35635) Release Testing: Verify FLIP-445: Support dynamic parallelism inference for HiveSource

2024-07-04 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863127#comment-17863127 ] Junrui Li commented on FLINK-35635: --- I prepared two Flink jobs to read from Hive. In t

[jira] [Updated] (FLINK-35663) Release Testing: FLIP-436: Introduce Catalog-related Syntax

2024-07-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35663: --- Labels: release-testing (was: ) > Release Testing: FLIP-436: Introduce Catalog-related Syntax > ---

[jira] [Commented] (FLINK-35663) Release Testing: FLIP-436: Introduce Catalog-related Syntax

2024-07-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863124#comment-17863124 ] Weijie Guo commented on FLINK-35663: Thanks for the testing! Closed then. > Release

[jira] [Closed] (FLINK-35663) Release Testing: FLIP-436: Introduce Catalog-related Syntax

2024-07-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-35663. -- Fix Version/s: 1.20.0 Resolution: Done > Release Testing: FLIP-436: Introduce Catalog-related S

Re: [PR] [FLINK-35524][cdc-base] Clear connections pools when reader exist. [flink-cdc]

2024-07-04 Thread via GitHub
ruanhang1993 commented on code in PR #3388: URL: https://github.com/apache/flink-cdc/pull/3388#discussion_r1666364069 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/connection/JdbcConnectionPools.java

[jira] [Commented] (FLINK-35695) Release Testing: Verify FLINK-32315: Support local file upload in K8s mode

2024-07-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863123#comment-17863123 ] Weijie Guo commented on FLINK-35695: Thanks, closed. > Release Testing: Verify FLIN

[jira] [Closed] (FLINK-35695) Release Testing: Verify FLINK-32315: Support local file upload in K8s mode

2024-07-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-35695. -- Resolution: Done > Release Testing: Verify FLINK-32315: Support local file upload in K8s mode > --

[jira] [Created] (FLINK-35762) Cache hashCode for immutable map key classes

2024-07-04 Thread yux (Jira)
yux created FLINK-35762: --- Summary: Cache hashCode for immutable map key classes Key: FLINK-35762 URL: https://issues.apache.org/jira/browse/FLINK-35762 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-35524][cdc-base] Clear connections pools when reader exist. [flink-cdc]

2024-07-04 Thread via GitHub
ruanhang1993 commented on code in PR #3388: URL: https://github.com/apache/flink-cdc/pull/3388#discussion_r1666356399 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/relational/connection/JdbcConnectionPools.java: ##

[jira] [Resolved] (FLINK-35281) FlinkEnvironmentUtils#addJar add each jar only once

2024-07-04 Thread Ruan Hang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruan Hang resolved FLINK-35281. --- Resolution: Fixed > FlinkEnvironmentUtils#addJar add each jar only once > --

Re: [PR] [FLINK-35281][hotfix][cdc-common] FlinkEnvironmentUtils#addJar add each jar only once [flink-cdc]

2024-07-04 Thread via GitHub
ruanhang1993 merged PR #3301: URL: https://github.com/apache/flink-cdc/pull/3301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

[jira] [Updated] (FLINK-35761) Speed up the restore process of unaligned checkpoint

2024-07-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35761: Description: Currently, the task will transition state from ExecutionState.INITIALIZING to ExecutionState

[jira] [Updated] (FLINK-35761) Speed up the restore process of unaligned checkpoint

2024-07-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35761: Description: Currently, the task will transition state from ExecutionState.INITIALIZING to ExecutionState

[jira] [Updated] (FLINK-35761) Speed up the restore process of unaligned checkpoint

2024-07-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35761: Description: Currently, the task will transition state from ExecutionState.INITIALIZING to ExecutionState

[jira] [Assigned] (FLINK-35281) FlinkEnvironmentUtils#addJar add each jar only once

2024-07-04 Thread Ruan Hang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruan Hang reassigned FLINK-35281: - Assignee: Hongshun Wang > FlinkEnvironmentUtils#addJar add each jar only once > ---

[jira] [Created] (FLINK-35761) Speed up the restore process of unaligned checkpoint

2024-07-04 Thread Rui Fan (Jira)
Rui Fan created FLINK-35761: --- Summary: Speed up the restore process of unaligned checkpoint Key: FLINK-35761 URL: https://issues.apache.org/jira/browse/FLINK-35761 Project: Flink Issue Type: Improv

[jira] [Comment Edited] (FLINK-35754) SqlGatewayE2ECase.testMaterializedTableInFullMode failed due to Internal Server Error

2024-07-04 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863110#comment-17863110 ] Feng Jin edited comment on FLINK-35754 at 7/5/24 3:17 AM: -- {col

Re: [PR] [FLINK-35524][cdc-base] Clear connections pools when reader exist. [flink-cdc]

2024-07-04 Thread via GitHub
loserwang1024 commented on code in PR #3388: URL: https://github.com/apache/flink-cdc/pull/3388#discussion_r1666184517 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/relational/connection/JdbcConnectionPools.java: #

Re: [PR] [BP-1.19][FLINK-35731][runtime] Fix incorrect parallelism configured detection for Sink V2. [flink]

2024-07-04 Thread via GitHub
flinkbot commented on PR #25024: URL: https://github.com/apache/flink/pull/25024#issuecomment-2209892255 ## CI report: * cc250b6f1ef07f06610298e1d97c27079804a021 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-35754) SqlGatewayE2ECase.testMaterializedTableInFullMode failed due to Internal Server Error

2024-07-04 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863110#comment-17863110 ] Feng Jin commented on FLINK-35754: -- {color:#00}I tried to reproduce the issue local

Re: [PR] [BP-1.20][FLINK-35731][runtime] Fix incorrect parallelism configured detection for Sink V2. [flink]

2024-07-04 Thread via GitHub
flinkbot commented on PR #25023: URL: https://github.com/apache/flink/pull/25023#issuecomment-2209889759 ## CI report: * 6bf908dd79c92def31b7b9b6e6b8980e94e88f37 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-1.19][FLINK-35731][runtime] Fix incorrect parallelism configured detection for Sink V2. [flink]

2024-07-04 Thread via GitHub
JunRuiLee opened a new pull request, #25024: URL: https://github.com/apache/flink/pull/25024 ## What is the purpose of the change [BP-1.19][FLINK-35731][runtime] Fix incorrect parallelism configured detection for Sink V2. ## Brief change log [BP-1.19][FLINK-3

[PR] [BP-1.20][FLINK-35731][runtime] Fix incorrect parallelism configured detection for Sink V2. [flink]

2024-07-04 Thread via GitHub
JunRuiLee opened a new pull request, #25023: URL: https://github.com/apache/flink/pull/25023 ## What is the purpose of the change [BP-1.20][FLINK-35731][runtime] Fix incorrect parallelism configured detection for Sink V2. ## Brief change log [BP-1.20]

[jira] [Commented] (FLINK-35731) Sink V2 operator is mistakenly assumed always to be parallelism configured

2024-07-04 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863109#comment-17863109 ] Zhu Zhu commented on FLINK-35731: - [~JunRuiLi] could you open PRs to backport this fix t

Re: [PR] [FLINK-35524][cdc-base] Clear connections pools when reader exist. [flink-cdc]

2024-07-04 Thread via GitHub
ruanhang1993 commented on code in PR #3388: URL: https://github.com/apache/flink-cdc/pull/3388#discussion_r1666165030 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/relational/connection/JdbcConnectionPools.java: ##

Re: [PR] [FLINK-35731][runtime] Fix incorrect parallelism configured detection for Sink V2. [flink]

2024-07-04 Thread via GitHub
zhuzhurk closed pull request #24998: [FLINK-35731][runtime] Fix incorrect parallelism configured detection for Sink V2. URL: https://github.com/apache/flink/pull/24998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Commented] (FLINK-35760) [docs] Add scan.newly-added-table.enabled to docs.

2024-07-04 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863107#comment-17863107 ] Hongshun Wang commented on FLINK-35760: --- I'd like to do it. > [docs] Add scan.new

[jira] [Created] (FLINK-35760) [docs] Add scan.newly-added-table.enabled to docs.

2024-07-04 Thread Hongshun Wang (Jira)
Hongshun Wang created FLINK-35760: - Summary: [docs] Add scan.newly-added-table.enabled to docs. Key: FLINK-35760 URL: https://issues.apache.org/jira/browse/FLINK-35760 Project: Flink Issue Ty

[jira] [Commented] (FLINK-35759) [docs] Add 'scan.incremental.snapshot.backfill.skip' to docs.

2024-07-04 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863106#comment-17863106 ] Hongshun Wang commented on FLINK-35759: --- I'd like to do it. > [docs] Add 'scan.i

[jira] [Created] (FLINK-35759) [docs] Add 'scan.incremental.snapshot.backfill.skip' to docs.

2024-07-04 Thread Hongshun Wang (Jira)
Hongshun Wang created FLINK-35759: - Summary: [docs] Add 'scan.incremental.snapshot.backfill.skip' to docs. Key: FLINK-35759 URL: https://issues.apache.org/jira/browse/FLINK-35759 Project: Flink

Re: [PR] [docs] Add 'scan.incremental.snapshot.backfill.skip' to docs. [flink-cdc]

2024-07-04 Thread via GitHub
loserwang1024 commented on code in PR #3030: URL: https://github.com/apache/flink-cdc/pull/3030#discussion_r1666160202 ## docs/content/connectors/mysql-cdc(ZH).md: ## @@ -202,6 +202,13 @@ Flink SQL> SELECT * FROM orders; Integer 表快照的块大小(行数),读取表的快照时,捕获的表被拆分为

Re: [PR] [FLINK-35647][route] Allow symbol replacement to simplify routing rules [flink-cdc]

2024-07-04 Thread via GitHub
yuxiqian commented on code in PR #3428: URL: https://github.com/apache/flink-cdc/pull/3428#discussion_r1666132537 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/SchemaOperator.java: ## @@ -270,10 +276,18 @@ private RecordData regenerateRecordDat

Re: [PR] [FLINK-31215] [autoscaler] Backpropagate processing rate limits from non-scalable bottlenecks to upstream operators [flink-kubernetes-operator]

2024-07-04 Thread via GitHub
aplyusnin commented on code in PR #847: URL: https://github.com/apache/flink-kubernetes-operator/pull/847#discussion_r1665999061 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java: ## @@ -95,9 +105,11 @@ public int computeScaleTargetParallelism(

Re: [PR] [FLINK-31215] [autoscaler] Backpropagate processing rate limits from non-scalable bottlenecks to upstream operators [flink-kubernetes-operator]

2024-07-04 Thread via GitHub
aplyusnin commented on code in PR #847: URL: https://github.com/apache/flink-kubernetes-operator/pull/847#discussion_r1665998906 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -58,6 +58,15 @@ private static ConfigOptions.Optio

Re: [PR] [FLINK-33545][Connectors/Kafka] KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching [flink-connector-kafka]

2024-07-04 Thread via GitHub
tweise commented on PR #70: URL: https://github.com/apache/flink-connector-kafka/pull/70#issuecomment-2209349636 @hhktseng thanks for working on this. Can you please address the review comments? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [FLINK-33545][Connectors/Kafka] KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching [flink-connector-kafka]

2024-07-04 Thread via GitHub
tweise commented on code in PR #70: URL: https://github.com/apache/flink-connector-kafka/pull/70#discussion_r1665918661 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/FlinkKafkaInternalProducer.java: ## @@ -396,8 +408,27 @@ public String toString()

Re: [PR] [FLINK-31215] [autoscaler] Backpropagate processing rate limits from non-scalable bottlenecks to upstream operators [flink-kubernetes-operator]

2024-07-04 Thread via GitHub
gyfora commented on code in PR #847: URL: https://github.com/apache/flink-kubernetes-operator/pull/847#discussion_r1665881006 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -58,6 +58,15 @@ private static ConfigOptions.OptionBu

Re: [PR] [FLINK-31215] [autoscaler] Backpropagate processing rate limits from non-scalable bottlenecks to upstream operators [flink-kubernetes-operator]

2024-07-04 Thread via GitHub
aplyusnin commented on code in PR #847: URL: https://github.com/apache/flink-kubernetes-operator/pull/847#discussion_r1665866298 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java: ## @@ -95,9 +105,11 @@ public int computeScaleTargetParallelism(

Re: [PR] [FLINK-31215] [autoscaler] Backpropagate processing rate limits from non-scalable bottlenecks to upstream operators [flink-kubernetes-operator]

2024-07-04 Thread via GitHub
gyfora commented on code in PR #847: URL: https://github.com/apache/flink-kubernetes-operator/pull/847#discussion_r1665850637 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java: ## @@ -95,9 +105,11 @@ public int computeScaleTargetParallelism(

[jira] [Commented] (FLINK-31215) Backpropagate processing rate limits from non-scalable bottlenecks to upstream operators

2024-07-04 Thread Artem Plyusnin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863062#comment-17863062 ] Artem Plyusnin commented on FLINK-31215: Hi all. I finished with implementation

[jira] [Updated] (FLINK-35126) Improve checkpoint progress health check config and enable by default

2024-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35126: --- Labels: pull-request-available (was: ) > Improve checkpoint progress health check config an

[PR] [FLINK-35126] Rework default checkpoint progress check window [flink-kubernetes-operator]

2024-07-04 Thread via GitHub
gyfora opened a new pull request, #850: URL: https://github.com/apache/flink-kubernetes-operator/pull/850 ## What is the purpose of the change Currently the checkpoint progress health check window is configurable by Duration. This makes it hard to enable by default as the sensible int

[jira] [Updated] (FLINK-35647) Pipeline route rule supports placeholder replacement

2024-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35647: --- Labels: pull-request-available (was: ) > Pipeline route rule supports placeholder replaceme

Re: [PR] [FLINK-35647][route] Allow symbol replacement to simplify routing rules [flink-cdc]

2024-07-04 Thread via GitHub
lvyanquan commented on code in PR #3428: URL: https://github.com/apache/flink-cdc/pull/3428#discussion_r1665772373 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/SchemaOperator.java: ## @@ -270,10 +276,18 @@ private RecordData regenerateRecordDa

Re: [PR] [docs][minor] Fix typo in log message: "oder" to "order" [flink-cdc]

2024-07-04 Thread via GitHub
Karl-WangSK commented on code in PR #3451: URL: https://github.com/apache/flink-cdc/pull/3451#discussion_r1665744940 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/configuration/ConfigurationUtils.java: ## @@ -222,7 +222,7 @@ static Float convertToFloat(Object o)

Re: [PR] Flink 33386 review splited commits for ci [flink]

2024-07-04 Thread via GitHub
RocMarshal closed pull request #24229: Flink 33386 review splited commits for ci URL: https://github.com/apache/flink/pull/24229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-35576) FRocksDB cherry pick IngestDB related commits

2024-07-04 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yue Ma updated FLINK-35576: --- Description: We support the API related to ingest DB in FRocksDb-8.10.0, but many of the fixes related to i

[jira] [Updated] (FLINK-35498) Unexpected argument name conflict error when do extract method params from udf

2024-07-04 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-35498: Fix Version/s: (was: 2.0.0) > Unexpected argument name conflict error when do extract method p

[jira] [Closed] (FLINK-35498) Unexpected argument name conflict error when do extract method params from udf

2024-07-04 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-35498. --- Resolution: Fixed > Unexpected argument name conflict error when do extract method params from udf >

[jira] [Comment Edited] (FLINK-35498) Unexpected argument name conflict error when do extract method params from udf

2024-07-04 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17861290#comment-17861290 ] lincoln lee edited comment on FLINK-35498 at 7/4/24 1:17 PM: -

Re: [PR] [FLINK-35498][table] Fix unexpected argument name conflicts when extracting method parameter names from UDF [flink]

2024-07-04 Thread via GitHub
lincoln-lil merged PR #25020: URL: https://github.com/apache/flink/pull/25020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-35498][table] Fix unexpected argument name conflicts when extracting method parameter names from UDF [flink]

2024-07-04 Thread via GitHub
lincoln-lil merged PR #25019: URL: https://github.com/apache/flink/pull/25019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[jira] [Commented] (FLINK-35749) Kafka sink component will lose data when kafka cluster is unavailable for a while

2024-07-04 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863034#comment-17863034 ] Arvid Heise commented on FLINK-35749: - Hi [~zjmean], I can take this topic over if y

[jira] [Assigned] (FLINK-25920) Allow receiving updates of CommittableSummary

2024-07-04 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul reassigned FLINK-25920: --- Assignee: Arvid Heise (was: Fabian Paul) > Allow receiving updates of CommittableSummary >

Re: [PR] [docs][minor] Fix typo in log message: "oder" to "order" [flink-cdc]

2024-07-04 Thread via GitHub
yuxiqian commented on PR #3451: URL: https://github.com/apache/flink-cdc/pull/3451#issuecomment-2208828790 Looks good! Since some changes affected test cases, could @ruanhang1993 please trigger the CI? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [docs][minor] Fix typo in log message: "oder" to "order" [flink-cdc]

2024-07-04 Thread via GitHub
yuxiqian commented on code in PR #3451: URL: https://github.com/apache/flink-cdc/pull/3451#discussion_r1665625233 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/configuration/ConfigurationUtils.java: ## @@ -222,7 +222,7 @@ static Float convertToFloat(Object o) {

[jira] [Closed] (FLINK-35720) flink-connector-kafka fails to restore from checkpoint when using an EXACTLY_ONCE sink

2024-07-04 Thread Nicolas Ferrario (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Ferrario closed FLINK-35720. Resolution: Not A Problem > flink-connector-kafka fails to restore from checkpoint when us

[jira] [Commented] (FLINK-35720) flink-connector-kafka fails to restore from checkpoint when using an EXACTLY_ONCE sink

2024-07-04 Thread Nicolas Ferrario (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863018#comment-17863018 ] Nicolas Ferrario commented on FLINK-35720: -- Hi [~martijnvisser], I am very sorr

Re: [PR] [FLINK-35736][tests] Add migration test scripts & CI workflows [flink-cdc]

2024-07-04 Thread via GitHub
yuxiqian commented on PR #3447: URL: https://github.com/apache/flink-cdc/pull/3447#issuecomment-2208796964 Added `transform` block for Flink CDC 3.1+ to make sure I didn't break anything accidentally in #3285. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (FLINK-35292) Set dummy savepoint path during last-state upgrade

2024-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35292: --- Labels: pull-request-available (was: ) > Set dummy savepoint path during last-state upgrade

[PR] [FLINK-35292] Set dummy savepoint path during last-state upgrade [flink-kubernetes-operator]

2024-07-04 Thread via GitHub
gyfora opened a new pull request, #849: URL: https://github.com/apache/flink-kubernetes-operator/pull/849 ## What is the purpose of the change Currently the operator always sets the savepoint path even if last-state (HA metadata) must be used. This can be misleading to users a

[jira] [Updated] (FLINK-35758) [Doc] add scan.startup.timestamp-millis options to MySQL connector docs.

2024-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35758: --- Labels: pull-request-available (was: ) > [Doc] add scan.startup.timestamp-millis options to

[jira] [Created] (FLINK-35758) [Doc] add scan.startup.timestamp-millis options to MySQL connector docs.

2024-07-04 Thread LvYanquan (Jira)
LvYanquan created FLINK-35758: - Summary: [Doc] add scan.startup.timestamp-millis options to MySQL connector docs. Key: FLINK-35758 URL: https://issues.apache.org/jira/browse/FLINK-35758 Project: Flink

Re: [PR] [FLINK-34572] Support OceanBase Jdbc Catalog [flink-connector-jdbc]

2024-07-04 Thread via GitHub
whhe commented on PR #109: URL: https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2208676855 > Thanks @whhe for the contribution. Left a few of comments. PTAL ~ Thanks for your review, the documentations have been updated as suggested. PTAL. -- This is an automa

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-07-04 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2208669198 > @superdiaodiao can you please rebase to the recent master's version, I think it will help with ci? OK, I will rebase. -- This is an automated message from the Apache Git

Re: [PR] [FLINK-35755] Upgrade to flink-shaded 19.0 [flink]

2024-07-04 Thread via GitHub
dawidwys commented on code in PR #25022: URL: https://github.com/apache/flink/pull/25022#discussion_r1665471695 ## flink-dist/pom.xml: ## @@ -52,6 +52,40 @@ under the License. flink-core ${project.version} $

Re: [PR] [FLINK-35755] Upgrade to flink-shaded 19.0 [flink]

2024-07-04 Thread via GitHub
snuyanzin commented on code in PR #25022: URL: https://github.com/apache/flink/pull/25022#discussion_r1665468794 ## flink-dist/pom.xml: ## @@ -52,6 +52,40 @@ under the License. flink-core ${project.version}

[jira] [Commented] (FLINK-35749) Kafka sink component will lose data when kafka cluster is unavailable for a while

2024-07-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862991#comment-17862991 ] Martijn Visser commented on FLINK-35749: [~zjmean] It would be good to verify if

Re: [PR] [FLINK-35272][cdc][runtime] Pipeline Transform job supports omitting / renaming calculation column [flink-cdc]

2024-07-04 Thread via GitHub
yuxiqian commented on PR #3285: URL: https://github.com/apache/flink-cdc/pull/3285#issuecomment-2208567128 Fixed another problem in transform when combined with route & schema evolution. Really needs feedback from @leonardBang & @aiwenmo since this PR has gone a bit out of control. -- Th

Re: [PR] [FLINK-35740][mysql] Allow column as chunk key even if not in Primary Keys [flink-cdc]

2024-07-04 Thread via GitHub
SML0127 commented on PR #3448: URL: https://github.com/apache/flink-cdc/pull/3448#issuecomment-2208534001 > Generally LGTM, but my concern is arbitrarily chosen columns can be risky, since chunking by columns without index is very slow. > > I think we need to update related documentat

Re: [PR] [FLINK-35755] Upgrade to flink-shaded 19.0 [flink]

2024-07-04 Thread via GitHub
snuyanzin commented on PR #25022: URL: https://github.com/apache/flink/pull/25022#issuecomment-2208531580 Thanks for driving this In general it looks ok from my side Do you think it would make sense to add a checkstyle rule forbidding usage of `jsonpath` in imports? Like it is a

Re: [PR] [FLINK-34130][core] Mark setBytes and getBytes of Configuration as @Internal [flink]

2024-07-04 Thread via GitHub
1996fanrui commented on code in PR #24999: URL: https://github.com/apache/flink/pull/24999#discussion_r1665418365 ## pom.xml: ## @@ -2383,6 +2383,9 @@ under the License. org.apache.flink.util.function.SerializableF

Re: [PR] [FLINK-34130][core] Mark setBytes and getBytes of Configuration as @Internal [flink]

2024-07-04 Thread via GitHub
reswqa commented on code in PR #24999: URL: https://github.com/apache/flink/pull/24999#discussion_r1665404194 ## pom.xml: ## @@ -2383,6 +2383,9 @@ under the License. org.apache.flink.util.function.SerializableFunct

Re: [PR] [FLINK-34130][core] Mark setBytes and getBytes of Configuration as @Internal [flink]

2024-07-04 Thread via GitHub
reswqa commented on code in PR #24999: URL: https://github.com/apache/flink/pull/24999#discussion_r1665404194 ## pom.xml: ## @@ -2383,6 +2383,9 @@ under the License. org.apache.flink.util.function.SerializableFunct

[jira] [Commented] (FLINK-34268) Add a test to verify if restore test exists for ExecNode

2024-07-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862976#comment-17862976 ] Martijn Visser commented on FLINK-34268: Removed the exclusions on the tests in

Re: [PR] [FLINK-34268] Removing exclusions for FLINK-33676 33805 [flink]

2024-07-04 Thread via GitHub
MartijnVisser merged PR #25015: URL: https://github.com/apache/flink/pull/25015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-35755] Upgrade to flink-shaded 19.0 [flink]

2024-07-04 Thread via GitHub
flinkbot commented on PR #25022: URL: https://github.com/apache/flink/pull/25022#issuecomment-2208472352 ## CI report: * 47b66d5748f0144513b02666adbce21aeb7e02f0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35755] Upgrade to flink-shaded 19.0 [flink]

2024-07-04 Thread via GitHub
dawidwys commented on code in PR #25022: URL: https://github.com/apache/flink/pull/25022#discussion_r1665384093 ## flink-table/flink-table-planner/pom.xml: ## @@ -353,19 +353,6 @@ under the License. org.checkerframework

Re: [PR] [FLINK-35755] Upgrade to flink-shaded 19.0 [flink]

2024-07-04 Thread via GitHub
dawidwys commented on code in PR #25022: URL: https://github.com/apache/flink/pull/25022#discussion_r1665381479 ## flink-dist/pom.xml: ## @@ -52,6 +52,40 @@ under the License. flink-core ${project.version} $

[jira] [Updated] (FLINK-35755) Upgrade flink-shaded to 19.0

2024-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35755: --- Labels: pull-request-available (was: ) > Upgrade flink-shaded to 19.0 > ---

Re: [PR] [docs][minor] Fix typo in log message: "oder" to "order" [flink-cdc]

2024-07-04 Thread via GitHub
yuxiqian commented on PR #3451: URL: https://github.com/apache/flink-cdc/pull/3451#issuecomment-2208463982 Thanks for @Karl-WangSK's contribution! It reminds me that JetBrains IDE always complains about grammar issues in comments. Would you like to fix them together if possible? -- This

[PR] [FLINK-35755] Upgrade to flink-shaded 19.0 [flink]

2024-07-04 Thread via GitHub
dawidwys opened a new pull request, #25022: URL: https://github.com/apache/flink/pull/25022 ## What is the purpose of the change Upgrade flink-shaded version ## Brief change log * Upgraded flink-shaded to 18.0 and then 19.0 * adapted the code to updated guava version

Re: [PR] [FLINK-35643][doc] Add materialized table statement doc [flink]

2024-07-04 Thread via GitHub
lsyldliu commented on code in PR #24975: URL: https://github.com/apache/flink/pull/24975#discussion_r1665348020 ## docs/content/docs/dev/table/materialized-table/overview.md: ## @@ -0,0 +1,65 @@ +--- +title: Overview +weight: 1 +type: docs +aliases: +- /dev/table/materialized-ta

[jira] [Commented] (FLINK-35754) SqlGatewayE2ECase.testMaterializedTableInFullMode failed due to Internal Server Error

2024-07-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862970#comment-17862970 ] Weijie Guo commented on FLINK-35754: https://dev.azure.com/apache-flink/apache-flink

Re: [PR] [FLINK-35643][doc] Add materialized table statement doc [flink]

2024-07-04 Thread via GitHub
lsyldliu commented on code in PR #24975: URL: https://github.com/apache/flink/pull/24975#discussion_r1665279963 ## docs/content.zh/docs/dev/table/materialized-table/overview.md: ## @@ -0,0 +1,66 @@ +--- +title: 概览 +weight: 1 +type: docs +aliases: +- /dev/table/materialized-table

Re: [PR] [FLINK-35318][table-planner] use UTC timezone to handle TIMESTAMP_WITHOUT_TIME_ZONE type in RexNodeToExpressionConverter [flink]

2024-07-04 Thread via GitHub
lshangq commented on code in PR #24787: URL: https://github.com/apache/flink/pull/24787#discussion_r1665338469 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala: ## @@ -455,7 +449,7 @@ class RexNodeToExpressionConv

Re: [PR] [FLINK-34111][table] Add support for json_quote, json_unquote, address PR feedback #24156 [flink]

2024-07-04 Thread via GitHub
snuyanzin commented on PR #24967: URL: https://github.com/apache/flink/pull/24967#issuecomment-2208332293 Thanks for the contribution @anupamaggarwal I checked for most cases it works well I found one issue with symbols encoded outside of [BMP ](https://en.wikipedia.org/wiki/Plane

Re: [PR] [FLINK-34572] Support OceanBase Jdbc Catalog [flink-connector-jdbc]

2024-07-04 Thread via GitHub
RocMarshal commented on code in PR #109: URL: https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1665267264 ## docs/content.zh/docs/connectors/table/jdbc.md: ## @@ -433,10 +433,9 @@ JDBC Catalog `JdbcCatalog` 允许用户通过 JDBC 协议将 Flink 连接到关系数据库。 -目前,JDBC Catalo

  1   2   >