dawidwys commented on code in PR #25022:
URL: https://github.com/apache/flink/pull/25022#discussion_r1665381479


##########
flink-dist/pom.xml:
##########
@@ -52,6 +52,40 @@ under the License.
                        <artifactId>flink-core</artifactId>
                        <version>${project.version}</version>
                        <optional>${flink.markBundledAsOptional}</optional>
+                       <exclusions>
+                               <exclusion>
+                                       
<groupId>com.fasterxml.jackson.core</groupId>
+                                       <artifactId>jackson-core</artifactId>
+                               </exclusion>
+                               <exclusion>
+                                       
<groupId>com.fasterxml.jackson.core</groupId>
+                                       
<artifactId>jackson-annotations</artifactId>
+                               </exclusion>
+                               <exclusion>
+                                       
<groupId>com.fasterxml.jackson.core</groupId>
+                                       
<artifactId>jackson-databind</artifactId>
+                               </exclusion>
+                               <exclusion>
+                                       
<groupId>com.fasterxml.jackson.dataformat</groupId>
+                                       
<artifactId>jackson-dataformat-yaml</artifactId>
+                               </exclusion>
+                               <exclusion>
+                                       
<groupId>com.fasterxml.jackson.dataformat</groupId>
+                                       
<artifactId>jackson-dataformat-csv</artifactId>
+                               </exclusion>
+                               <exclusion>
+                                       
<groupId>com.fasterxml.jackson.datatype</groupId>
+                                       
<artifactId>jackson-datatype-jsr310</artifactId>
+                               </exclusion>
+                               <exclusion>
+                                       
<groupId>com.fasterxml.jackson.datatype</groupId>
+                                       
<artifactId>jackson-datatype-jdk8</artifactId>
+                               </exclusion>
+                               <exclusion>
+                                       <groupId>org.yaml</groupId>
+                                       <artifactId>snakeyaml</artifactId>
+                               </exclusion>
+                       </exclusions>

Review Comment:
   @snuyanzin Is that necessary with the upgraded `flatten` plugin in 
`flink-shaded`? I believe the reason for those exclusions was that `18.0` 
pulled in the unshaded dependencies incorrectly, isn't it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to