ruanhang1993 commented on code in PR #3388:
URL: https://github.com/apache/flink-cdc/pull/3388#discussion_r1666356399
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/relational/connection/JdbcConnectionPools.java:
##########
@@ -83,4 +84,14 @@ public String getJdbcUrl(
}
return jdbcConnectionPoolFactory.getJdbcUrl(sourceConfig);
}
+
+ public static void close() throws IOException {
+ synchronized (instance.pools) {
Review Comment:
Is it possible that the object `instance` is null? If so, there will be an
NullPointerException. If not , we do not need the following judgement `if
(instance != null) `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
