ruanhang1993 commented on code in PR #3388:
URL: https://github.com/apache/flink-cdc/pull/3388#discussion_r1666364069
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/connection/JdbcConnectionPools.java:
##########
@@ -51,4 +52,13 @@ public HikariDataSource getOrCreateConnectionPool(
return pools.get(poolId);
}
}
+
+ public static synchronized void close() throws IOException {
+ synchronized (INSTANCE.pools) {
+ if (INSTANCE != null) {
Review Comment:
The `INSTANCE` will never be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
