[GitHub] [flink] RocMarshal commented on pull request #20715: [FLINK-28659][flink-java][JUnit5 Migration] Module: flink-java.

2022-09-02 Thread GitBox
RocMarshal commented on PR #20715: URL: https://github.com/apache/flink/pull/20715#issuecomment-1236062335 Hi, @snuyanzin Thank you very much for the comments. I updated based on your suggestions . PTAL. CC @gaoyunhaii -- This is an automated message from the Apache Git Service. To

[GitHub] [flink-table-store] LadyForest closed pull request #280: [FLINK-29129] Try best to push down value filters

2022-09-02 Thread GitBox
LadyForest closed pull request #280: [FLINK-29129] Try best to push down value filters URL: https://github.com/apache/flink-table-store/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [flink-table-store] LadyForest closed pull request #280: [FLINK-29129] Try best to push down value filters

2022-09-02 Thread GitBox
LadyForest closed pull request #280: [FLINK-29129] Try best to push down value filters URL: https://github.com/apache/flink-table-store/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [flink] RocMarshal commented on a diff in pull request #20715: [FLINK-28659][flink-java][JUnit5 Migration] Module: flink-java.

2022-09-02 Thread GitBox
RocMarshal commented on code in PR #20715: URL: https://github.com/apache/flink/pull/20715#discussion_r962107812 ## flink-java/src/test/java/org/apache/flink/api/java/operator/MaxByOperatorTest.java: ## @@ -65,75 +67,76 @@ public void testMaxByKeyFieldsDataset() { try {

[GitHub] [flink] RocMarshal commented on a diff in pull request #20715: [FLINK-28659][flink-java][JUnit5 Migration] Module: flink-java.

2022-09-02 Thread GitBox
RocMarshal commented on code in PR #20715: URL: https://github.com/apache/flink/pull/20715#discussion_r962107474 ## flink-java/src/test/java/org/apache/flink/api/java/operator/FirstNOperatorTest.java: ## @@ -143,34 +140,32 @@ public void testGroupedSortedFirstN() { try

[GitHub] [flink] RocMarshal commented on a diff in pull request #20715: [FLINK-28659][flink-java][JUnit5 Migration] Module: flink-java.

2022-09-02 Thread GitBox
RocMarshal commented on code in PR #20715: URL: https://github.com/apache/flink/pull/20715#discussion_r962107474 ## flink-java/src/test/java/org/apache/flink/api/java/operator/FirstNOperatorTest.java: ## @@ -143,34 +140,32 @@ public void testGroupedSortedFirstN() { try

[GitHub] [flink-table-store] LadyForest closed pull request #280: [FLINK-29129] Try best to push down value filters

2022-09-02 Thread GitBox
LadyForest closed pull request #280: [FLINK-29129] Try best to push down value filters URL: https://github.com/apache/flink-table-store/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [flink] RocMarshal commented on a diff in pull request #20715: [FLINK-28659][flink-java][JUnit5 Migration] Module: flink-java.

2022-09-02 Thread GitBox
RocMarshal commented on code in PR #20715: URL: https://github.com/apache/flink/pull/20715#discussion_r962102803 ## flink-java/src/test/java/org/apache/flink/api/java/io/TextInputFormatTest.java: ## @@ -144,23 +130,24 @@ public void testNestedFileRead() throws IOException {

[GitHub] [flink] RocMarshal commented on a diff in pull request #20715: [FLINK-28659][flink-java][JUnit5 Migration] Module: flink-java.

2022-09-02 Thread GitBox
RocMarshal commented on code in PR #20715: URL: https://github.com/apache/flink/pull/20715#discussion_r962102685 ## flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java: ## @@ -970,21 +939,21 @@ public void testScanOrder() throws Exception {

[GitHub] [flink] RocMarshal commented on a diff in pull request #20715: [FLINK-28659][flink-java][JUnit5 Migration] Module: flink-java.

2022-09-02 Thread GitBox
RocMarshal commented on code in PR #20715: URL: https://github.com/apache/flink/pull/20715#discussion_r962102573 ## flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java: ## @@ -699,24 +668,24 @@ public void testReadSparseWithMask() throws Exception {

[GitHub] [flink] RocMarshal commented on a diff in pull request #20715: [FLINK-28659][flink-java][JUnit5 Migration] Module: flink-java.

2022-09-02 Thread GitBox
RocMarshal commented on code in PR #20715: URL: https://github.com/apache/flink/pull/20715#discussion_r962102559 ## flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java: ## @@ -660,24 +629,24 @@ public void testReadSparseWithPositionSetter() throws E

[GitHub] [flink] RocMarshal commented on a diff in pull request #20715: [FLINK-28659][flink-java][JUnit5 Migration] Module: flink-java.

2022-09-02 Thread GitBox
RocMarshal commented on code in PR #20715: URL: https://github.com/apache/flink/pull/20715#discussion_r962102514 ## flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java: ## @@ -547,28 +516,28 @@ public void testDoubleFields() throws Exception {

[GitHub] [flink] RocMarshal commented on a diff in pull request #20715: [FLINK-28659][flink-java][JUnit5 Migration] Module: flink-java.

2022-09-02 Thread GitBox
RocMarshal commented on code in PR #20715: URL: https://github.com/apache/flink/pull/20715#discussion_r962102458 ## flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java: ## @@ -460,28 +431,26 @@ public void testIntegerFields() throws Exception {

[GitHub] [flink] RocMarshal commented on a diff in pull request #20715: [FLINK-28659][flink-java][JUnit5 Migration] Module: flink-java.

2022-09-02 Thread GitBox
RocMarshal commented on code in PR #20715: URL: https://github.com/apache/flink/pull/20715#discussion_r962102253 ## flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java: ## @@ -225,22 +213,20 @@ public void ignoreMultiCharPrefixComments() throws Exce

[GitHub] [flink] RocMarshal commented on a diff in pull request #20715: [FLINK-28659][flink-java][JUnit5 Migration] Module: flink-java.

2022-09-02 Thread GitBox
RocMarshal commented on code in PR #20715: URL: https://github.com/apache/flink/pull/20715#discussion_r962102253 ## flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java: ## @@ -225,22 +213,20 @@ public void ignoreMultiCharPrefixComments() throws Exce

[GitHub] [flink] HarshaR99 commented on pull request #20690: FLINK-27107. Typo in Task.

2022-09-02 Thread GitBox
HarshaR99 commented on PR #20690: URL: https://github.com/apache/flink/pull/20690#issuecomment-1236042169 > it's not a typo.. @themoah good observation, but if you look for their specific meanings, I think you might agree that this typo needs to be changed. -- This is an automated

[GitHub] [flink] cun8cun8 commented on a diff in pull request #20742: [FLINK-29156]Support LISTAGG in the Table API

2022-09-02 Thread GitBox
cun8cun8 commented on code in PR #20742: URL: https://github.com/apache/flink/pull/20742#discussion_r962093570 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala: ## @@ -62,17 +62,17 @@ class StreamingW

[GitHub] [flink] cun8cun8 commented on a diff in pull request #20742: [FLINK-29156]Support LISTAGG in the Table API

2022-09-02 Thread GitBox
cun8cun8 commented on code in PR #20742: URL: https://github.com/apache/flink/pull/20742#discussion_r962093570 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala: ## @@ -62,17 +62,17 @@ class StreamingW

[GitHub] [flink] RocMarshal commented on a diff in pull request #20715: [FLINK-28659][flink-java][JUnit5 Migration] Module: flink-java.

2022-09-02 Thread GitBox
RocMarshal commented on code in PR #20715: URL: https://github.com/apache/flink/pull/20715#discussion_r962088033 ## flink-java/src/test/java/org/apache/flink/api/java/io/CSVReaderTest.java: ## @@ -40,258 +40,262 @@ import org.apache.flink.types.StringValue; import org.apache.f

[GitHub] [flink] lincoln-lil commented on pull request #20743: [hotfix][tests][table-planner] Add two more cases to verify the conflict of multiple LOOKUP hints

2022-09-02 Thread GitBox
lincoln-lil commented on PR #20743: URL: https://github.com/apache/flink/pull/20743#issuecomment-1235977213 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Updated] (FLINK-25448) TaskManagerRunnerTest.testShouldShutdownIfRegistrationWithJobManagerFails failed on azure

2022-09-02 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-25448: --- Labels: auto-deprioritized-major stale-minor test-stability (was: auto-deprioritized-major

[jira] [Updated] (FLINK-25452) FlinkKafkaProducerITCase.testRestoreUsingDifferentTransactionalIdPrefix failed on azure

2022-09-02 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-25452: --- Labels: auto-deprioritized-major stale-minor test-stability (was: auto-deprioritized-major

[jira] [Updated] (FLINK-27384) In the Hive dimension table, when the data is changed on the original partition, the create_time configuration does not take effect

2022-09-02 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-27384: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[GitHub] [flink] xuyangzhong commented on pull request #20705: [FLINK-29113][table-planner] throw exception when finding at least one invalid table name in join hints

2022-09-02 Thread GitBox
xuyangzhong commented on PR #20705: URL: https://github.com/apache/flink/pull/20705#issuecomment-1235706377 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Commented] (FLINK-28653) State Schema Evolution does not work - Flink defaults to Kryo serialization even for POJOs and Avro SpecificRecords

2022-09-02 Thread Peleg Tsadok (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599606#comment-17599606 ] Peleg Tsadok commented on FLINK-28653: -- [~chesnay] I created a new savepoint after

[GitHub] [flink] flinkbot commented on pull request #20743: [hotfix][tests][table-planner] Add two more cases to verify the conflict of multiple LOOKUP hints

2022-09-02 Thread GitBox
flinkbot commented on PR #20743: URL: https://github.com/apache/flink/pull/20743#issuecomment-1235615778 ## CI report: * dbd1c1cf4e0db5b9ed85614c2e0af5afa6b87f42 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] lincoln-lil opened a new pull request, #20743: [hotfix][tests][table-planner] Add two more cases to verify the conflict of multiple LOOKUP hints

2022-09-02 Thread GitBox
lincoln-lil opened a new pull request, #20743: URL: https://github.com/apache/flink/pull/20743 ## What is the purpose of the change Add two more cases to verify the conflict of multiple LOOKUP hints, which should be consistent with current join hints (the coming doc by #20513 will illust

[GitHub] [flink-connector-elasticsearch] nielsbasjes commented on pull request #28: [FLINK-28911] Ensure the SerializationSchema has been opened.

2022-09-02 Thread GitBox
nielsbasjes commented on PR #28: URL: https://github.com/apache/flink-connector-elasticsearch/pull/28#issuecomment-1235589800 Yes I agree. Let's just close this. And after 1.16.0 has been release do a "great migration". @zentl If you guys also agree then please close this one. -- This

[jira] [Commented] (FLINK-29165) Operator quickstart examples using code

2022-09-02 Thread Gaurav Miglani (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599525#comment-17599525 ] Gaurav Miglani commented on FLINK-29165: [~matyas]  can you please have a look i

[GitHub] [flink] tisonkun commented on a diff in pull request #20725: [FLINK-28934][Connector/pulsar] Fix split assignment for different Pulsar subscriptions

2022-09-02 Thread GitBox
tisonkun commented on code in PR #20725: URL: https://github.com/apache/flink/pull/20725#discussion_r961732654 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/assigner/SplitAssigner.java: ## @@ -34,7 +33,7 @@ * reade

[GitHub] [flink-connector-elasticsearch] zentol commented on pull request #28: [FLINK-28911] Ensure the SerializationSchema has been opened.

2022-09-02 Thread GitBox
zentol commented on PR #28: URL: https://github.com/apache/flink-connector-elasticsearch/pull/28#issuecomment-1235566590 Personally I'm inclined to wait until the 1.16.0 feature branch was cut, and then do the sync. Maybe even until 1.16.0 is released. -- This is an automated message fro

[GitHub] [flink] snuyanzin commented on pull request #20742: [FLINK-29156]Support LISTAGG in the Table API

2022-09-02 Thread GitBox
snuyanzin commented on PR #20742: URL: https://github.com/apache/flink/pull/20742#issuecomment-1235562818 Please make sure that you use and fill in the PR template. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] snuyanzin commented on a diff in pull request #20742: [FLINK-29156]Support LISTAGG in the Table API

2022-09-02 Thread GitBox
snuyanzin commented on code in PR #20742: URL: https://github.com/apache/flink/pull/20742#discussion_r961734554 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala: ## @@ -62,17 +62,17 @@ class Streaming

[jira] [Closed] (FLINK-29186) Store summarized results in internal nodes of BKD for time series points

2022-09-02 Thread Rishabh Maurya (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishabh Maurya closed FLINK-29186. -- Resolution: Abandoned > Store summarized results in internal nodes of BKD for time series poin

[jira] [Updated] (FLINK-29186) Store summarized results in internal nodes of BKD for time series points

2022-09-02 Thread Rishabh Maurya (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishabh Maurya updated FLINK-29186: --- Description: (was: Time series points have a timestamp, measurement and dimensions assoc

[GitHub] [flink] tisonkun commented on a diff in pull request #20725: [FLINK-28934][Connector/pulsar] Fix split assignment for different Pulsar subscriptions

2022-09-02 Thread GitBox
tisonkun commented on code in PR #20725: URL: https://github.com/apache/flink/pull/20725#discussion_r961724761 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/PulsarSourceEnumState.java: ## @@ -36,63 +33,16 @@ public c

[GitHub] [flink] tisonkun commented on a diff in pull request #20725: [FLINK-28934][Connector/pulsar] Fix split assignment for different Pulsar subscriptions

2022-09-02 Thread GitBox
tisonkun commented on code in PR #20725: URL: https://github.com/apache/flink/pull/20725#discussion_r961722004 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/PulsarSourceEnumState.java: ## @@ -36,63 +33,16 @@ public c

[jira] [Commented] (FLINK-28968) Release Testing: Verify FLIP-234 LOOKUP Hint

2022-09-02 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599507#comment-17599507 ] Godfrey He commented on FLINK-28968: Thanks for your effort, I will close it. > Rel

[jira] [Closed] (FLINK-28968) Release Testing: Verify FLIP-234 LOOKUP Hint

2022-09-02 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He closed FLINK-28968. -- Resolution: Fixed > Release Testing: Verify FLIP-234 LOOKUP Hint > ---

[jira] [Commented] (FLINK-28968) Release Testing: Verify FLIP-234 LOOKUP Hint

2022-09-02 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599506#comment-17599506 ] xuyang commented on FLINK-28968: Hi, [~godfreyhe] . The test work is finished. > Releas

[GitHub] [flink] fsk119 commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-02 Thread GitBox
fsk119 commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r961701727 ## docs/content.zh/docs/dev/table/hiveCompatibility/hiveDialect/Queries/set-op.md: ## @@ -0,0 +1,95 @@ +--- +title: "Set Operations" +weight: 5 +type: docs +--- + + +# Se

[jira] [Created] (FLINK-29186) Store summarized results in internal nodes of BKD for time series points

2022-09-02 Thread Rishabh Maurya (Jira)
Rishabh Maurya created FLINK-29186: -- Summary: Store summarized results in internal nodes of BKD for time series points Key: FLINK-29186 URL: https://issues.apache.org/jira/browse/FLINK-29186 Project:

[GitHub] [flink] fsk119 commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-02 Thread GitBox
fsk119 commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r961242871 ## docs/content.zh/docs/dev/table/hiveCompatibility/hiveDialect/Queries/overview.md: ## @@ -0,0 +1,163 @@ +--- +title: "Overview" +weight: 1 +type: docs +aliases: +- /dev

[jira] [Closed] (FLINK-28969) Release Testing: Verify FLIP-229 Join Hints for Flink SQL Batch

2022-09-02 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-28969. --- Resolution: Fixed > Release Testing: Verify FLIP-229 Join Hints for Flink SQL Batch > --

[GitHub] [flink] ChengkaiYang2022 commented on a diff in pull request #20724: [FLINK-27291][docs-zh] Translate the "List of Data Types" section of "Data Types" in to Chinese'

2022-09-02 Thread GitBox
ChengkaiYang2022 commented on code in PR #20724: URL: https://github.com/apache/flink/pull/20724#discussion_r961687243 ## docs/content.zh/docs/dev/table/types.md: ## @@ -1179,26 +1127,21 @@ DataTypes.MULTISET(t) {{< /tab >}} {{< /tabs >}} -The type can be declared using `MUL

[GitHub] [flink] ChengkaiYang2022 commented on a diff in pull request #20724: [FLINK-27291][docs-zh] Translate the "List of Data Types" section of "Data Types" in to Chinese'

2022-09-02 Thread GitBox
ChengkaiYang2022 commented on code in PR #20724: URL: https://github.com/apache/flink/pull/20724#discussion_r961662302 ## docs/content.zh/docs/dev/table/types.md: ## @@ -333,11 +325,11 @@ DataTypes.VARBINARY(n) DataTypes.BYTES() ``` -**Bridging to JVM Types** +**JVM Types桥接*

[jira] [Closed] (FLINK-28981) Release Testing: Verify FLIP-245 sources speculative execution

2022-09-02 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-28981. --- Resolution: Done > Release Testing: Verify FLIP-245 sources speculative execution >

[jira] [Commented] (FLINK-28981) Release Testing: Verify FLIP-245 sources speculative execution

2022-09-02 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599499#comment-17599499 ] Zhu Zhu commented on FLINK-28981: - Thanks for helping with this release testing! [~33736

[jira] [Commented] (FLINK-28981) Release Testing: Verify FLIP-245 sources speculative execution

2022-09-02 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599498#comment-17599498 ] Godfrey He commented on FLINK-28981: can this issue be closed ? [~zhuzh] [~337361...

[GitHub] [flink] Sxnan commented on pull request #20534: [FLINK-28860] Fix CacheITCase

2022-09-02 Thread GitBox
Sxnan commented on PR #20534: URL: https://github.com/apache/flink/pull/20534#issuecomment-1235519026 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] pnowojski commented on a diff in pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-02 Thread GitBox
pnowojski commented on code in PR #20485: URL: https://github.com/apache/flink/pull/20485#discussion_r961619833 ## flink-core/src/main/java/org/apache/flink/configuration/PipelineOptions.java: ## @@ -282,4 +282,21 @@ public enum VertexDescriptionMode { .with

[GitHub] [flink-ml] lindong28 merged pull request #148: [FLINK-28906] Add AlgoOperator for AgglomerativeClustering

2022-09-02 Thread GitBox
lindong28 merged PR #148: URL: https://github.com/apache/flink-ml/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #148: [FLINK-28906] Add AlgoOperator for AgglomerativeClustering

2022-09-02 Thread GitBox
zhipeng93 commented on code in PR #148: URL: https://github.com/apache/flink-ml/pull/148#discussion_r961545453 ## flink-ml-python/pyflink/ml/lib/clustering/agglomerativeclustering.py: ## @@ -0,0 +1,135 @@ +#

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #148: [FLINK-28906] Add AlgoOperator for AgglomerativeClustering

2022-09-02 Thread GitBox
lindong28 commented on code in PR #148: URL: https://github.com/apache/flink-ml/pull/148#discussion_r961557819 ## flink-ml-lib/src/main/java/org/apache/flink/ml/clustering/agglomerativeclustering/AgglomerativeClusteringParams.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Ap

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #148: [FLINK-28906] Add AlgoOperator for AgglomerativeClustering

2022-09-02 Thread GitBox
zhipeng93 commented on code in PR #148: URL: https://github.com/apache/flink-ml/pull/148#discussion_r961545453 ## flink-ml-python/pyflink/ml/lib/clustering/agglomerativeclustering.py: ## @@ -0,0 +1,135 @@ +#

[GitHub] [flink] godfreyhe commented on a diff in pull request #20705: [FLINK-29113][table-planner] throw exception when finding at least one invalid table name in join hints

2022-09-02 Thread GitBox
godfreyhe commented on code in PR #20705: URL: https://github.com/apache/flink/pull/20705#discussion_r961527995 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/LookupJoinTest.scala: ## @@ -752,7 +752,8 @@ class LookupJoinTest

[GitHub] [flink] SwimSweet commented on pull request #20671: [FLINK-28915] Flink Native k8s mode jar localtion support s3 schema.

2022-09-02 Thread GitBox
SwimSweet commented on PR #20671: URL: https://github.com/apache/flink/pull/20671#issuecomment-1235320037 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] mxm commented on pull request #15675: [FLINK-10052][ha] Tolerate temporarily suspended ZooKeeper connections

2022-09-02 Thread GitBox
mxm commented on PR #15675: URL: https://github.com/apache/flink/pull/15675#issuecomment-1235312010 @yoav-rosenthal AFAIK this has only been ported to Flink 1.14.0 and later. You can see that in the Fix Version of the associated Jira Ticket: https://issues.apache.org/jira/browse/FLINK-10052

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #148: [FLINK-28906] Add AlgoOperator for AgglomerativeClustering

2022-09-02 Thread GitBox
zhipeng93 commented on code in PR #148: URL: https://github.com/apache/flink-ml/pull/148#discussion_r961513789 ## flink-ml-lib/src/main/java/org/apache/flink/ml/clustering/agglomerativeclustering/AgglomerativeClustering.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache S

[jira] [Commented] (FLINK-28981) Release Testing: Verify FLIP-245 sources speculative execution

2022-09-02 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599374#comment-17599374 ] Yunhong Zheng commented on FLINK-28981: --- Hi, [~zhuzh], [~hxb], [~godfreyhe] . I ha

[GitHub] [flink] HuangXingBo commented on pull request #20685: [FLINK-28429][python] Optimize PyFlink tests

2022-09-02 Thread GitBox
HuangXingBo commented on PR #20685: URL: https://github.com/apache/flink/pull/20685#issuecomment-1235304621 https://dev.azure.com/hxbks2ks/FLINK-TEST/_build/results?buildId=2064&view=logs&j=fba17979-6d2e-591d-72f1-97cf42797c11&t=727942b6-6137-54f7-1ef9-e66e706ea068 -- This is an automated

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #134: [FLINK-27207] Support built-in parquet format

2022-09-02 Thread GitBox
SteNicholas commented on code in PR #134: URL: https://github.com/apache/flink-table-store/pull/134#discussion_r961478878 ## flink-table-store-format/src/main/java/org/apache/flink/table/store/format/parquet/ParquetFileFormatFactory.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to

[GitHub] [flink] godfreyhe commented on a diff in pull request #20697: [FLINK-29120][table-planner] avoid join hint propagating into view

2022-09-02 Thread GitBox
godfreyhe commented on code in PR #20697: URL: https://github.com/apache/flink/pull/20697#discussion_r961506252 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/FlinkPlannerImpl.scala: ## @@ -193,17 +193,22 @@ class FlinkPlannerImpl( pr

[GitHub] [flink] SmirAlex commented on pull request #20734: [FLINK-29093][table] Fix InternalCompilerException in LookupJoinITCase + reset resource counter before each test

2022-09-02 Thread GitBox
SmirAlex commented on PR #20734: URL: https://github.com/apache/flink/pull/20734#issuecomment-1235298416 Successful pipeline - https://dev.azure.com/asmirnov1/Flink/_build/results?buildId=35&view=results -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #134: [FLINK-27207] Support built-in parquet format

2022-09-02 Thread GitBox
SteNicholas commented on code in PR #134: URL: https://github.com/apache/flink-table-store/pull/134#discussion_r961501655 ## flink-table-store-format/src/test/java/org/apache/flink/table/store/format/parquet/ParquetFileFormatTest.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the

[jira] [Updated] (FLINK-29175) Add documents for KBinsDiscretizer, VectorIndexer, Tokenizer, RegexTokenizer

2022-09-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29175: --- Labels: pull-request-available (was: ) > Add documents for KBinsDiscretizer, VectorIndexer,

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #134: [FLINK-27207] Support built-in parquet format

2022-09-02 Thread GitBox
SteNicholas commented on code in PR #134: URL: https://github.com/apache/flink-table-store/pull/134#discussion_r961501104 ## flink-table-store-format/src/main/java/org/apache/flink/table/store/format/parquet/ParquetUtil.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache So

[GitHub] [flink-ml] zhipeng93 opened a new pull request, #152: [FLINK-29175] Add documents for KBinsDiscretizer, RegexTokenizer, Tok…

2022-09-02 Thread GitBox
zhipeng93 opened a new pull request, #152: URL: https://github.com/apache/flink-ml/pull/152 …enizer and VectorIndexer This PR adds documents for four feature engineering algorithms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #134: [FLINK-27207] Support built-in parquet format

2022-09-02 Thread GitBox
SteNicholas commented on code in PR #134: URL: https://github.com/apache/flink-table-store/pull/134#discussion_r961499971 ## flink-table-store-format/src/main/java/org/apache/flink/table/store/format/parquet/ParquetUtil.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache So

[GitHub] [flink] lincoln-lil commented on pull request #20727: [FLINK-29138][table-planner] fix project can not be pushed into lookup source

2022-09-02 Thread GitBox
lincoln-lil commented on PR #20727: URL: https://github.com/apache/flink/pull/20727#issuecomment-1235295710 rebase master for the docker name fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #134: [FLINK-27207] Support built-in parquet format

2022-09-02 Thread GitBox
SteNicholas commented on code in PR #134: URL: https://github.com/apache/flink-table-store/pull/134#discussion_r961498030 ## flink-table-store-format/src/main/java/org/apache/flink/table/store/format/parquet/ParquetFileStatsExtractor.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed t

[GitHub] [flink-table-store] liyubin117 commented on a diff in pull request #134: [FLINK-27207] Support built-in parquet format

2022-09-02 Thread GitBox
liyubin117 commented on code in PR #134: URL: https://github.com/apache/flink-table-store/pull/134#discussion_r961497413 ## flink-table-store-format/src/main/java/org/apache/flink/table/store/format/parquet/ParquetFileFormatFactory.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to t

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #134: [FLINK-27207] Support built-in parquet format

2022-09-02 Thread GitBox
SteNicholas commented on code in PR #134: URL: https://github.com/apache/flink-table-store/pull/134#discussion_r961494794 ## flink-table-store-format/src/main/java/org/apache/flink/table/store/format/parquet/ParquetFileFormat.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apa

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #134: [FLINK-27207] Support built-in parquet format

2022-09-02 Thread GitBox
SteNicholas commented on code in PR #134: URL: https://github.com/apache/flink-table-store/pull/134#discussion_r961490822 ## flink-table-store-format/src/main/java/org/apache/flink/table/store/format/parquet/ParquetFileFormat.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apa

[jira] [Updated] (FLINK-29179) Translate "Temporal Table Function" page of "Streaming Concepts" into Chinese

2022-09-02 Thread ChunJi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChunJi updated FLINK-29179: --- Description: The page url is [https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/dev/table/con

[jira] [Updated] (FLINK-29179) Translate "Temporal Table Function" page of "Streaming Concepts" into Chinese

2022-09-02 Thread ChunJi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChunJi updated FLINK-29179: --- Description: The page url is [https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/dev/table/con

[GitHub] [flink-table-store] liyubin117 commented on a diff in pull request #134: [FLINK-27207] Support built-in parquet format

2022-09-02 Thread GitBox
liyubin117 commented on code in PR #134: URL: https://github.com/apache/flink-table-store/pull/134#discussion_r961481427 ## flink-table-store-format/src/main/java/org/apache/flink/table/store/format/parquet/ParquetFileFormatFactory.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to t

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #134: [FLINK-27207] Support built-in parquet format

2022-09-02 Thread GitBox
SteNicholas commented on code in PR #134: URL: https://github.com/apache/flink-table-store/pull/134#discussion_r961478878 ## flink-table-store-format/src/main/java/org/apache/flink/table/store/format/parquet/ParquetFileFormatFactory.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-27748) AdaptiveScheduler should support operator fixed parallelism

2022-09-02 Thread Konstantin Knauf (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599355#comment-17599355 ] Konstantin Knauf commented on FLINK-27748: -- [~long jiang] Better late than neve

[jira] [Commented] (FLINK-29179) Translate "Temporal Table Function" page of "Streaming Concepts" into Chinese

2022-09-02 Thread ChunJi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599354#comment-17599354 ] ChunJi commented on FLINK-29179: hi,[~jark] ,i have done this translation,please assign

[jira] [Closed] (FLINK-29180) Show subtask metrics as default in vertex detail

2022-09-02 Thread Junhan Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang closed FLINK-29180. --- Fix Version/s: 1.16.0 Resolution: Fixed > Show subtask metrics as default in vertex detail >

[jira] [Updated] (FLINK-29185) Failed to execute USING JAR in Hive Dialect

2022-09-02 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-29185: -- Component/s: Connectors / Hive > Failed to execute USING JAR in Hive Dialect > ---

[jira] [Commented] (FLINK-29180) Show subtask metrics as default in vertex detail

2022-09-02 Thread Junhan Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599351#comment-17599351 ] Junhan Yang commented on FLINK-29180: - master (1.16): 121e63e8702e449559dc548fc29b4e

[jira] [Commented] (FLINK-28941) Savepoint ignores MaxConcurrentCheckpoint limit in aligned checkpoint case

2022-09-02 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599350#comment-17599350 ] Xingbo Huang commented on FLINK-28941: -- Thanks for the investigations [~gaoyunhaii]

[jira] [Updated] (FLINK-29185) Failed to execute USING JAR in Hive Dialect

2022-09-02 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-29185: -- Affects Version/s: 1.16.0 > Failed to execute USING JAR in Hive Dialect >

[jira] [Created] (FLINK-29185) Failed to execute USING JAR in Hive Dialect

2022-09-02 Thread Shengkai Fang (Jira)
Shengkai Fang created FLINK-29185: - Summary: Failed to execute USING JAR in Hive Dialect Key: FLINK-29185 URL: https://issues.apache.org/jira/browse/FLINK-29185 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-29184) SQL Gateway should remove the downloaded resources

2022-09-02 Thread Shengkai Fang (Jira)
Shengkai Fang created FLINK-29184: - Summary: SQL Gateway should remove the downloaded resources Key: FLINK-29184 URL: https://issues.apache.org/jira/browse/FLINK-29184 Project: Flink Issue Ty

[jira] [Commented] (FLINK-28941) Savepoint ignores MaxConcurrentCheckpoint limit in aligned checkpoint case

2022-09-02 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599349#comment-17599349 ] Yun Gao commented on FLINK-28941: - [~hxb] I have a double check with [~yunfengzhou] offl

[jira] [Comment Edited] (FLINK-28941) Savepoint ignores MaxConcurrentCheckpoint limit in aligned checkpoint case

2022-09-02 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599349#comment-17599349 ] Yun Gao edited comment on FLINK-28941 at 9/2/22 9:05 AM: - [~hxb]

[jira] [Commented] (FLINK-28953) Release Testing: Verify FLIP-91 SQL Gateway

2022-09-02 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599348#comment-17599348 ] Shengkai Fang commented on FLINK-28953: --- Thanks for your great work.   > BEGIN S

[GitHub] [flink] ganlute commented on pull request #20542: [FLINK-28910][Connectors/hbase]CDC From Mysql To Hbase Bugs

2022-09-02 Thread GitBox
ganlute commented on PR #20542: URL: https://github.com/apache/flink/pull/20542#issuecomment-1235255529 @MartijnVisser could you please help me review the changes?Thank you.😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [flink] yangjunhan merged pull request #20737: [FLINK-29180] fix: show subtask metrics as default in vertex detail

2022-09-02 Thread GitBox
yangjunhan merged PR #20737: URL: https://github.com/apache/flink/pull/20737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[GitHub] [flink] yangjunhan commented on pull request #20737: [FLINK-29180] fix: show subtask metrics as default in vertex detail

2022-09-02 Thread GitBox
yangjunhan commented on PR #20737: URL: https://github.com/apache/flink/pull/20737#issuecomment-1235254702 > LGTM, +1 for merging. Thank you for the response. CI passed, so I am merging it now. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (FLINK-25325) Migration Flink from Junit4 to Junit5

2022-09-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599340#comment-17599340 ] Matthias Pohl commented on FLINK-25325: --- [~hxb] I feel like it should be ok to con

[GitHub] [flink] Sxnan commented on pull request #20534: [FLINK-28860] Fix CacheITCase

2022-09-02 Thread GitBox
Sxnan commented on PR #20534: URL: https://github.com/apache/flink/pull/20534#issuecomment-1235245765 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-29153) KafkaConsumerThread should catch WakeupException when committing offsets

2022-09-02 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599324#comment-17599324 ] Xingbo Huang commented on FLINK-29153: -- https://dev.azure.com/apache-flink/apache-f

[jira] [Updated] (FLINK-28941) Savepoint ignores MaxConcurrentCheckpoint limit in aligned checkpoint case

2022-09-02 Thread Yunfeng Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunfeng Zhou updated FLINK-28941: - Priority: Blocker (was: Critical) > Savepoint ignores MaxConcurrentCheckpoint limit in aligned

[jira] [Commented] (FLINK-29153) KafkaConsumerThread should catch WakeupException when committing offsets

2022-09-02 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599325#comment-17599325 ] Xingbo Huang commented on FLINK-29153: -- https://dev.azure.com/apache-flink/apache-f

[jira] [Commented] (FLINK-28941) Savepoint ignores MaxConcurrentCheckpoint limit in aligned checkpoint case

2022-09-02 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599322#comment-17599322 ] Xingbo Huang commented on FLINK-28941: -- [https://dev.azure.com/apache-flink/apache-

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #150: [FLINK-28806] Add Transformer and Estimator for IDF

2022-09-02 Thread GitBox
zhipeng93 commented on code in PR #150: URL: https://github.com/apache/flink-ml/pull/150#discussion_r961445127 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/idf/IDFModel.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

  1   2   >