RocMarshal commented on code in PR #20715:
URL: https://github.com/apache/flink/pull/20715#discussion_r962107474
##########
flink-java/src/test/java/org/apache/flink/api/java/operator/FirstNOperatorTest.java:
##########
@@ -143,34 +140,32 @@ public void testGroupedSortedFirstN() {
try {
tupleDs.groupBy(2).sortGroup(4, Order.ASCENDING).first(1);
} catch (Exception e) {
- Assert.fail();
+ fail(e.getMessage());
}
// should work
try {
tupleDs.groupBy(1, 3).sortGroup(4, Order.ASCENDING).first(10);
} catch (Exception e) {
- Assert.fail();
+ fail(e.getMessage());
}
// should not work n == 0
try {
tupleDs.groupBy(0).sortGroup(4, Order.ASCENDING).first(0);
- Assert.fail();
Review Comment:
Good catch. It's a ignored error line.
I'll replace the block with assertThatThrownBy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
