tisonkun commented on code in PR #20725:
URL: https://github.com/apache/flink/pull/20725#discussion_r961722004
##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/PulsarSourceEnumState.java:
##########
@@ -36,63 +33,16 @@ public class PulsarSourceEnumState {
/** The topic partitions that have been appended to this source. */
private final Set<TopicPartition> appendedPartitions;
- /**
- * We convert the topic partition into a split and add to this pending
list for assigning to a
- * reader. It is used for Key_Shared, Failover, Exclusive subscription.
- */
- private final Set<PulsarPartitionSplit> pendingPartitionSplits;
-
- /**
- * It is used for Shared subscription. When a reader is crashed in Shared
subscription, its
- * splits would be put in here.
- */
- private final Map<Integer, Set<PulsarPartitionSplit>>
sharedPendingPartitionSplits;
-
- /**
- * It is used for Shared subscription. Every {@link PulsarPartitionSplit}
should be assigned for
- * all flink readers. Using this map for recording assign status.
- */
- private final Map<Integer, Set<String>> readerAssignedSplits;
Review Comment:
Shall we apply the new state strategy for Shared only? Or what do you think
of users who already use the Flink Pulsar connector and have their own state to
upgrade and downgrade between versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
