[GitHub] [flink] gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-24 Thread GitBox
gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r297030031 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java ## @

[GitHub] [flink] flinkbot commented on issue #8866: [FLINK-12969] [table-planner-blink] Remove dependencies on RelNode from TableImpl in blink planner

2019-06-24 Thread GitBox
flinkbot commented on issue #8866: [FLINK-12969] [table-planner-blink] Remove dependencies on RelNode from TableImpl in blink planner URL: https://github.com/apache/flink/pull/8866#issuecomment-505312050 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I h

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-24 Thread GitBox
gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r297030031 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java ## @

[jira] [Updated] (FLINK-12969) Remove dependencies on RelNode from TableImpl in blink planner

2019-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12969: --- Labels: pull-request-available (was: ) > Remove dependencies on RelNode from TableImpl in b

[GitHub] [flink] godfreyhe opened a new pull request #8866: [FLINK-12969] [table-planner-blink] Remove dependencies on RelNode from TableImpl in blink planner

2019-06-24 Thread GitBox
godfreyhe opened a new pull request #8866: [FLINK-12969] [table-planner-blink] Remove dependencies on RelNode from TableImpl in blink planner URL: https://github.com/apache/flink/pull/8866 ## What is the purpose of the change *Remove dependencies on RelNode from TableImpl in blin

[GitHub] [flink] wuchong commented on issue #8819: [FLINK-12911][table-api] Port AppendStreamTableSink, UpsertStreamTableSink, RetractStreamTableSink to flink-api-java-bridge

2019-06-24 Thread GitBox
wuchong commented on issue #8819: [FLINK-12911][table-api] Port AppendStreamTableSink, UpsertStreamTableSink, RetractStreamTableSink to flink-api-java-bridge URL: https://github.com/apache/flink/pull/8819#issuecomment-505311036 Hi @dawidwys , could have a quick look at this PR. It's a

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-24 Thread GitBox
gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r297030031 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java ## @

[GitHub] [flink] zhijiangW commented on issue #8455: [FLINK-12284, FLINK-12637][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-06-24 Thread GitBox
zhijiangW commented on issue #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#issuecomment-505310462 In addition, you might need to execute the command "mvn package -Dgene

[jira] [Updated] (FLINK-12970) Support writing Hive complex types

2019-06-24 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Li updated FLINK-12970: --- Component/s: Connectors / Hive > Support writing Hive complex types > -- > >

[jira] [Updated] (FLINK-12970) Support writing Hive complex types

2019-06-24 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Li updated FLINK-12970: --- Description: HiveTableOutputFormat currently only supports writing primitive types. Need to support complex

[jira] [Created] (FLINK-12970) Support writing Hive complex types

2019-06-24 Thread Rui Li (JIRA)
Rui Li created FLINK-12970: -- Summary: Support writing Hive complex types Key: FLINK-12970 URL: https://issues.apache.org/jira/browse/FLINK-12970 Project: Flink Issue Type: Sub-task Repor

[GitHub] [flink] zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297027480 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution

[jira] [Created] (FLINK-12969) Remove dependencies on RelNode from TableImpl in blink planner

2019-06-24 Thread godfrey he (JIRA)
godfrey he created FLINK-12969: -- Summary: Remove dependencies on RelNode from TableImpl in blink planner Key: FLINK-12969 URL: https://issues.apache.org/jira/browse/FLINK-12969 Project: Flink I

[GitHub] [flink] zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297025720 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution

[GitHub] [flink] zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297025720 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution

[GitHub] [flink] zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297024502 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution

[GitHub] [flink] asfgit closed pull request #8829: [FLINK-12932][table][sql client] support 'show catalogs' and 'show databases' end-2-end in TableEnvironment and SQL CLI

2019-06-24 Thread GitBox
asfgit closed pull request #8829: [FLINK-12932][table][sql client] support 'show catalogs' and 'show databases' end-2-end in TableEnvironment and SQL CLI URL: https://github.com/apache/flink/pull/8829 This is an automated me

[GitHub] [flink] bowenli86 edited a comment on issue #8829: [FLINK-12932][table][sql client] support 'show catalogs' and 'show databases' end-2-end in TableEnvironment and SQL CLI

2019-06-24 Thread GitBox
bowenli86 edited a comment on issue #8829: [FLINK-12932][table][sql client] support 'show catalogs' and 'show databases' end-2-end in TableEnvironment and SQL CLI URL: https://github.com/apache/flink/pull/8829#issuecomment-505301614 Merging as it's approved in https://github.com/apache/fli

[GitHub] [flink] bowenli86 commented on issue #8829: [FLINK-12932][table][sql client] support 'show catalogs' and 'show databases' end-2-end in TableEnvironment and SQL CLI

2019-06-24 Thread GitBox
bowenli86 commented on issue #8829: [FLINK-12932][table][sql client] support 'show catalogs' and 'show databases' end-2-end in TableEnvironment and SQL CLI URL: https://github.com/apache/flink/pull/8829#issuecomment-505301614 Merging as it's approved in https://github.com/apache/flink/pull/

[GitHub] [flink] zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297021551 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution

[GitHub] [flink] zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297020688 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/

[GitHub] [flink] zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r296671944 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/

[GitHub] [flink] zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297019812 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/

[GitHub] [flink] becketqin commented on a change in pull request #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord

2019-06-24 Thread GitBox
becketqin commented on a change in pull request #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord URL: https://github.com/apache/flink/pull/8535#discussion_r297019350 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/stream

[GitHub] [flink] becketqin commented on a change in pull request #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord

2019-06-24 Thread GitBox
becketqin commented on a change in pull request #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord URL: https://github.com/apache/flink/pull/8535#discussion_r297019114 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/stream

[GitHub] [flink] becketqin commented on issue #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord

2019-06-24 Thread GitBox
becketqin commented on issue #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord URL: https://github.com/apache/flink/pull/8535#issuecomment-505296858 @aljoscha Thanks for updating the patch and the quick response. Regarding the partitioner issue, just thinkin

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-24 Thread GitBox
gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r297001645 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java #

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-24 Thread GitBox
gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r297015961 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java ## @

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-24 Thread GitBox
gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r297015961 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java ## @

[GitHub] [flink] WeiZhong94 commented on issue #8825: [hotfix][python][docs] Fix python doc nav bar not showing issue.

2019-06-24 Thread GitBox
WeiZhong94 commented on issue #8825: [hotfix][python][docs] Fix python doc nav bar not showing issue. URL: https://github.com/apache/flink/pull/8825#issuecomment-505286302 @sunjincheng121 Thanks for your comment! I have fix the layout problem in the latest commit.

[jira] [Commented] (FLINK-12953) View logs from Job view in Web Dashboard

2019-06-24 Thread Chad Dombrova (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872011#comment-16872011 ] Chad Dombrova commented on FLINK-12953: --- The Task Manager has the same kind of spr

[jira] [Created] (FLINK-12968) Add a casting utility

2019-06-24 Thread Timo Walther (JIRA)
Timo Walther created FLINK-12968: Summary: Add a casting utility Key: FLINK-12968 URL: https://issues.apache.org/jira/browse/FLINK-12968 Project: Flink Issue Type: Sub-task Componen

[jira] [Updated] (FLINK-12924) Introduce basic type inference interfaces

2019-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12924: --- Labels: pull-request-available (was: ) > Introduce basic type inference interfaces > --

[GitHub] [flink] flinkbot commented on issue #8865: [FLINK-12924][table] Introduce basic type inference interfaces

2019-06-24 Thread GitBox
flinkbot commented on issue #8865: [FLINK-12924][table] Introduce basic type inference interfaces URL: https://github.com/apache/flink/pull/8865#issuecomment-505282412 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] twalthr opened a new pull request #8865: [FLINK-12924][table] Introduce basic type inference interfaces

2019-06-24 Thread GitBox
twalthr opened a new pull request #8865: [FLINK-12924][table] Introduce basic type inference interfaces URL: https://github.com/apache/flink/pull/8865 ## What is the purpose of the change This PR introduces an easly version of the type inference logic. It introduces the basic inter

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-24 Thread GitBox
gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r297001645 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java #

[GitHub] [flink] zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297001337 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/

[GitHub] [flink] zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297001367 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/

[GitHub] [flink] zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297000845 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/

[GitHub] [flink] zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297000813 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/

[GitHub] [flink] zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8804: [FLINK-12883][WIP][runtime] Add elaborated partition release logic URL: https://github.com/apache/flink/pull/8804#discussion_r297000509 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-24 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r296999324 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiong

[GitHub] [flink] bowenli86 edited a comment on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-06-24 Thread GitBox
bowenli86 edited a comment on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#issuecomment-505272792 @lirui-apache reminded me that there are tests added for `CatalogTable`, just an FYI that we are unifying

[GitHub] [flink] bowenli86 edited a comment on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-06-24 Thread GitBox
bowenli86 edited a comment on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#issuecomment-505272792 @lirui-apache reminded me that there are tests added for `CatalogTable`, just an FYI that we are unifying

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-24 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r296998163 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiong

[GitHub] [flink] gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-24 Thread GitBox
gaoyunhaii commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r296998178 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/partition/PartitionTable.j

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-24 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r296998163 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiong

[GitHub] [flink] flinkbot commented on issue #8864: [FLINK-12967][runtime] Change the processing that the input reaches the end to comply with the InputSelectable contract

2019-06-24 Thread GitBox
flinkbot commented on issue #8864: [FLINK-12967][runtime] Change the processing that the input reaches the end to comply with the InputSelectable contract URL: https://github.com/apache/flink/pull/8864#issuecomment-505273243 Thanks a lot for your contribution to the Apache Flink project. I'

[GitHub] [flink] sunhaibotb opened a new pull request #8864: [FLINK-12967][runtime] Change the processing that the input reaches the end to comply with the InputSelectable contract

2019-06-24 Thread GitBox
sunhaibotb opened a new pull request #8864: [FLINK-12967][runtime] Change the processing that the input reaches the end to comply with the InputSelectable contract URL: https://github.com/apache/flink/pull/8864 ## What is the purpose of the change This pull request changes the proce

[jira] [Updated] (FLINK-12967) Change the input selection switching in StreamTwoInputSelectableProcessor#checkFinished to invoking the nextSelection method of the stream operator

2019-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12967: --- Labels: pull-request-available (was: ) > Change the input selection switching in > StreamT

[GitHub] [flink] bowenli86 commented on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-06-24 Thread GitBox
bowenli86 commented on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#issuecomment-505272792 I saw that there are tests added for `CatalogTable`, just an FYI that we are unifying catalog table implementatio

[GitHub] [flink] zhijiangW commented on issue #8455: [FLINK-12284, FLINK-12637][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-06-24 Thread GitBox
zhijiangW commented on issue #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#issuecomment-505269627 @Aitozi thanks for addressing my comments. Could you rebase again fo

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-24 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r296994653 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiong

[GitHub] [flink] bowenli86 commented on a change in pull request #8636: [FLINK-12237][hive]Support Hive table stats related operations in HiveCatalog

2019-06-24 Thread GitBox
bowenli86 commented on a change in pull request #8636: [FLINK-12237][hive]Support Hive table stats related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8636#discussion_r296994502 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/fli

[GitHub] [flink] bowenli86 commented on a change in pull request #8636: [FLINK-12237][hive]Support Hive table stats related operations in HiveCatalog

2019-06-24 Thread GitBox
bowenli86 commented on a change in pull request #8636: [FLINK-12237][hive]Support Hive table stats related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8636#discussion_r296994428 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284, FLINK-12637][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r296993927 ## File path: flink-runtime/src/main/java/or

[GitHub] [flink] zjuwangg commented on a change in pull request #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog

2019-06-24 Thread GitBox
zjuwangg commented on a change in pull request #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8703#discussion_r296993863 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apac

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-24 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r296993735 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiong

[GitHub] [flink] WeiZhong94 commented on issue #8847: [FLINK-12609][python] Align the Python data types with Java

2019-06-24 Thread GitBox
WeiZhong94 commented on issue #8847: [FLINK-12609][python] Align the Python data types with Java URL: https://github.com/apache/flink/pull/8847#issuecomment-505267884 LGTM, +1 This is an automated message from the Apache Git

[GitHub] [flink] asfgit closed pull request #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog

2019-06-24 Thread GitBox
asfgit closed pull request #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8703 This is an automated message from the Apache Git Service. T

[jira] [Closed] (FLINK-12807) Support Hive table columnstats related operations in HiveCatalog

2019-06-24 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12807. Resolution: Fixed merged in 1.9.0: 194dfbcece5a77a0b0c46a1688e7510991a83218 > Support Hive table columnst

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-24 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r296992297 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiong

[GitHub] [flink] zjuwangg commented on issue #8636: [FLINK-12237][hive]Support Hive table stats related operations in HiveCatalog

2019-06-24 Thread GitBox
zjuwangg commented on issue #8636: [FLINK-12237][hive]Support Hive table stats related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8636#issuecomment-505264606 Thanks for your guys' detailed review. @bowenli86 @lirui-apache. I'll address the comments after FLINK-12

[GitHub] [flink] asfgit closed pull request #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types

2019-06-24 Thread GitBox
asfgit closed pull request #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types URL: https://github.com/apache/flink/pull/8817 This is an automated message from the Apa

[jira] [Commented] (FLINK-12966) finalize package name of Hive table source/sink

2019-06-24 Thread zjuwangg (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871951#comment-16871951 ] zjuwangg commented on FLINK-12966: -- +1 > finalize package name of Hive table source/si

[GitHub] [flink] zhijiangW commented on a change in pull request #8789: [FLINK-12890] Add partition lifecycle related Shuffle API

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #8789: [FLINK-12890] Add partition lifecycle related Shuffle API URL: https://github.com/apache/flink/pull/8789#discussion_r296990532 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/deployment/ResultPartitionDeploym

[jira] [Closed] (FLINK-12920) Drop support for register_table_sink with field_names and field_types parameters

2019-06-24 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-12920. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in master: 5d8054be418cafaff9753e85724aa8bff2157

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-24 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r296989612 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiong

[GitHub] [flink] zjuwangg commented on a change in pull request #8636: [FLINK-12237][hive]Support Hive table stats related operations in HiveCatalog

2019-06-24 Thread GitBox
zjuwangg commented on a change in pull request #8636: [FLINK-12237][hive]Support Hive table stats related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8636#discussion_r296989387 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[jira] [Commented] (FLINK-12909) add try catch when find a unique file name for the spilling channel

2019-06-24 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871942#comment-16871942 ] zhijiang commented on FLINK-12909: -- Also you should connect the PR #7191 to this Jira t

[jira] [Commented] (FLINK-12909) add try catch when find a unique file name for the spilling channel

2019-06-24 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871941#comment-16871941 ] zhijiang commented on FLINK-12909: -- The ticket does not describes the issue well. Any

[GitHub] [flink] danny0405 commented on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-06-24 Thread GitBox
danny0405 commented on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#issuecomment-505259005 @twalthr Thanks, i have replace the `CatalogTable` with `CatalogBaseTable` in `TableEnvironment`. --

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-24 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r296987179 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiong

[GitHub] [flink] bowenli86 commented on a change in pull request #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog

2019-06-24 Thread GitBox
bowenli86 commented on a change in pull request #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8703#discussion_r296986832 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apa

[GitHub] [flink] flinkbot edited a comment on issue #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog

2019-06-24 Thread GitBox
flinkbot edited a comment on issue #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8703#issuecomment-501155796 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] bowenli86 commented on issue #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog

2019-06-24 Thread GitBox
bowenli86 commented on issue #8703: [FLINK-12807][hive]Support Hive table columnstats related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8703#issuecomment-505257527 @zjuwangg LGTM, thanks for your contribution! @flinkbot approve all Merging --

[GitHub] [flink] flinkbot edited a comment on issue #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types

2019-06-24 Thread GitBox
flinkbot edited a comment on issue #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types URL: https://github.com/apache/flink/pull/8817#issuecomment-504271371 Thanks a lot for your contribution to the Apache Flink project. I'm the @fli

[GitHub] [flink] sunjincheng121 commented on issue #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types

2019-06-24 Thread GitBox
sunjincheng121 commented on issue #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types URL: https://github.com/apache/flink/pull/8817#issuecomment-505256243 @flinkbot approve all ---

[GitHub] [flink] Myasuka commented on issue #8545: [FLINK-12520] Support to provide fully-qualified domain host name in TaskManagerMetricGroup

2019-06-24 Thread GitBox
Myasuka commented on issue #8545: [FLINK-12520] Support to provide fully-qualified domain host name in TaskManagerMetricGroup URL: https://github.com/apache/flink/pull/8545#issuecomment-505255529 BTW, @zentol I noticed that you have already self-assigned this PR. It was my fault to not upd

[GitHub] [flink] godfreyhe commented on issue #8793: [FLINK-12904][table-api] Remove TableSource#getTableStats() interface

2019-06-24 Thread GitBox
godfreyhe commented on issue #8793: [FLINK-12904][table-api] Remove TableSource#getTableStats() interface URL: https://github.com/apache/flink/pull/8793#issuecomment-505253986 LGTM, +1 to merge This is an automated message fr

[GitHub] [flink] zhijiangW commented on a change in pull request #7197: [hotfix][FLINK-12909][flink-runtime] add try catch when find a unique file name for the spilling channel

2019-06-24 Thread GitBox
zhijiangW commented on a change in pull request #7197: [hotfix][FLINK-12909][flink-runtime] add try catch when find a unique file name for the spilling channel URL: https://github.com/apache/flink/pull/7197#discussion_r237408450 ## File path: flink-runtime/src/main/java/org/apache

[GitHub] [flink] Myasuka commented on issue #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …

2019-06-24 Thread GitBox
Myasuka commented on issue #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics … URL: https://github.com/apache/flink/pull/8668#issuecomment-505254024 @mans2singh Travis seems not so stable, see [mail](http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/S

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types

2019-06-24 Thread GitBox
sunjincheng121 commented on a change in pull request #8817: [FLINK-12920][python] Drop support of register_table_sink with parameters field_names and field_types URL: https://github.com/apache/flink/pull/8817#discussion_r296980034 ## File path: flink-python/pyflink/testing/source_s

[jira] [Assigned] (FLINK-5429) Code generate types between operators in Table API

2019-06-24 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-5429: --- Assignee: (was: vinoyang) > Code generate types between operators in Table API > ---

[jira] [Assigned] (FLINK-12304) AvroInputFormat should support schema evolution

2019-06-24 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-12304: Assignee: (was: vinoyang) > AvroInputFormat should support schema evolution > ---

[jira] [Closed] (FLINK-10966) Optimize the release blocking logic in BarrierBuffer

2019-06-24 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang closed FLINK-10966. Resolution: Duplicate Release Note: The mechanism of FLINK-8871 can solve the problem of this issue.

[jira] [Assigned] (FLINK-5621) Flink should provide a mechanism to prevent scheduling tasks on TaskManagers with operational issues

2019-06-24 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-5621: --- Assignee: (was: vinoyang) > Flink should provide a mechanism to prevent scheduling tasks on Task

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-24 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r296981716 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiong

[jira] [Closed] (FLINK-12363) Refactor legacy rest handlers

2019-06-24 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang closed FLINK-12363. Resolution: Won't Do Release Note: The code in the package is not legacy code, so close this issue n

[jira] [Comment Edited] (FLINK-12909) add try catch when find a unique file name for the spilling channel

2019-06-24 Thread xymaqingxiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871926#comment-16871926 ] xymaqingxiang edited comment on FLINK-12909 at 6/25/19 2:13 AM: --

[jira] [Commented] (FLINK-12966) finalize package name of Hive table source/sink

2019-06-24 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871928#comment-16871928 ] Rui Li commented on FLINK-12966: Sounds good to me > finalize package name of Hive tabl

[jira] [Comment Edited] (FLINK-12909) add try catch when find a unique file name for the spilling channel

2019-06-24 Thread xymaqingxiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871926#comment-16871926 ] xymaqingxiang edited comment on FLINK-12909 at 6/25/19 2:11 AM: --

[jira] [Commented] (FLINK-12909) add try catch when find a unique file name for the spilling channel

2019-06-24 Thread xymaqingxiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871926#comment-16871926 ] xymaqingxiang commented on FLINK-12909: --- First of all, thank you for the review [~

[jira] [Commented] (FLINK-12966) finalize package name of Hive table source/sink

2019-06-24 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871925#comment-16871925 ] Kurt Young commented on FLINK-12966: +1 to `org.apache.flink.connectors.hive` > fin

[jira] [Assigned] (FLINK-12116) Args autocast will cause exception for plan transformation in TableAPI

2019-06-24 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-12116: Assignee: (was: vinoyang) > Args autocast will cause exception for plan transformation in Tab

[jira] [Assigned] (FLINK-12848) Method equals() in RowTypeInfo should consider fieldsNames

2019-06-24 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-12848: Assignee: aloyszhang (was: vinoyang) > Method equals() in RowTypeInfo should consider fieldsName

[jira] [Created] (FLINK-12967) Change the input selection switching in StreamTwoInputSelectableProcessor#checkFinished to invoking the nextSelection method of the stream operator

2019-06-24 Thread Haibo Sun (JIRA)
Haibo Sun created FLINK-12967: - Summary: Change the input selection switching in StreamTwoInputSelectableProcessor#checkFinished to invoking the nextSelection method of the stream operator Key: FLINK-12967 URL: https

[jira] [Assigned] (FLINK-12897) Improve the Python Table API docs by adding more examples

2019-06-24 Thread Wei Zhong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zhong reassigned FLINK-12897: - Assignee: Wei Zhong > Improve the Python Table API docs by adding more examples > -

[GitHub] [flink] flinkbot commented on issue #8863: [FLINK-12962][python] Allows pyflink to be pip installed.

2019-06-24 Thread GitBox
flinkbot commented on issue #8863: [FLINK-12962][python] Allows pyflink to be pip installed. URL: https://github.com/apache/flink/pull/8863#issuecomment-505246012 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[jira] [Updated] (FLINK-12962) Allows pyflink to be pip installed

2019-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12962: --- Labels: pull-request-available (was: ) > Allows pyflink to be pip installed > -

  1   2   3   4   5   >