zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime]
Add an adapter of region failover NG for legacy scheduler
URL: https://github.com/apache/flink/pull/8851#discussion_r296994653
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/FailoverStrategy.java
##########
@@ -34,22 +34,4 @@
* @return set of IDs of vertices to restart
*/
Set<ExecutionVertexID> getTasksNeedingRestart(ExecutionVertexID
executionVertexId, Throwable cause);
-
- //
------------------------------------------------------------------------
- // factory
- //
------------------------------------------------------------------------
-
- /**
- * The factory to instantiate {@link FailoverStrategy}.
- */
- interface Factory {
Review comment:
So far I think there is no need to create a JM shared FailoverStrategy
factory. Each JM/Scheduler can create their own failoverStrategy directly.
We should implement a loader util for creating failoverStrategy from
ExecutionGraph though.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
